[GitHub] [maven-surefire] famod opened a new pull request #302: [SUREFIRE-1800] SurefireForkChannel: use LoopbackAddress

2020-06-20 Thread GitBox
famod opened a new pull request #302: URL: https://github.com/apache/maven-surefire/pull/302 The first PR: > I can see two mentioned requests. The first is the default IP adress used to bind the server socket, and the second request is a new configuration with bindAddress. https

[jira] [Commented] (MNG-6825) Cleaning Up dependencies plexus-utils/maven-shared-utils/commons-lang3/commons-io

2020-06-20 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141226#comment-17141226 ] Michael Osipov commented on MNG-6825: - I have taked a look at it. There is still a lot

[jira] [Updated] (MPOM-253) issue management URL incorrect

2020-06-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MPOM-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MPOM-253: --- Summary: issue management URL incorrect (was: issue managwment URL incorrect) > issue

[jira] [Resolved] (MPOM-208) upgrade m-scm-publish-p

2020-06-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MPOM-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MPOM-208. Resolution: Fixed done > upgrade m-scm-publish-p > --- > >

[jira] [Closed] (MPOM-208) upgrade m-scm-publish-p

2020-06-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MPOM-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MPOM-208. -- > upgrade m-scm-publish-p > --- > > Key: MPOM-208 >

[jira] [Resolved] (MPOM-168) JDK 9 requires updates to plugins

2020-06-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MPOM-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MPOM-168. Resolution: Fixed This is done. > JDK 9 requires updates to plugins > --

[jira] [Closed] (MPOM-168) JDK 9 requires updates to plugins

2020-06-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MPOM-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MPOM-168. -- > JDK 9 requires updates to plugins > - > > K

[jira] [Closed] (MPOM-251) Set minimum enforced Maven version to 3.1.1

2020-06-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MPOM-251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MPOM-251. -- > Set minimum enforced Maven version to 3.1.1 > --- >

[jira] [Resolved] (MPOM-251) Set minimum enforced Maven version to 3.1.1

2020-06-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MPOM-251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MPOM-251. Resolution: Fixed > Set minimum enforced Maven version to 3.1.1 > ---

[jira] [Created] (MPOM-253) issue managwment URL incorrect

2020-06-20 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created MPOM-253: -- Summary: issue managwment URL incorrect Key: MPOM-253 URL: https://issues.apache.org/jira/browse/MPOM-253 Project: Maven POMs Issue Type: Bug

[GitHub] [maven-apache-parent] elharo merged pull request #13: Bump maven-scm-provider-gitexe from 1.10.0 to 1.11.2

2020-06-20 Thread GitBox
elharo merged pull request #13: URL: https://github.com/apache/maven-apache-parent/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-resolver] michael-o commented on a change in pull request #54: MRESOLVER-116 document configuration options

2020-06-20 Thread GitBox
michael-o commented on a change in pull request #54: URL: https://github.com/apache/maven-resolver/pull/54#discussion_r443162400 ## File path: src/site/markdown/configuration.md ## @@ -0,0 +1,45 @@ +# Configuration Options + +Option | Type | Description | Default Value | Suppor

[GitHub] [maven-resolver] michael-o commented on pull request #54: MRESOLVER-116 document configuration options

2020-06-20 Thread GitBox
michael-o commented on pull request #54: URL: https://github.com/apache/maven-resolver/pull/54#issuecomment-647048930 How did you determine the list of properties? At least these are missing: * `aether.connector.basic.threads` * `aether.dependencyManager.verbose` -

[GitHub] [maven-resolver] michael-o commented on pull request #54: MRESOLVER-116 document configuration options

2020-06-20 Thread GitBox
michael-o commented on pull request #54: URL: https://github.com/apache/maven-resolver/pull/54#issuecomment-647048109 `sessionState` is used in `DefaultUpdateCheckManager`. Have a look at the code. This is an automated messa

[GitHub] [maven-resolver] michael-o commented on pull request #54: MRESOLVER-116 document configuration options

2020-06-20 Thread GitBox
michael-o commented on pull request #54: URL: https://github.com/apache/maven-resolver/pull/54#issuecomment-647046620 `aether.artifactResolver.snapshotNormalization` is obvious in the code: It replaces the the timestamped snapshot file name with a filename containing `SNAPSHOT` only. ---

[jira] [Commented] (MNG-6863) --also-make is being ignored when calling --resume-from

2020-06-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141212#comment-17141212 ] Hudson commented on MNG-6863: - Build succeeded in Jenkins: Maven TLP » maven » master #433 See

[GitHub] [maven-resolver] michael-o commented on pull request #54: MRESOLVER-116 document configuration options

2020-06-20 Thread GitBox
michael-o commented on pull request #54: URL: https://github.com/apache/maven-resolver/pull/54#issuecomment-647046258 As far as I understand the code for `aether.connector.smartChecksums` it instructs Resolver to validate the checksums from remote with the checksums calculated by Resolver.

[GitHub] [maven-resolver] michael-o commented on a change in pull request #54: MRESOLVER-116 document configuration options

2020-06-20 Thread GitBox
michael-o commented on a change in pull request #54: URL: https://github.com/apache/maven-resolver/pull/54#discussion_r443159247 ## File path: src/site/markdown/configuration.md ## @@ -0,0 +1,45 @@ +# Configuration Options + +Option | Type | Description | Default Value | Suppor

[jira] [Updated] (MRESOLVER-116) Add page with all supported configuration options

2020-06-20 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-116: - Fix Version/s: 1.4.3 > Add page with all supported configuration options > ---

[GitHub] [maven-integration-testing] rfscholte commented on pull request #58: [MNG-5571] The --resume-from hint at the end of a failing build shoul…

2020-06-20 Thread GitBox
rfscholte commented on pull request #58: URL: https://github.com/apache/maven-integration-testing/pull/58#issuecomment-647043499 please rebase This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [maven] rfscholte closed pull request #341: [MNG-6863] Support --also-make flag in combination with --resume-from. - Refactoring

2020-06-20 Thread GitBox
rfscholte closed pull request #341: URL: https://github.com/apache/maven/pull/341 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [maven] rfscholte commented on pull request #341: [MNG-6863] Support --also-make flag in combination with --resume-from. - Refactoring

2020-06-20 Thread GitBox
rfscholte commented on pull request #341: URL: https://github.com/apache/maven/pull/341#issuecomment-647043160 Fixed in https://github.com/apache/maven/commit/1e217703a8f6d6378e8a92c57878f53368b289af This is an automated mes

[jira] [Commented] (MRESOLVER-91) Error messages not clear when not reattempting resolution when a previous attempt failed and the failure was cached

2020-06-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141203#comment-17141203 ] Hudson commented on MRESOLVER-91: - Build succeeded in Jenkins: Maven TLP » maven-resolv

[jira] [Closed] (MRESOLVER-91) Error messages not clear when not reattempting resolution when a previous attempt failed and the failure was cached

2020-06-20 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-91. --- Resolution: Fixed Fixed with [55fa2d7e594afebfde4a7e1d3cec23a2efc63d1d|https://gitbox.apac

[GitHub] [maven-resolver] asfgit closed pull request #37: Reword error messages on failures due to cached previous failures.

2020-06-20 Thread GitBox
asfgit closed pull request #37: URL: https://github.com/apache/maven-resolver/pull/37 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Updated] (MRESOLVER-91) Error messages not clear when not reattempting resolution when a previous attempt failed and the failure was cached

2020-06-20 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-91: Summary: Error messages not clear when not reattempting resolution when a previous attemp

[jira] [Assigned] (MRESOLVER-91) Error messages not clear when not reattempting resolution when a previous attempt failed and the failure was cached.

2020-06-20 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRESOLVER-91: --- Assignee: Michael Osipov > Error messages not clear when not reattempting resoluti

[GitHub] [maven-apache-parent] elharo merged pull request #18: Bump maven-scm-provider-svnexe from 1.10.0 to 1.11.2

2020-06-20 Thread GitBox
elharo merged pull request #18: URL: https://github.com/apache/maven-apache-parent/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-apache-parent] elharo merged pull request #17: Bump maven-scm-plugin from 1.9.5 to 1.11.2

2020-06-20 Thread GitBox
elharo merged pull request #17: URL: https://github.com/apache/maven-apache-parent/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-apache-parent] elharo merged pull request #7: Bump maven-scm-api from 1.10.0 to 1.11.2

2020-06-20 Thread GitBox
elharo merged pull request #7: URL: https://github.com/apache/maven-apache-parent/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Created] (SUREFIRE-1805) New config `bindAddress` and `connectionAddress` in SurefireForkNodeFactory

2020-06-20 Thread Tibor Digana (Jira)
Tibor Digana created SUREFIRE-1805: -- Summary: New config `bindAddress` and `connectionAddress` in SurefireForkNodeFactory Key: SUREFIRE-1805 URL: https://issues.apache.org/jira/browse/SUREFIRE-1805 P

[jira] [Updated] (SUREFIRE-1801) New TCP communication mode defers "Listening for transport" debug message

2020-06-20 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1801: --- Fix Version/s: 3.0.0-M6 > New TCP communication mode defers "Listening for transport" debu

[jira] [Updated] (SUREFIRE-1800) SurefireForkChannel binds to wrong IP

2020-06-20 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1800: --- Fix Version/s: 3.0.0-M6 > SurefireForkChannel binds to wrong IP >

[GitHub] [maven] rfscholte commented on pull request #350: [MNG-6907] fix endless loop in StringSearchModelInterpolator

2020-06-20 Thread GitBox
rfscholte commented on pull request #350: URL: https://github.com/apache/maven/pull/350#issuecomment-647010047 So this means that a plugin that needs it, will require at least Maven 3.6.2 at compile time (or use reflection) and at runtime it must verify if `StringVisitorModelInterpolator`

[jira] [Commented] (MNG-6891) Improve support --fail-on-severity

2020-06-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141113#comment-17141113 ] Hudson commented on MNG-6891: - Build succeeded in Jenkins: Maven TLP » maven » master #432 See

[GitHub] [maven-apache-parent] elharo merged pull request #12: Bump maven-war-plugin from 3.2.2 to 3.3.0

2020-06-20 Thread GitBox
elharo merged pull request #12: URL: https://github.com/apache/maven-apache-parent/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443137471 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @@ -6066,23 +6066,15 @@ private URL getResource( fin

[jira] [Assigned] (MNG-6802) FileProfileActivator changes FileProfileActivator.exists which lets flattened resolveCiFriendliesOnly depending fail activating profile

2020-06-20 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte reassigned MNG-6802: --- Assignee: Robert Scholte > FileProfileActivator changes FileProfileActivator.exists which lets

[GitHub] [maven-javadoc-plugin] elharo commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
elharo commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443137126 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @@ -6066,23 +6066,15 @@ private URL getResource( final

[GitHub] [maven] rfscholte commented on pull request #351: Refactor MavenCli.populateRequest

2020-06-20 Thread GitBox
rfscholte commented on pull request #351: URL: https://github.com/apache/maven/pull/351#issuecomment-647005421 Can't apply this patch anymore, please rebase This is an automated message from the Apache Git Service. To respond

[GitHub] [maven] rfscholte closed pull request #360: [MNG-6891] Delete the useless codes which won't be executed

2020-06-20 Thread GitBox
rfscholte closed pull request #360: URL: https://github.com/apache/maven/pull/360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [maven] rfscholte commented on pull request #360: [MNG-6891] Delete the useless codes which won't be executed

2020-06-20 Thread GitBox
rfscholte commented on pull request #360: URL: https://github.com/apache/maven/pull/360#issuecomment-647005172 Fixed in https://github.com/apache/maven/commit/1e5bf55e12126f4dc224d471d2dc52f3ac182c24 Thanks for the PR! Th

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443136388 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @@ -6066,23 +6066,15 @@ private URL getResource( fin

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443136388 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @@ -6066,23 +6066,15 @@ private URL getResource( fin

[GitHub] [maven] slachiewicz commented on pull request #350: [MNG-6907] fix endless loop in StringSearchModelInterpolator

2020-06-20 Thread GitBox
slachiewicz commented on pull request #350: URL: https://github.com/apache/maven/pull/350#issuecomment-647004068 SearchStringInterpreter is no longer in use in Maven Core and in 3.6.3 shouldn't be injected This is an automat

[GitHub] [maven-apache-parent] elharo merged pull request #8: Bump maven-shade-plugin from 3.2.3 to 3.2.4

2020-06-20 Thread GitBox
elharo merged pull request #8: URL: https://github.com/apache/maven-apache-parent/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-javadoc-plugin] elharo commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
elharo commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443135150 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @@ -6066,23 +6066,15 @@ private URL getResource( final

[GitHub] [maven-apache-parent] elharo merged pull request #16: Bump maven-ear-plugin from 3.0.1 to 3.0.2

2020-06-20 Thread GitBox
elharo merged pull request #16: URL: https://github.com/apache/maven-apache-parent/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-integration-testing] rfscholte commented on pull request #61: [MNG-5760] Add integration tests for "resume" feature

2020-06-20 Thread GitBox
rfscholte commented on pull request #61: URL: https://github.com/apache/maven-integration-testing/pull/61#issuecomment-647002481 Added with https://github.com/apache/maven-integration-testing/commit/094373ddb6c47c8eeba1005bc11d70dcaeeb9330

[GitHub] [maven-integration-testing] rfscholte closed pull request #61: [MNG-5760] Add integration tests for "resume" feature

2020-06-20 Thread GitBox
rfscholte closed pull request #61: URL: https://github.com/apache/maven-integration-testing/pull/61 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-shade-plugin] sullis opened a new pull request #52: add Dependabot

2020-06-20 Thread GitBox
sullis opened a new pull request #52: URL: https://github.com/apache/maven-shade-plugin/pull/52 https://github.blog/2020-06-01-keep-all-your-packages-up-to-date-with-dependabot/ Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Ma

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443134231 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @@ -6066,23 +6066,15 @@ private URL getResource( fin

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443133786 ## File path: src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java ## @@ -1815,7 +1831,7 @@ private static CloseableHttpClient crea

[GitHub] [maven-apache-parent] elharo merged pull request #11: Bump maven-javadoc-plugin from 3.0.1 to 3.2.0

2020-06-20 Thread GitBox
elharo merged pull request #11: URL: https://github.com/apache/maven-apache-parent/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443133786 ## File path: src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java ## @@ -1815,7 +1831,7 @@ private static CloseableHttpClient crea

[GitHub] [maven-javadoc-plugin] elharo commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
elharo commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443133717 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @@ -6066,23 +6066,15 @@ private URL getResource( final

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443133256 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @@ -6066,23 +6066,15 @@ private URL getResource( fin

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443133256 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @@ -6066,23 +6066,15 @@ private URL getResource( fin

[GitHub] [maven-javadoc-plugin] elharo commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
elharo commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443133139 ## File path: src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java ## @@ -1815,7 +1831,7 @@ private static CloseableHttpClient createH

[GitHub] [maven] rfscholte closed pull request #359: [MNG-6929] Do not create empty file on error

2020-06-20 Thread GitBox
rfscholte closed pull request #359: URL: https://github.com/apache/maven/pull/359 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [maven] rfscholte closed pull request #342: [MNG-5760] Add --resume / -r switch

2020-06-20 Thread GitBox
rfscholte closed pull request #342: URL: https://github.com/apache/maven/pull/342 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [maven] rfscholte commented on pull request #342: [MNG-5760] Add --resume / -r switch

2020-06-20 Thread GitBox
rfscholte commented on pull request #342: URL: https://github.com/apache/maven/pull/342#issuecomment-646999247 Fixed in https://github.com/apache/maven/commit/658ad90b3850131e4a73fd6cca2ead30f6e5f213 This is an automated mes

[GitHub] [maven] rfscholte commented on pull request #359: [MNG-6929] Do not create empty file on error

2020-06-20 Thread GitBox
rfscholte commented on pull request #359: URL: https://github.com/apache/maven/pull/359#issuecomment-646999385 Fixed in https://github.com/apache/maven/commit/1f8e0732b888f2a0c939b7d010a7d7b9c16c78f5 This is an automated mes

[GitHub] [maven-javadoc-plugin] elharo commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
elharo commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443133007 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @@ -6066,23 +6066,15 @@ private URL getResource( final

[GitHub] [maven-apache-parent] elharo merged pull request #6: Bump maven-scm-provider-svn-commons from 1.10.0 to 1.11.2

2020-06-20 Thread GitBox
elharo merged pull request #6: URL: https://github.com/apache/maven-apache-parent/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443130157 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @@ -6066,23 +6066,15 @@ private URL getResource( fin

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443130157 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @@ -6066,23 +6066,15 @@ private URL getResource( fin

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443130718 ## File path: src/test/java/org/apache/maven/plugins/javadoc/JavadocJarTest.java ## @@ -154,7 +154,7 @@ public void testInvalidDestdir()

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443130579 ## File path: src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java ## @@ -629,36 +650,31 @@ protected static String parseJavadocMem

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443130157 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @@ -6066,23 +6066,15 @@ private URL getResource( fin

[GitHub] [maven-javadoc-plugin] elharo commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
elharo commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443129912 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @@ -6066,23 +6066,15 @@ private URL getResource( final

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443129951 ## File path: src/test/java/org/apache/maven/plugins/javadoc/AggregatorJavadocReportTest.java ## @@ -173,20 +173,13 @@ private static String

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443129775 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @@ -6066,23 +6066,15 @@ private URL getResource( fin

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443129539 ## File path: src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java ## @@ -1815,7 +1831,7 @@ private static CloseableHttpClient crea

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443129539 ## File path: src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java ## @@ -1815,7 +1831,7 @@ private static CloseableHttpClient crea

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443129301 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @@ -6066,23 +6066,15 @@ private URL getResource( fin

[jira] [Closed] (MNG-6942) Arbitrary file write during archive extraction ("Zip Slip") in wrapper

2020-06-20 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-6942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MNG-6942. --- Fix Version/s: 3.7.0 Resolution: Fixed Fixed in [954cd81c9b1ab96306950c53a723eb959f3da311|https

[jira] [Commented] (MNG-6942) Arbitrary file write during archive extraction ("Zip Slip") in wrapper

2020-06-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141063#comment-17141063 ] Hudson commented on MNG-6942: - Build succeeded in Jenkins: Maven TLP » maven » master #431 See

[GitHub] [maven-apache-parent] elharo merged pull request #14: Bump maven-plugin-plugin from 3.5.2 to 3.6.0

2020-06-20 Thread GitBox
elharo merged pull request #14: URL: https://github.com/apache/maven-apache-parent/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (MNG-5760) Add `-r/--resume` to automatically resume from the last failure point

2020-06-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141060#comment-17141060 ] Hudson commented on MNG-5760: - Build succeeded in Jenkins: Maven TLP » maven » master #430 See

[GitHub] [maven-javadoc-plugin] elharo commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
elharo commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443127531 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @@ -6066,23 +6066,15 @@ private URL getResource( final

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443126772 ## File path: src/test/java/org/apache/maven/plugins/javadoc/FixJavadocMojoTest.java ## @@ -22,10 +22,7 @@ import java.io.File; import java

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443126587 ## File path: src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java ## @@ -629,35 +650,34 @@ protected static String parseJavadocMem

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443126154 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractFixJavadocMojo.java ## @@ -856,6 +831,23 @@ private void parseClirrTextO

[jira] [Closed] (MNG-5760) Add `-r/--resume` to automatically resume from the last failure point

2020-06-20 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MNG-5760. --- Fix Version/s: 3.7.0 Resolution: Fixed Fixed in [658ad90b3850131e4a73fd6cca2ead30f6e5f213|https

[jira] [Updated] (MNG-5760) Add `-r/--resume` to automatically resume from the last failure point

2020-06-20 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MNG-5760: Summary: Add `-r/--resume` to automatically resume from the last failure point (was: All `-rf` to au

[jira] [Assigned] (MNG-5760) All `-rf` to automatically resume from the last failure point

2020-06-20 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte reassigned MNG-5760: --- Assignee: Robert Scholte > All `-rf` to automatically resume from the last failure point > ---

[GitHub] [maven-apache-parent] elharo merged pull request #15: Bump maven-site-plugin from 3.7.1 to 3.9.0

2020-06-20 Thread GitBox
elharo merged pull request #15: URL: https://github.com/apache/maven-apache-parent/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-dependency-plugin] elharo commented on a change in pull request #60: [MDEP-645] update docs to reflect new target

2020-06-20 Thread GitBox
elharo commented on a change in pull request #60: URL: https://github.com/apache/maven-dependency-plugin/pull/60#discussion_r443124446 ## File path: src/site/apt/index.apt.vm ## @@ -72,6 +72,8 @@ ${project.name} *{{{./list-mojo.html}dependency:list}} alias for resolve tha

[jira] [Commented] (SUREFIRE-1802) improve Reproducible Builds after Surefire 3.0.0-M5 release

2020-06-20 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141043#comment-17141043 ] Tibor Digana commented on SUREFIRE-1802: [~hboutemy] Does it make sense to deb

[jira] [Assigned] (MNG-6942) Arbitrary file write during archive extraction ("Zip Slip") in wrapper

2020-06-20 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-6942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte reassigned MNG-6942: --- Assignee: Robert Scholte > Arbitrary file write during archive extraction ("Zip Slip") in wrap

[GitHub] [maven-javadoc-plugin] elharo commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-06-20 Thread GitBox
elharo commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r443121454 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractFixJavadocMojo.java ## @@ -856,6 +831,23 @@ private void parseClirrTextOutp

[GitHub] [maven-resolver] gaganis commented on pull request #37: Reword error messages on failures due to cached previous failures.

2020-06-20 Thread GitBox
gaganis commented on pull request #37: URL: https://github.com/apache/maven-resolver/pull/37#issuecomment-646973808 > @gaganis Do you think it makes sense to add the update policy to the exception message? I am not sure TBH. This error message is an expression from a quite complicat

[GitHub] [maven-surefire] Tibor17 merged pull request #301: version typo

2020-06-20 Thread GitBox
Tibor17 merged pull request #301: URL: https://github.com/apache/maven-surefire/pull/301 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (MNG-6562) WARN if plugins injected by default lifecycle bindings don't have their version locked in pom.xml or parent

2020-06-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141017#comment-17141017 ] Hudson commented on MNG-6562: - Build succeeded in Jenkins: Maven TLP » maven » master #429 See

[GitHub] [maven-wagon] michael-o commented on pull request #69: Remove unused class

2020-06-20 Thread GitBox
michael-o commented on pull request #69: URL: https://github.com/apache/maven-wagon/pull/69#issuecomment-646963149 I wonder why the class is there, but never used... This is an automated message from the Apache Git Service. T

[jira] [Closed] (MNG-6562) WARN if plugins injected by default lifecycle bindings don't have their version locked in pom.xml or parent

2020-06-20 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MNG-6562. --- Assignee: Robert Scholte (was: Herve Boutemy) Resolution: Fixed Fixed in [a7771a1234d7b5dc7be5d

[GitHub] [maven-wagon] michael-o commented on pull request #69: Remove unused class

2020-06-20 Thread GitBox
michael-o commented on pull request #69: URL: https://github.com/apache/maven-wagon/pull/69#issuecomment-646961845 Looking into... This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [maven-wagon] pzygielo commented on pull request #69: Remove unused class

2020-06-20 Thread GitBox
pzygielo commented on pull request #69: URL: https://github.com/apache/maven-wagon/pull/69#issuecomment-646961527 May I ask for review, please? This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Commented] (MNG-6929) Maven Wrapper creates empty file when it fails behind proxy 407

2020-06-20 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MNG-6929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140994#comment-17140994 ] Benjamin Marwell commented on MNG-6929: --- Thanks for merging! > Maven Wrapper creates

  1   2   >