[GitHub] [maven-resolver] rmannibucau commented on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
rmannibucau commented on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661669355 If the context is not global it is broken in case of -T and 2 modules resolving concurrently the same artifact - or you synchronize it and break concurrent feature. So at

[GitHub] [maven-resolver] michael-o edited a comment on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
michael-o edited a comment on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661648420 Access to files is concurrent. The concurrency is in the system, at most sync context factory and always in/with the locks.

[jira] [Commented] (MNG-6965) archetype-packaging.jar:3.1.2 requires org.codehaus.plexus:plexus-utils:jar:1.1

2020-07-20 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161762#comment-17161762 ] Michael Osipov commented on MNG-6965: - Why do you consider this to be a bug? It is obvi

[GitHub] [maven-surefire] rmannibucau commented on a change in pull request #308: [SUREFIRE-1827] The console output is not flushed

2020-07-20 Thread GitBox
rmannibucau commented on a change in pull request #308: URL: https://github.com/apache/maven-surefire/pull/308#discussion_r457869411 ## File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/AbstractMasterProcessChannelProcessorFactory.java ## @@ -0,0 +1

[GitHub] [maven-surefire] eolivelli commented on a change in pull request #308: [SUREFIRE-1827] The console output is not flushed

2020-07-20 Thread GitBox
eolivelli commented on a change in pull request #308: URL: https://github.com/apache/maven-surefire/pull/308#discussion_r457869371 ## File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/AbstractMasterProcessChannelProcessorFactory.java ## @@ -0,0 +1,1

[GitHub] [maven-surefire] rmannibucau commented on a change in pull request #308: [SUREFIRE-1827] The console output is not flushed

2020-07-20 Thread GitBox
rmannibucau commented on a change in pull request #308: URL: https://github.com/apache/maven-surefire/pull/308#discussion_r457868926 ## File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/AbstractMasterProcessChannelProcessorFactory.java ## @@ -0,0 +1

[GitHub] [maven-surefire] rmannibucau commented on a change in pull request #308: [SUREFIRE-1827] The console output is not flushed

2020-07-20 Thread GitBox
rmannibucau commented on a change in pull request #308: URL: https://github.com/apache/maven-surefire/pull/308#discussion_r457868070 ## File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/LegacyMasterProcessChannelProcessorFactory.java ## @@ -36,8 +36

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #308: [SUREFIRE-1827] The console output is not flushed

2020-07-20 Thread GitBox
Tibor17 commented on a change in pull request #308: URL: https://github.com/apache/maven-surefire/pull/308#discussion_r457858940 ## File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/LegacyMasterProcessChannelProcessorFactory.java ## @@ -36,8 +36,10

[GitHub] [maven-resolver] michael-o commented on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
michael-o commented on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661648420 Access to files is concurrent. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-surefire] olamy commented on a change in pull request #308: [SUREFIRE-1827] The console output is not flushed

2020-07-20 Thread GitBox
olamy commented on a change in pull request #308: URL: https://github.com/apache/maven-surefire/pull/308#discussion_r457827367 ## File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/spi/LegacyMasterProcessChannelProcessorFactory.java ## @@ -36,8 +36,10 @@

[jira] [Created] (MNG-6965) archetype-packaging.jar:3.1.2 requires org.codehaus.plexus:plexus-utils:jar:1.1

2020-07-20 Thread Mark Nolan (Jira)
Mark Nolan created MNG-6965: --- Summary: archetype-packaging.jar:3.1.2 requires org.codehaus.plexus:plexus-utils:jar:1.1 Key: MNG-6965 URL: https://issues.apache.org/jira/browse/MNG-6965 Project: Maven

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #308: [SUREFIRE-1827] The console output is not flushed

2020-07-20 Thread GitBox
Tibor17 edited a comment on pull request #308: URL: https://github.com/apache/maven-surefire/pull/308#issuecomment-661486443 @rmannibucau I have added two unit tests. But the important thing is the manual test i made. I have expected that you would like to make the same test on your PC.

[GitHub] [maven-surefire] Tibor17 commented on pull request #308: [SUREFIRE-1827] The console output is not flushed

2020-07-20 Thread GitBox
Tibor17 commented on pull request #308: URL: https://github.com/apache/maven-surefire/pull/308#issuecomment-661486443 @rmannibucau I have added two unit tests. But the important thing is the manual test i made. I have expected that you would like to make the same test on your PC. So i

[GitHub] [maven-resolver] Tibor17 commented on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
Tibor17 commented on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661477498 Then why we have the locks due to nothing is concurrent? This is an automated message from the Apache Git Ser

[jira] [Created] (MNG-6964) Maven version sorting is internally inconsistent

2020-07-20 Thread David M. Lloyd (Jira)
David M. Lloyd created MNG-6964: --- Summary: Maven version sorting is internally inconsistent Key: MNG-6964 URL: https://issues.apache.org/jira/browse/MNG-6964 Project: Maven Issue Type: Bug

[GitHub] [maven-resolver] michael-o commented on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
michael-o commented on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661375379 acquire() is not. Neither is LockSyncContext. This is obvious from the docs. This is an automated message

[jira] [Created] (JXR-155) Unknown packaging waring for type bundle

2020-07-20 Thread Jira
Alexander Gängel created JXR-155: Summary: Unknown packaging waring for type bundle Key: JXR-155 URL: https://issues.apache.org/jira/browse/JXR-155 Project: Maven JXR Issue Type: Bug

[GitHub] [maven-resolver] Tibor17 commented on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
Tibor17 commented on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661311488 Is the instance of `LockingSyncContext` concurrent? Is the `acquire` method concurrent? This is an automat

[GitHub] [maven-resolver] michael-o commented on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
michael-o commented on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661296728 @Tibor17 I thought the same, but that's not true because map is never shared, but scoped to the current thread. So the access is sequential. The `FileLockManager` has to be

[GitHub] [maven-resolver] Tibor17 edited a comment on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
Tibor17 edited a comment on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661295037 @rmannibucau i was talking to @michael-o about the `Map` , but having a look at the takari impl i have to say that they are not totally safe wit the [Line60](https

[GitHub] [maven-resolver] michael-o commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
michael-o commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r457649439 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.e

[GitHub] [maven-resolver] Tibor17 commented on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
Tibor17 commented on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661295037 @rmannibucau i was talking to @michael-o about the Map but having a look at the takari impl i have to say that they are not totally safe wt the [Line60](https://github.co

[GitHub] [maven-resolver] michael-o edited a comment on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
michael-o edited a comment on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661291308 > Syncontext must be global if you want an useful global lock but it uses an int so it is not thread safe. If not global it does not impl its original goal so in all

[GitHub] [maven-resolver] michael-o commented on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
michael-o commented on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661291308 > Syncontext must be global if you want an useful global lock but it uses an int so it is not thread safe. If not global it does not impl its original goal so in all cases

[GitHub] [maven-resolver] rmannibucau commented on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
rmannibucau commented on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661280048 2. Syncontext must be global if you want an useful global lock but it uses an int so it is not thread safe. If not global it does not impl its original goal so in all cas

[GitHub] [maven-resolver] michael-o commented on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
michael-o commented on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661272254 Please explain point 2. Why do you consider it as non-thread safe? The lock itself is thread-safe and can be passed around. That's the hole point. The `SyncContext` does no

[GitHub] [maven-surefire] rmannibucau commented on pull request #308: [SUREFIRE-1827] The console output is not flushed

2020-07-20 Thread GitBox
rmannibucau commented on pull request #308: URL: https://github.com/apache/maven-surefire/pull/308#issuecomment-661267659 Can be good to at least support a system property for flush interval and not leak the flush thread (stop the scheduler properly) but otherwise looks good.

[jira] [Commented] (SUREFIRE-1822) XML report with empty name attribute by 3.0.0-M5 when failing in @BeforeAll/@BeforeClass

2020-07-20 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161421#comment-17161421 ] Tibor Digana commented on SUREFIRE-1822: Regarding the option (2) the change b

[jira] [Commented] (SUREFIRE-1811) Add resources to JPMS test module

2020-07-20 Thread Gili (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161363#comment-17161363 ] Gili commented on SUREFIRE-1811: Is ClassGraph being loaded on the modulepath or class

[jira] [Commented] (SUREFIRE-1811) Add resources to JPMS test module

2020-07-20 Thread Pavel_K (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161358#comment-17161358 ] Pavel_K commented on SUREFIRE-1811: --- [~sor] It seems that we stopped. Can you sugges

[GitHub] [maven-dependency-plugin] bimargulies-google commented on a change in pull request #80: [MDEP-708] dependency:analyze should recommend test scope where possible

2020-07-20 Thread GitBox
bimargulies-google commented on a change in pull request #80: URL: https://github.com/apache/maven-dependency-plugin/pull/80#discussion_r457525286 ## File path: pom.xml ## @@ -427,14 +428,18 @@ under the License. tree-verbose/pom.xml

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #307: Change default debug options to not use legacy options

2020-07-20 Thread GitBox
Tibor17 edited a comment on pull request #307: URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-661116224 The GH workflows are really crappy. After the MSC has taken it, this CI is unreliable. The jobs are duplicated, the uploads are skipped on Win and MacOS and I do

[GitHub] [maven-surefire] Tibor17 commented on pull request #307: Change default debug options to not use legacy options

2020-07-20 Thread GitBox
Tibor17 commented on pull request #307: URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-661116224 The GH workflows are really crappy. After the MSC has taken it, this CI is unreliable. The jobs are duplicated, the uploads are skipped on Win and MacOS and I do not see

[GitHub] [maven-javadoc-plugin] elharo commented on pull request #31: [MJAVADOC-624] tagletArtifacts throws exception in case artifact is a Java 9+ module

2020-07-20 Thread GitBox
elharo commented on pull request #31: URL: https://github.com/apache/maven-javadoc-plugin/pull/31#issuecomment-661115890 Tests failing: [ERROR] Errors: [ERROR] JavadocReportTest.testTagletArtifacts:1177 » MojoExecution An error has occurr... [INFO] [ERROR] Tests run: 69

[GitHub] [maven-resolver] Tibor17 commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
Tibor17 commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r457495658 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.ecl

[GitHub] [maven-resolver] rmannibucau commented on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
rmannibucau commented on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661093235 Well there are multiple options: 1. Do nothing (we keep these issues) - don't think it would be good 2. Do a global not thread safe lock (and you fix a few issues

[GitHub] [maven-surefire] Thihup edited a comment on pull request #307: Change default debug options to not use legacy options

2020-07-20 Thread GitBox
Thihup edited a comment on pull request #307: URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-661083926 @rmannibucau @Tibor17 I've changed to localhost:5005, however, some tests have failed and I couldn't understand why. Can you have a look? -

[GitHub] [maven-surefire] Thihup commented on pull request #307: Change default debug options to not use legacy options

2020-07-20 Thread GitBox
Thihup commented on pull request #307: URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-661083926 @rmannibucau I've changed to localhost:5005, however, some tests have failed and I couldn't understand why. Can you have a look? --

[GitHub] [maven-javadoc-plugin] XenoAmess edited a comment on pull request #48: [MJAVADOC-653] fix javadoc; fix code smells

2020-07-20 Thread GitBox
XenoAmess edited a comment on pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#issuecomment-661078806 @elharo > Absent measurement, it can't be claimed that a PR improves performance; OK, if you see it this way I will not oppose. But I thought

[GitHub] [maven-javadoc-plugin] XenoAmess commented on pull request #48: [MJAVADOC-653] fix javadoc; fix code smells

2020-07-20 Thread GitBox
XenoAmess commented on pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#issuecomment-661078806 > Absent measurement, it can't be claimed that a PR improves performance; OK, if you see it this way I will not oppose. > and measuring these things is

[GitHub] [maven-javadoc-plugin] XenoAmess edited a comment on pull request #48: [MJAVADOC-653] fix javadoc; fix code smells

2020-07-20 Thread GitBox
XenoAmess edited a comment on pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#issuecomment-661078806 @elharo > Absent measurement, it can't be claimed that a PR improves performance; OK, if you see it this way I will not oppose. > and meas

[GitHub] [maven-javadoc-plugin] elharo commented on pull request #48: [MJAVADOC-653] fix javadoc; fix code smells

2020-07-20 Thread GitBox
elharo commented on pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#issuecomment-661071504 Absent measurement, it can't be claimed that a PR improves performance; and measuring these things is hard. --

[GitHub] [maven-javadoc-plugin] XenoAmess commented on pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-07-20 Thread GitBox
XenoAmess commented on pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#issuecomment-661070559 > Can you put numbers on the performance improvement? @elharo sorry but I didn't get what you mean by "put numbers on". If you need performance test then I t

[GitHub] [maven-resolver] michael-o commented on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
michael-o commented on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661068773 Currently, there is nothing available: broken, see depending issues. Believe, most people don't even know how to enable something via extensions, they will simply file a bu

[GitHub] [maven-dependency-plugin] michael-o commented on pull request #76: avoid trailing whitespace

2020-07-20 Thread GitBox
michael-o commented on pull request #76: URL: https://github.com/apache/maven-dependency-plugin/pull/76#issuecomment-661065330 OK, went through the code, here it is: ``` if ( theOutputScope && artifact.isOptional() ) { messageBuilder.a( "

[GitHub] [maven-resolver] rmannibucau commented on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
rmannibucau commented on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661063742 @michael-o for me any provided impl must be concurrent friendly since it is a core feature of maven otherwise first bug is that the feature is not compatible wiht maven.

[GitHub] [maven-resolver] rmannibucau commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
rmannibucau commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r457417864 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org

[GitHub] [maven-resolver] michael-o commented on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
michael-o commented on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661059577 @rmannibucau If you are unhappy with the SPI, create a JIRA issue we can discuss for Resolver 2.0. The SPI *does* support any kind of locks. I have chosen to provide the si

[GitHub] [maven-resolver] michael-o commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
michael-o commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r457412151 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.e

[GitHub] [maven-resolver] rmannibucau commented on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
rmannibucau commented on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661057656 @michael-o fact is current API is not a SPI (as expected) but a specific impl for a global lock. I think this is wrong and is not what is epxected by such work. ---

[GitHub] [maven-resolver] rmannibucau commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
rmannibucau commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r457409869 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org

[GitHub] [maven-resolver] michael-o commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
michael-o commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r457405575 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.e

[GitHub] [maven-surefire] Tibor17 commented on pull request #305: enable to flush regularly output of the forked process

2020-07-20 Thread GitBox
Tibor17 commented on pull request #305: URL: https://github.com/apache/maven-surefire/pull/305#issuecomment-661052630 @eolivelli @rmannibucau welcome to the PR #308 . This is an automated message from the Apache Git S

[GitHub] [maven-resolver] michael-o commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
michael-o commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r457403082 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.e

[GitHub] [maven-resolver] michael-o commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
michael-o commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r457401794 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.e

[GitHub] [maven-surefire] Tibor17 commented on pull request #308: [SUREFIRE-1827] The console output is not flushed

2020-07-20 Thread GitBox
Tibor17 commented on pull request #308: URL: https://github.com/apache/maven-surefire/pull/308#issuecomment-661051683 Missing the unit tests for this functionality. I will work on it tomorrow. This is an automated message

[GitHub] [maven-surefire] Tibor17 opened a new pull request #308: [SUREFIRE-1827] The console output is not flushed

2020-07-20 Thread GitBox
Tibor17 opened a new pull request #308: URL: https://github.com/apache/maven-surefire/pull/308 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [maven-resolver] michael-o commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
michael-o commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r457400875 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org.e

[GitHub] [maven-resolver] michael-o commented on pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
michael-o commented on pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#issuecomment-661050855 @rmannibucau Thanks, looking trough..judging from your comments you have neither read the API contract not the JIRA issues. ---

[jira] [Commented] (MRESOURCES-254) Filtering of compound properties using properties added by other plugins fails without ${*} delimiter

2020-07-20 Thread Dennis Lundberg (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161244#comment-17161244 ] Dennis Lundberg commented on MRESOURCES-254: I'm not sure that I understa

[jira] [Commented] (MSHARED-848) Code Improvement in ReaderFactory to get rid of commons-io dependency

2020-07-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161234#comment-17161234 ] Hudson commented on MSHARED-848: Build succeeded in Jenkins: Maven TLP » maven-shared-ut

[jira] [Commented] (MRESOURCES-132) Copying of files with permissions broken

2020-07-20 Thread Dennis Lundberg (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161231#comment-17161231 ] Dennis Lundberg commented on MRESOURCES-132: MRESOURCES-236 has been fixe

[GitHub] [maven-shared-utils] elharo merged pull request #59: [MSHARED-848] deprecate XmlStreamReader

2020-07-20 Thread GitBox
elharo merged pull request #59: URL: https://github.com/apache/maven-shared-utils/pull/59 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (MRESOURCES-254) Filtering of compound properties using properties added by other plugins fails without ${*} delimiter

2020-07-20 Thread Andre Brait (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161228#comment-17161228 ] Andre Brait commented on MRESOURCES-254: But then I won't be able to use the

[jira] [Commented] (SUREFIRE-1822) XML report with empty name attribute by 3.0.0-M5 when failing in @BeforeAll/@BeforeClass

2020-07-20 Thread Marc Guillemot (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161227#comment-17161227 ] Marc Guillemot commented on SUREFIRE-1822: -- Thanks for the link. I have alrea

[GitHub] [maven-archetype] elharo commented on pull request #54: Explicitly declare dependencies

2020-07-20 Thread GitBox
elharo commented on pull request #54: URL: https://github.com/apache/maven-archetype/pull/54#issuecomment-661028920 PT failed on Windows Jdk 7 Jenkins node and passed on others. Rerunning. This is an automated message from t

[jira] [Updated] (MRESOURCES-263) Use non-shapshot maven-filtering

2020-07-20 Thread Dennis Lundberg (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated MRESOURCES-263: --- Fix Version/s: 3.2.0 > Use non-shapshot maven-filtering > ---

[GitHub] [maven-filtering] elharo commented on a change in pull request #13: replace deprecated code in favor of Java 7 core and apache commons libraries

2020-07-20 Thread GitBox
elharo commented on a change in pull request #13: URL: https://github.com/apache/maven-filtering/pull/13#discussion_r457363869 ## File path: src/test/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFilteringTest.java ## @@ -758,20 +752,20 @@ private void createTest

[GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement

2020-07-20 Thread GitBox
XenoAmess commented on a change in pull request #48: URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r457360924 ## File path: src/test/java/org/apache/maven/plugins/javadoc/JavadocJarTest.java ## @@ -154,7 +154,7 @@ public void testInvalidDestdir()

[GitHub] [maven-shared-utils] elharo merged pull request #58: remove call to deprecated method

2020-07-20 Thread GitBox
elharo merged pull request #58: URL: https://github.com/apache/maven-shared-utils/pull/58 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (MRESOURCES-254) Filtering of compound properties using properties added by other plugins fails without ${*} delimiter

2020-07-20 Thread Dennis Lundberg (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161213#comment-17161213 ] Dennis Lundberg commented on MRESOURCES-254: Okay I figured this out now.

[jira] [Resolved] (MSHARED-431) # (Hash-Sign) should trigger quoting in BourneShell.java

2020-07-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MSHARED-431. --- Fix Version/s: maven-shared-utils-3.3.0 Resolution: Fixed > # (Hash-S

[jira] [Closed] (MSHARED-431) # (Hash-Sign) should trigger quoting in BourneShell.java

2020-07-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MSHARED-431. - > # (Hash-Sign) should trigger quoting in BourneShell.java > ---

[jira] [Updated] (MSHARED-297) Commandline class shell injection vulnerabilities

2020-07-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MSHARED-297: -- Fix Version/s: maven-shared-utils-3.3.0 > Commandline class shell injection vu

[jira] [Resolved] (MSHARED-297) Commandline class shell injection vulnerabilities

2020-07-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MSHARED-297. --- Resolution: Fixed > Commandline class shell injection vulnerabilities >

[jira] [Comment Edited] (MRESOURCES-254) Filtering of compound properties using properties added by other plugins fails without ${*} delimiter

2020-07-20 Thread Dennis Lundberg (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161177#comment-17161177 ] Dennis Lundberg edited comment on MRESOURCES-254 at 7/20/20, 12:47 PM:

[jira] [Closed] (MSHARED-297) Commandline class shell injection vulnerabilities

2020-07-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MSHARED-297. - > Commandline class shell injection vulnerabilities > --

[GitHub] [maven-shared-utils] elharo opened a new pull request #59: [MSHARED-848] deprecate XmlStreamReader

2020-07-20 Thread GitBox
elharo opened a new pull request #59: URL: https://github.com/apache/maven-shared-utils/pull/59 @dennisl This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [maven-shared-utils] elharo opened a new pull request #58: remove call to deprecated method

2020-07-20 Thread GitBox
elharo opened a new pull request #58: URL: https://github.com/apache/maven-shared-utils/pull/58 @dennisl This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Created] (MDEP-715) Hamcrest used and unsued

2020-07-20 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created MDEP-715: -- Summary: Hamcrest used and unsued Key: MDEP-715 URL: https://issues.apache.org/jira/browse/MDEP-715 Project: Maven Dependency Plugin Issue Type:

[jira] [Updated] (MDEP-709) Adding maven-resolver-api to dependency plugin breaks tests

2020-07-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MDEP-709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MDEP-709: --- Issue Type: Dependency upgrade (was: Bug) > Adding maven-resolver-api to dependency pl

[jira] [Updated] (MDEP-709) Adding maven-resolver-api to dependency plugin breaks tests

2020-07-20 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MDEP-709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MDEP-709: --- Priority: Major (was: Blocker) > Adding maven-resolver-api to dependency plugin breaks

[jira] [Commented] (MRESOURCES-254) Filtering of compound properties using properties added by other plugins fails without ${*} delimiter

2020-07-20 Thread Dennis Lundberg (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161177#comment-17161177 ] Dennis Lundberg commented on MRESOURCES-254: Good example to test! But it

[jira] [Commented] (MRESOURCES-254) Filtering of compound properties using properties added by other plugins fails without ${*} delimiter

2020-07-20 Thread Andre Brait (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161171#comment-17161171 ] Andre Brait commented on MRESOURCES-254: I guess adding {code:xml} ${buildN

[jira] [Commented] (MRESOURCES-254) Filtering of compound properties using properties added by other plugins fails without ${*} delimiter

2020-07-20 Thread Andre Brait (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161168#comment-17161168 ] Andre Brait commented on MRESOURCES-254: Sorry, I didn't get that you were st

[jira] [Commented] (MRESOURCES-254) Filtering of compound properties using properties added by other plugins fails without ${*} delimiter

2020-07-20 Thread Andre Brait (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161166#comment-17161166 ] Andre Brait commented on MRESOURCES-254: In your test, have either prop1 or p

[GitHub] [maven-surefire] eolivelli commented on pull request #305: enable to flush regularly output of the forked process

2020-07-20 Thread GitBox
eolivelli commented on pull request #305: URL: https://github.com/apache/maven-surefire/pull/305#issuecomment-660956655 @Tibor17 I left a minor comment on your PR. It is better that you open a new PR, this way it is easier to track comments and discussions.

[GitHub] [maven-surefire] Tibor17 commented on pull request #305: enable to flush regularly output of the forked process

2020-07-20 Thread GitBox
Tibor17 commented on pull request #305: URL: https://github.com/apache/maven-surefire/pull/305#issuecomment-660949560 @rmannibucau @eolivelli Hye guys. Can you please make a code review for the [commit](https://github.com/apache/maven-surefire/commit/4b4eaf68baa64de6182ab49f8c1984e6

[jira] [Commented] (MRESOURCES-254) Filtering of compound properties using properties added by other plugins fails without ${*} delimiter

2020-07-20 Thread Dennis Lundberg (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161120#comment-17161120 ] Dennis Lundberg commented on MRESOURCES-254: Hi, I can confirm the resul

[GitHub] [maven-resolver] rmannibucau commented on a change in pull request #65: [MRESOLVER-123] Provide a global locking sync context by default

2020-07-20 Thread GitBox
rmannibucau commented on a change in pull request #65: URL: https://github.com/apache/maven-resolver/pull/65#discussion_r457240942 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultSyncContextFactory.java ## @@ -28,31 +30,59 @@ import org

[jira] [Commented] (MJAVADOC-656) Following redirects breaks valid links

2020-07-20 Thread Jira
[ https://issues.apache.org/jira/browse/MJAVADOC-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161097#comment-17161097 ] Robert Važan commented on MJAVADOC-656: --- The only machine-readable location inclu

[GitHub] [maven-surefire] Tibor17 commented on pull request #217: [SUREFIRE-1635] Set properties readonly where it doesn't make sense to change values

2020-07-20 Thread GitBox
Tibor17 commented on pull request #217: URL: https://github.com/apache/maven-surefire/pull/217#issuecomment-660930376 @britter Sorry, i was busy with another staff. I have checked the git history and i see the commit `a69f10f` for this issue. Are we missing any changes from this PR

[jira] [Assigned] (MRESOURCES-263) Use non-shapshot maven-filtering

2020-07-20 Thread Dennis Lundberg (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg reassigned MRESOURCES-263: -- Assignee: Dennis Lundberg > Use non-shapshot maven-filtering > ---

[jira] [Closed] (MRESOURCES-210) copy-resources erases file permissions

2020-07-20 Thread Dennis Lundberg (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed MRESOURCES-210. -- Fix Version/s: 3.2.0 Assignee: Olivier Lamy Resolution: Fixed > cop

[jira] [Updated] (MRESOURCES-236) Copying of files with permissions broken

2020-07-20 Thread Dennis Lundberg (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated MRESOURCES-236: --- Fix Version/s: 3.2.0 > Copying of files with permissions broken > ---

[jira] [Closed] (MRESOURCES-253) Convention over configuration of filtered resources

2020-07-20 Thread Dennis Lundberg (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed MRESOURCES-253. -- Resolution: Won't Fix This needs to be fixed in maven core. See linked issue. > Co

[jira] [Closed] (MRESOURCES-258) Only overwrite filtered resources when contents differ

2020-07-20 Thread Dennis Lundberg (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed MRESOURCES-258. -- Fix Version/s: 3.2.0 Assignee: Olivier Lamy Resolution: Fixed > Onl

[jira] [Closed] (MRESOURCES-261) Make Maven 3.1.0 the minimum version

2020-07-20 Thread Dennis Lundberg (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed MRESOURCES-261. -- Fix Version/s: 3.2.0 Assignee: Elliotte Rusty Harold Resolution: Fix

[jira] [Assigned] (MRESOURCES-171) ISO8859-1 properties files get changed into UTF-8 when filtered

2020-07-20 Thread Dennis Lundberg (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg reassigned MRESOURCES-171: -- Assignee: Dennis Lundberg > ISO8859-1 properties files get changed into UT

[jira] [Closed] (MRESOURCES-171) ISO8859-1 properties files get changed into UTF-8 when filtered

2020-07-20 Thread Dennis Lundberg (Jira)
[ https://issues.apache.org/jira/browse/MRESOURCES-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed MRESOURCES-171. -- Resolution: Fixed > ISO8859-1 properties files get changed into UTF-8 when filtered

  1   2   >