[jira] [Updated] (MNG-7005) Support Gradle style GAV form for dependencies

2020-10-23 Thread Chris Caspanello (Jira)
[ https://issues.apache.org/jira/browse/MNG-7005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Caspanello updated MNG-7005: -- Issue Type: Improvement (was: Bug) > Support Gradle style GAV form for dependencies > --

[jira] [Created] (MNG-7005) Support Gradle style GAV form for dependencies

2020-10-23 Thread Chris Caspanello (Jira)
Chris Caspanello created MNG-7005: - Summary: Support Gradle style GAV form for dependencies Key: MNG-7005 URL: https://issues.apache.org/jira/browse/MNG-7005 Project: Maven Issue Type: Bug

[jira] [Commented] (MNG-6928) CREATE: Call to Action design card

2020-10-23 Thread Amelia Eiras (Jira)
[ https://issues.apache.org/jira/browse/MNG-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219878#comment-17219878 ] Amelia Eiras commented on MNG-6928: --- Hola [~rfscholte] (y)   It looks great!!! May I r

[jira] [Commented] (MNG-7004) Refactor GitHub Actions environment variables since 'set-env' is deprecated

2020-10-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219762#comment-17219762 ] Hudson commented on MNG-7004: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #

[jira] [Updated] (MNG-7004) Refactor GitHub Actions environment variables since 'set-env' is deprecated

2020-10-23 Thread Martin Kanters (Jira)
[ https://issues.apache.org/jira/browse/MNG-7004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kanters updated MNG-7004: Fix Version/s: 3.7.0 > Refactor GitHub Actions environment variables since 'set-env' is deprecated >

[jira] [Assigned] (MNG-7004) Refactor GitHub Actions environment variables since 'set-env' is deprecated

2020-10-23 Thread Martin Kanters (Jira)
[ https://issues.apache.org/jira/browse/MNG-7004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kanters reassigned MNG-7004: --- Assignee: Martin Kanters > Refactor GitHub Actions environment variables since 'set-env' is de

[jira] [Resolved] (MNG-7004) Refactor GitHub Actions environment variables since 'set-env' is deprecated

2020-10-23 Thread Martin Kanters (Jira)
[ https://issues.apache.org/jira/browse/MNG-7004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kanters resolved MNG-7004. - Resolution: Implemented > Refactor GitHub Actions environment variables since 'set-env' is deprecat

[GitHub] [maven] MartinKanters merged pull request #389: [MNG-7004] Replacing set-env in the GitHub Actions workflow with the …

2020-10-23 Thread GitBox
MartinKanters merged pull request #389: URL: https://github.com/apache/maven/pull/389 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [maven] mthmulders commented on pull request #388: Refactor ProjectsCollector.collectProjects

2020-10-23 Thread GitBox
mthmulders commented on pull request #388: URL: https://github.com/apache/maven/pull/388#issuecomment-715389858 1. This interface was merged into master only five days ago, I don't think anyone has built a different implementation for it just yet... 1. If I understood correctly, the `Pro

[GitHub] [maven] MartinKanters opened a new pull request #389: [MNG-7004] Replacing set-env in the GitHub Actions workflow with the …

2020-10-23 Thread GitBox
MartinKanters opened a new pull request #389: URL: https://github.com/apache/maven/pull/389 …new way to set environment variables, since set-env is deprecated. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a

[GitHub] [maven-indexer] michael-o merged pull request #74: (doc) Fix spurious javadoc @param tag

2020-10-23 Thread GitBox
michael-o merged pull request #74: URL: https://github.com/apache/maven-indexer/pull/74 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-indexer] pzygielo commented on pull request #74: (doc) Fix spurious javadoc @param tag

2020-10-23 Thread GitBox
pzygielo commented on pull request #74: URL: https://github.com/apache/maven-indexer/pull/74#issuecomment-715368052 May I ask for review, please? This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Commented] (MNG-7002) Extend DefaultGraphBuilder unit tests to cover that child projects get included with the --pl switch

2020-10-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219700#comment-17219700 ] Hudson commented on MNG-7002: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #

[GitHub] [maven-indexer] pzygielo opened a new pull request #74: (doc) Fix spurious javadoc @param tag

2020-10-23 Thread GitBox
pzygielo opened a new pull request #74: URL: https://github.com/apache/maven-indexer/pull/74 Missed that one in #73. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Resolved] (MNG-7002) Extend DefaultGraphBuilder unit tests to cover that child projects get included with the --pl switch

2020-10-23 Thread Martin Kanters (Jira)
[ https://issues.apache.org/jira/browse/MNG-7002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kanters resolved MNG-7002. - Resolution: Implemented > Extend DefaultGraphBuilder unit tests to cover that child projects get >

[jira] [Updated] (MNG-7002) Extend DefaultGraphBuilder unit tests to cover that child projects get included with the --pl switch

2020-10-23 Thread Martin Kanters (Jira)
[ https://issues.apache.org/jira/browse/MNG-7002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kanters updated MNG-7002: Fix Version/s: 3.7.0 > Extend DefaultGraphBuilder unit tests to cover that child projects get > incl

[jira] [Assigned] (MNG-7002) Extend DefaultGraphBuilder unit tests to cover that child projects get included with the --pl switch

2020-10-23 Thread Martin Kanters (Jira)
[ https://issues.apache.org/jira/browse/MNG-7002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kanters reassigned MNG-7002: --- Assignee: Martin Kanters > Extend DefaultGraphBuilder unit tests to cover that child projects

[GitHub] [maven] michael-o commented on pull request #388: Refactor ProjectsCollector.collectProjects

2020-10-23 Thread GitBox
michael-o commented on pull request #388: URL: https://github.com/apache/maven/pull/388#issuecomment-715345021 There are two issues here: 1. You are changin a public interface. I don't know whether this is acceptable 2. As far as I know collect methods they are supposed to receive whe

[GitHub] [maven] MartinKanters merged pull request #387: [MNG-7002] Added a test scenario for including child modules when usi…

2020-10-23 Thread GitBox
MartinKanters merged pull request #387: URL: https://github.com/apache/maven/pull/387 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [maven] mthmulders commented on pull request #388: Refactor ProjectsCollector.collectProjects

2020-10-23 Thread GitBox
mthmulders commented on pull request #388: URL: https://github.com/apache/maven/pull/388#issuecomment-715329957 > Can you tell what the purpose is behind this change? I identified this opportunity for improvement when I was working on [MNG-6118](https://issues.apache.org/jira/browse/

[GitHub] [maven] michael-o commented on pull request #388: Refactor ProjectsCollector.collectProjects

2020-10-23 Thread GitBox
michael-o commented on pull request #388: URL: https://github.com/apache/maven/pull/388#issuecomment-715327843 Can you tell what the purpose is behind this change? This is an automated message from the Apache Git Service. To

[GitHub] [maven] mthmulders opened a new pull request #388: Refactor ProjectsCollector.collectProjects

2020-10-23 Thread GitBox
mthmulders opened a new pull request #388: URL: https://github.com/apache/maven/pull/388 This method now returns its result instead of modifying one of its arguments. Following this checklist to help us incorporate your contribution quickly and easily: - [X] Each commit in

[jira] [Comment Edited] (MDEP-699) Create a goal to add a new dependency to an existing pom

2020-10-23 Thread Martin Kanters (Jira)
[ https://issues.apache.org/jira/browse/MDEP-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219662#comment-17219662 ] Martin Kanters edited comment on MDEP-699 at 10/23/20, 12:59 PM:

[jira] [Commented] (MDEP-699) Create a goal to add a new dependency to an existing pom

2020-10-23 Thread Martin Kanters (Jira)
[ https://issues.apache.org/jira/browse/MDEP-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219662#comment-17219662 ] Martin Kanters commented on MDEP-699: - I think it would be useful to have this, mainly

[jira] [Commented] (MNG-7001) Reconsider seemingly useless check of artifacts' source repository introduced in Maven 3.0

2020-10-23 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219624#comment-17219624 ] Tamás Cservenák commented on MNG-7001: -- And just ftr, "repo groups" were a bloody mist

[jira] [Commented] (MNG-7001) Reconsider seemingly useless check of artifacts' source repository introduced in Maven 3.0

2020-10-23 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-7001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219586#comment-17219586 ] Robert Scholte commented on MNG-7001: - IIRC [~cstamas] would agree that repository mana

[jira] [Commented] (MNG-6928) CREATE: Call to Action design card

2020-10-23 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219567#comment-17219567 ] Robert Scholte commented on MNG-6928: - I've added a screenshot matching the branch htt

[jira] [Updated] (MNG-6928) CREATE: Call to Action design card

2020-10-23 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MNG-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte updated MNG-6928: Attachment: actioncards.PNG > CREATE: Call to Action design card > --

[GitHub] [maven] MartinKanters opened a new pull request #387: [MNG-7002] Added a test scenario for including child modules when usi…

2020-10-23 Thread GitBox
MartinKanters opened a new pull request #387: URL: https://github.com/apache/maven/pull/387 …ng the --pl switch. This was easy to pick up since MNG-6118 extended the testcase with a multi-level hierarchy project: https://github.com/apache/maven/pull/373/files#diff-72ccd31ee50f74b

[jira] [Created] (MNG-7004) Refactor GitHub Actions environment variables since 'set-env' is deprecated

2020-10-23 Thread Martin Kanters (Jira)
Martin Kanters created MNG-7004: --- Summary: Refactor GitHub Actions environment variables since 'set-env' is deprecated Key: MNG-7004 URL: https://issues.apache.org/jira/browse/MNG-7004 Project: Maven

[jira] [Commented] (MNG-7001) Reconsider seemingly useless check of artifacts' source repository introduced in Maven 3.0

2020-10-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219528#comment-17219528 ] Michael Osipov commented on MNG-7001: - > Interesting idea. Is it possible to find out t