hboutemy commented on pull request #392:
URL: https://github.com/apache/maven/pull/392#issuecomment-728382359
Central Repository is used not only by Maven
and "Maven Central" is a registered service name as stated in
https://issues.apache.org/jira/browse/MNG-5164
--
[
https://issues.apache.org/jira/browse/SUREFIRE-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233141#comment-17233141
]
Michael Boyles commented on SUREFIRE-1844:
--
I suppose it will happen automati
[
https://issues.apache.org/jira/browse/SUREFIRE-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233075#comment-17233075
]
Philippe Cloutier commented on SUREFIRE-1844:
-
Thank you for the quick rea
cstamas commented on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-728320815
@michael-o Once you resolve all remaining conversations and have no more
remark/change req, I'll squash the commits into one, until then am leaving them
to be able to ref the
[
https://issues.apache.org/jira/browse/MDEP-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233037#comment-17233037
]
Michael Osipov commented on MDEP-730:
-
Sample project please.
> unpack - parameter mar
rfscholte commented on pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-728278651
I had a look at
https://maven.apache.org/plugins/maven-ear-plugin/examples/skinny-wars.html to
understand the current implementation. It is a little bit different to what
rfscholte edited a comment on pull request #16:
URL: https://github.com/apache/maven-jlink-plugin/pull/16#issuecomment-728255698
PR looks much better already.
> What about JDK9+ and Toolchains?
Toolchains always wins
> Does JLinkMojo::getModulePathElements need an update?
[
https://issues.apache.org/jira/browse/MNG-5728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-5728:
Fix Version/s: (was: Issues to be reviewed for 4.x)
4.0.x-candidate
> Switch t
michael-o merged pull request #80:
URL: https://github.com/apache/maven-integration-testing/pull/80
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Jochen Stiepel created MDEP-730:
---
Summary: unpack - parameter markersDirectory allways gives an
exception, while setting it
Key: MDEP-730
URL: https://issues.apache.org/jira/browse/MDEP-730
Project: Mav
michael-o commented on pull request #80:
URL:
https://github.com/apache/maven-integration-testing/pull/80#issuecomment-728263873
As for MNG-5768, correct. That would be a prerequisite and nice to have for
4.0.0.
This is an
michael-o commented on pull request #80:
URL:
https://github.com/apache/maven-integration-testing/pull/80#issuecomment-728263617
No, I don't. Just don't want to leave impression to add something like this
via someone's back.
---
michael-o commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r524505861
##
File path:
maven-resolver-synccontext-named/src/main/java/org/eclipse/aether/internal/named/SyncContextFactoryAdapter.java
##
@@ -0,0 +1,300 @@
+
rfscholte commented on pull request #80:
URL:
https://github.com/apache/maven-integration-testing/pull/80#issuecomment-728262546
Do you expect me to verify every checksum?
It makes sense to add them, especially when fixing
https://issues.apache.org/jira/browse/MNG-5728
--
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r524505161
##
File path:
maven-resolver-synccontext-named/src/main/java/org/eclipse/aether/internal/named/SyncContextFactoryAdapter.java
##
@@ -0,0 +1,300 @@
+pa
nk-coding commented on a change in pull request #324:
URL: https://github.com/apache/maven-surefire/pull/324#discussion_r524498040
##
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
##
@@ -124,
rfscholte commented on pull request #16:
URL: https://github.com/apache/maven-jlink-plugin/pull/16#issuecomment-728255698
PR looks much better already.
> What about JDK9+ and Toolchains?
Toolchains always wins
> Does JLinkMojo::getModulePathElements need an update?
Not sure i
michael-o commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r524477115
##
File path:
maven-resolver-synccontext-named/src/main/java/org/eclipse/aether/internal/named/SyncContextFactoryAdapter.java
##
@@ -0,0 +1,300 @@
+
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r524471892
##
File path:
maven-resolver-synccontext-named/src/main/java/org/eclipse/aether/internal/named/SyncContextFactoryAdapter.java
##
@@ -0,0 +1,300 @@
+pa
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r524471145
##
File path:
maven-resolver-synccontext-named/src/main/java/org/eclipse/aether/internal/named/SyncContextFactoryAdapter.java
##
@@ -0,0 +1,300 @@
+pa
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r524470046
##
File path:
maven-resolver-synccontext-named/src/main/java/org/eclipse/aether/synccontext/NamedSyncContextFactory.java
##
@@ -0,0 +1,84 @@
+package
cstamas commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r524469609
##
File path:
maven-resolver-synccontext-named/src/main/java/org/eclipse/aether/internal/named/impl/AdaptedSemaphoreNamedLock.java
##
@@ -0,0 +1,115 @
michael-o commented on a change in pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#discussion_r524413810
##
File path:
maven-resolver-synccontext-named/src/main/java/org/eclipse/aether/internal/named/SyncContextFactoryAdapter.java
##
@@ -0,0 +1,300 @@
+
michael-o commented on pull request #392:
URL: https://github.com/apache/maven/pull/392#issuecomment-728166065
@hboutemy What is your opinion.
This is an automated message from the Apache Git Service.
To respond to the messag
michael-o edited a comment on pull request #392:
URL: https://github.com/apache/maven/pull/392#issuecomment-728166065
@hboutemy What is your opinion?
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/MNG-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7021:
Fix Version/s: (was: 3.7.0-candidate)
4.0.x-candidate
> Remove old MHELP backw
[
https://issues.apache.org/jira/browse/MNG-7022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7022:
Fix Version/s: (was: 3.7.0-candidate)
4.0.x-candidate
> Remove o.a.m.lifecycle
[
https://issues.apache.org/jira/browse/MNG-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7020:
Fix Version/s: (was: 3.7.0-candidate)
4.0.x-candidate
> Remove Maven 2 WagonEx
bmarwell opened a new pull request #17:
URL: https://github.com/apache/maven-jlink-plugin/pull/17
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJLINK) filed
Benjamin Marwell created MJLINK-56:
--
Summary: Convert unit tests to Junit5
Key: MJLINK-56
URL: https://issues.apache.org/jira/browse/MJLINK-56
Project: Maven JLink Plugin
Issue Type: Improve
[
https://issues.apache.org/jira/browse/MNG-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6214.
---
Resolution: Incomplete
No sample provided.
> Snapshot resolution disabled at
> MavenSession.ProjectBu
Tibor17 commented on a change in pull request #324:
URL: https://github.com/apache/maven-surefire/pull/324#discussion_r524263465
##
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
##
@@ -124,13
[
https://issues.apache.org/jira/browse/MSHADE-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17232742#comment-17232742
]
Andreas Rauchberger commented on MSHADE-251:
I'm using profiles a lot, for co
bmarwell commented on pull request #16:
URL: https://github.com/apache/maven-jlink-plugin/pull/16#issuecomment-727927048
@rfscholte please also see the "open questions" from the main comment.
This is an automated message from
34 matches
Mail list logo
