michael-o commented on pull request #408:
URL: https://github.com/apache/maven/pull/408#issuecomment-748651915
I asked for an IT for good reason. I ran the suite multiple times from a
fresh clone and see this failing:
```
java.lang.AssertionError:
Compile goal was expected to run
mabrarov opened a new pull request #31:
URL: https://github.com/apache/maven-ear-plugin/pull/31
[MEAR-294] - Removal of provided artifacts from Class-Path entry of
MANIFEST.mf if skinnyWars / skinnyModules options are turned on.
Marat Abrarov created MEAR-294:
--
Summary: JAR with provided scope should be removed from Class-Path
in case of skinnyWars
Key: MEAR-294
URL: https://issues.apache.org/jira/browse/MEAR-294
Project: Maven
mabrarov commented on a change in pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546406382
##
File path: src/it/skinny-wars-javaee5/ear-module/pom.xml
##
@@ -33,9 +33,26 @@ under the License.
commons-lang
Review comment:
michael-o commented on pull request #88:
URL:
https://github.com/apache/maven-integration-testing/pull/88#issuecomment-748634359
Going through now...
This is an automated message from the Apache Git Service.
To respond to
michael-o commented on pull request #408:
URL: https://github.com/apache/maven/pull/408#issuecomment-748634338
Going through now...
This is an automated message from the Apache Git Service.
To respond to the message, please
elharo commented on a change in pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546401678
##
File path: src/it/skinny-wars-javaee5/ear-module/pom.xml
##
@@ -33,9 +33,26 @@ under the License.
commons-lang
Review comment:
mabrarov commented on a change in pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546397158
##
File path: src/it/skinny-wars-javaee5/ear-module/pom.xml
##
@@ -33,9 +33,26 @@ under the License.
commons-lang
Review comment:
mabrarov commented on a change in pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546397158
##
File path: src/it/skinny-wars-javaee5/ear-module/pom.xml
##
@@ -33,9 +33,26 @@ under the License.
commons-lang
Review comment:
Tilman Hausherr created SUREFIRE-1868:
-
Summary: writing to System.outwriting to System.errwriting to
System.outwriting to System.errwriting
Key: SUREFIRE-1868
URL:
elharo commented on a change in pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546391171
##
File path: src/it/skinny-wars-javaee5/ear-module/pom.xml
##
@@ -33,9 +33,26 @@ under the License.
commons-lang
Review comment:
mabrarov commented on a change in pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546387830
##
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##
@@ -816,12 +816,15 @@ private void changeManifestClasspath( EarModule
mabrarov commented on a change in pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546387718
##
File path: src/it/skinny-wars-javaee5/ear-module/pom.xml
##
@@ -33,9 +33,26 @@ under the License.
commons-lang
2.5
+
+
mabrarov commented on a change in pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546385292
##
File path: src/it/skinny-wars-javaee5/ear-module/pom.xml
##
@@ -33,9 +33,26 @@ under the License.
commons-lang
Review comment:
[
https://issues.apache.org/jira/browse/MEAR-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17252433#comment-17252433
]
Hudson commented on MEAR-293:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-ear-plugin » master #51
elharo commented on a change in pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546379504
##
File path: src/it/skinny-wars-javaee5/ear-module/pom.xml
##
@@ -33,9 +33,26 @@ under the License.
commons-lang
2.5
+
+
[
https://issues.apache.org/jira/browse/MEAR-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold resolved MEAR-293.
Resolution: Fixed
> skinnyModules option doesn't work if skinnyWars is false
>
[
https://issues.apache.org/jira/browse/MEAR-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold closed MEAR-293.
--
> skinnyModules option doesn't work if skinnyWars is false
>
elharo merged pull request #30:
URL: https://github.com/apache/maven-ear-plugin/pull/30
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mabrarov commented on pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29#issuecomment-748597912
@hboutemy
This is an automated message from the Apache Git Service.
To respond to the message, please
mabrarov commented on pull request #30:
URL: https://github.com/apache/maven-ear-plugin/pull/30#issuecomment-748597658
@elharo
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/MEAR-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marat Abrarov updated MEAR-293:
---
Description:
If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
off
[
https://issues.apache.org/jira/browse/MEAR-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marat Abrarov updated MEAR-293:
---
Description:
If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
off
[
https://issues.apache.org/jira/browse/MEAR-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marat Abrarov updated MEAR-293:
---
Description:
If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
off
mabrarov commented on a change in pull request #26:
URL: https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546360290
##
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##
@@ -480,9 +482,10 @@ private void copyModules( final JavaEEVersion
mabrarov opened a new pull request #30:
URL: https://github.com/apache/maven-ear-plugin/pull/30
[MEAR-293] - skinnyModules option working even if skinnyWars option is
turned off (or has default value).
This is an automated
mabrarov commented on a change in pull request #26:
URL: https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546359981
##
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##
@@ -480,9 +482,10 @@ private void copyModules( final JavaEEVersion
mabrarov commented on a change in pull request #26:
URL: https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546359981
##
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##
@@ -480,9 +482,10 @@ private void copyModules( final JavaEEVersion
[
https://issues.apache.org/jira/browse/MEAR-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marat Abrarov updated MEAR-293:
---
Description:
If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
off
Marat Abrarov created MEAR-293:
--
Summary: skinnyModules option doesn't work if skinnyWars is false
Key: MEAR-293
URL: https://issues.apache.org/jira/browse/MEAR-293
Project: Maven EAR Plugin
[
https://issues.apache.org/jira/browse/MEAR-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marat Abrarov updated MEAR-292:
---
Description: It looks like there is a bug in implementation of
{{skipClassPathModification}} option
mabrarov commented on pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29#issuecomment-748590385
Note that Jenkins build can fail due to [the
bug](https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822)
introduced by pull request #26.
mabrarov commented on pull request #28:
URL: https://github.com/apache/maven-ear-plugin/pull/28#issuecomment-748590280
Declining in favor of pull request #29 with fixed source branch name.
This is an automated message from
mabrarov closed pull request #28:
URL: https://github.com/apache/maven-ear-plugin/pull/28
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mabrarov opened a new pull request #29:
URL: https://github.com/apache/maven-ear-plugin/pull/29
[MEAR-292] - Don't add MANFIEST.mf Class-Path entry for EAR module if
skipClassPathModification is true and original MANFIEST.mf of EAR module
artifact doesn't contain Class-Path entry.
Marat Abrarov created MEAR-292:
--
Summary: skipClassPathModification option should prevent adding
Class-Path entry into MANIFEST.mf
Key: MEAR-292
URL: https://issues.apache.org/jira/browse/MEAR-292
mabrarov commented on a change in pull request #26:
URL: https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822
##
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##
@@ -480,9 +482,10 @@ private void copyModules( final JavaEEVersion
mabrarov edited a comment on pull request #26:
URL: https://github.com/apache/maven-ear-plugin/pull/26#issuecomment-748588430
@elharo and @hboutemy,
It feels like this PR has introduced a bug. Please checkout merge commit of
this PR and execute integration tests.
mabrarov edited a comment on pull request #26:
URL: https://github.com/apache/maven-ear-plugin/pull/26#issuecomment-748588430
@elharo and @hboutemy,
It feels like this PR has introduced a bug. Please, execute integration
tests and ensure that merge commit of this PR passes all
mabrarov commented on pull request #26:
URL: https://github.com/apache/maven-ear-plugin/pull/26#issuecomment-748588430
@elharo,
It feels like this PR has introduced a bug. Please, execute integration
tests and ensure that merge commit of this PR passes all tests.
[
https://issues.apache.org/jira/browse/MEAR-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17252379#comment-17252379
]
Hudson commented on MEAR-216:
-
Build unstable in Jenkins: Maven » Maven TLP » maven-ear-plugin » master #50
hboutemy commented on pull request #28:
URL: https://github.com/apache/maven-ear-plugin/pull/28#issuecomment-748584851
MEAR-182 https://issues.apache.org/jira/browse/MEAR-182 is an old issue
closed for release 2.10
please create a new issue (we'll link it to MEAR-182), and update the
[
https://issues.apache.org/jira/browse/MEAR-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MEAR-221:
---
Fix Version/s: waiting-for-feedback
> SNAPSHOT included with timestamp in skinnyWars but not removed
[
https://issues.apache.org/jira/browse/MEAR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MEAR-289:
---
Fix Version/s: waiting-for-feedback
> skinnyWars issue with finalName for Jar module
>
[
https://issues.apache.org/jira/browse/MEAR-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy closed MEAR-216.
--
Resolution: Fixed
PR #22 merged
thank you
> Unable to include dependencies of type test-jar
>
hboutemy commented on pull request #22:
URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-748583938
you're right, merged
thank you
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/MEAR-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MEAR-216:
---
Fix Version/s: (was: waiting-for-feedback)
> Unable to include dependencies of type test-jar
>
hboutemy merged pull request #22:
URL: https://github.com/apache/maven-ear-plugin/pull/22
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/MARCHETYPES-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy closed MARCHETYPES-68.
Resolution: Fixed
> make build Reproducible
> ---
>
>
101 - 149 of 149 matches
Mail list logo
