[jira] [Updated] (DOXIA-542) Markdown module converts all apostrophes to quotation marks

2020-12-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIA-542: - Labels: (was: close-pending) > Markdown module converts all apostrophes to quotation marks >

[jira] [Comment Edited] (MNG-6979) MavenSession.getCurrentProject may return an incorrect project in a multimodule build

2020-12-25 Thread Falko Modler (Jira)
[ https://issues.apache.org/jira/browse/MNG-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254924#comment-17254924 ] Falko Modler edited comment on MNG-6979 at 12/26/20, 12:11 AM: --- [~michael-o]

[jira] [Commented] (MASSEMBLY-947) fileSet lineEnding crlf does not convert old mac cr line endings

2020-12-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254928#comment-17254928 ] Michael Osipov commented on MASSEMBLY-947: -- Agreed. > fileSet lineEnding crlf does not

[jira] [Commented] (MASSEMBLY-947) fileSet lineEnding crlf does not convert old mac cr line endings

2020-12-25 Thread Peter lynch (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254927#comment-17254927 ] Peter lynch commented on MASSEMBLY-947: --- The issue was noticed when stray cr line endings caused

[jira] [Commented] (MNG-6979) MavenSession.getCurrentProject may return an incorrect project in a multimodule build

2020-12-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254926#comment-17254926 ] Michael Osipov commented on MNG-6979: - Thanks, I will try to reproduce and let you know! >

[jira] [Commented] (MNG-6979) MavenSession.getCurrentProject may return an incorrect project in a multimodule build

2020-12-25 Thread George Gastaldi (Jira)
[ https://issues.apache.org/jira/browse/MNG-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254925#comment-17254925 ] George Gastaldi commented on MNG-6979: -- Thank you so much [~famod]! > MavenSession.getCurrentProject

[jira] [Commented] (MNG-6979) MavenSession.getCurrentProject may return an incorrect project in a multimodule build

2020-12-25 Thread Falko Modler (Jira)
[ https://issues.apache.org/jira/browse/MNG-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254924#comment-17254924 ] Falko Modler commented on MNG-6979: --- [~michael-o] see [^MNG-6979.zip]. - {{mvn clean install -f

[jira] [Updated] (MNG-6979) MavenSession.getCurrentProject may return an incorrect project in a multimodule build

2020-12-25 Thread Falko Modler (Jira)
[ https://issues.apache.org/jira/browse/MNG-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Falko Modler updated MNG-6979: -- Attachment: MNG-6979.zip > MavenSession.getCurrentProject may return an incorrect project in a >

[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254918#comment-17254918 ] Michael Osipov commented on MRESOLVER-153: -- bq. Yup, did not meant to return (removed) FS

[jira] [Issue Comment Deleted] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-153: - Comment: was deleted (was: {quote}Yup, did not meant to return (removed) FS locking

[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254917#comment-17254917 ] Michael Osipov commented on MRESOLVER-153: -- {quote}Yup, did not meant to return (removed) FS

[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-25 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254916#comment-17254916 ] Tamás Cservenák commented on MRESOLVER-153: --- Yup, did not meant to return (removed) FS

[GitHub] [maven-deploy-plugin] michael-o commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2020-12-25 Thread GitBox
michael-o commented on pull request #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751289417 > > > But based on the Maven version we know the default generated checksum right? Theoretically, yes. You could add this to the configuration somehow.

[GitHub] [maven-deploy-plugin] rfscholte commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2020-12-25 Thread GitBox
rfscholte commented on pull request #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751289327 But based on the Maven version we know the default generated checksum right? This is an automated

[GitHub] [maven-deploy-plugin] michael-o commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2020-12-25 Thread GitBox
michael-o commented on pull request #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751289154 See my comment:

[GitHub] [maven-deploy-plugin] michael-o edited a comment on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2020-12-25 Thread GitBox
michael-o edited a comment on pull request #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751288717 The problem with this is that it is not portable. It does not know which checksums are generated. It is assumed, but nothing else. This especially depends on

[GitHub] [maven-deploy-plugin] michael-o commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2020-12-25 Thread GitBox
michael-o commented on pull request #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751288717 The problem with this is that it is not portable. It does not know which checksums are generated. It is assumed, but nothing else.

[GitHub] [maven-deploy-plugin] rfscholte commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2020-12-25 Thread GitBox
rfscholte commented on pull request #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751288561 I was a bit confused, but it is not a complete revert, just partial. However, I think it is valid to keep this IT. It in an _integration test_ that ensures the

[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254913#comment-17254913 ] Michael Osipov commented on MRESOLVER-153: -- I do not fully agree that the tracking file

[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-25 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254912#comment-17254912 ] Tamás Cservenák commented on MRESOLVER-153: --- [~michael-o]I agree, synchronization should be

[jira] [Comment Edited] (MNG-6757) Cant create a proper BOM when using ${revision}

2020-12-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254872#comment-17254872 ] Michael Osipov edited comment on MNG-6757 at 12/25/20, 4:31 PM:

[jira] [Commented] (MNG-6757) Cant create a proper BOM when using ${revision}

2020-12-25 Thread Kalle Widell (Jira)
[ https://issues.apache.org/jira/browse/MNG-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254872#comment-17254872 ] Kalle Widell commented on MNG-6757: --- [~michael-o] Ok. ill see to that such is provided.   > Cant create

[jira] [Commented] (MNG-6757) Cant create a proper BOM when using ${revision}

2020-12-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254864#comment-17254864 ] Michael Osipov commented on MNG-6757: - No issue, take your time. Providing a sample project would have

[jira] [Commented] (MNG-6757) Cant create a proper BOM when using ${revision}

2020-12-25 Thread Kalle Widell (Jira)
[ https://issues.apache.org/jira/browse/MNG-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254863#comment-17254863 ] Kalle Widell commented on MNG-6757: --- [~michael-o] Im on vacation until jan 4:th. Would it be okey to test

[jira] [Commented] (MNG-7052) Do not allow symbols as first character of identifiers in the POM

2020-12-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254844#comment-17254844 ] Michael Osipov commented on MNG-7052: - I consider that understscore (\{{_}}) should also be allowed as

[GitHub] [maven-deploy-plugin] michael-o commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2020-12-25 Thread GitBox
michael-o commented on pull request #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751253385 Your understanding is that the commit title should read: "Revert IT of MDEPLOY-231"? This is an

[jira] [Commented] (MNG-7052) Do not allow symbols as first character of identifiers in the POM

2020-12-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17254842#comment-17254842 ] Michael Osipov commented on MNG-7052: - I would also add colon (\{{:}}) to the list for URN-style id

[jira] [Issue Comment Deleted] (MNG-7052) Do not allow symbols as first character of identifiers in the POM

2020-12-25 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7052: Comment: was deleted (was: I think this should also apply to elements in the settings, but should

[GitHub] [maven-deploy-plugin] michael-o commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2020-12-25 Thread GitBox
michael-o commented on pull request #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751247730 I am confused by your statement. I do not restore the IT, I am removing it. Please explain how you understand the issue is still valid.

[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #32: remove deprecated methods by not stubbing value objects

2020-12-25 Thread GitBox
mabrarov commented on a change in pull request #32: URL: https://github.com/apache/maven-ear-plugin/pull/32#discussion_r548865908 ## File path: src/test/java/org/apache/maven/plugins/ear/util/ArtifactRepositoryTest.java ## @@ -34,14 +36,15 @@ extends AbstractEarTestBase

[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #32: remove deprecated methods by not stubbing value objects

2020-12-25 Thread GitBox
mabrarov commented on a change in pull request #32: URL: https://github.com/apache/maven-ear-plugin/pull/32#discussion_r548865908 ## File path: src/test/java/org/apache/maven/plugins/ear/util/ArtifactRepositoryTest.java ## @@ -34,14 +36,15 @@ extends AbstractEarTestBase

[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #32: remove deprecated methods by not stubbing value objects

2020-12-25 Thread GitBox
mabrarov commented on a change in pull request #32: URL: https://github.com/apache/maven-ear-plugin/pull/32#discussion_r548865908 ## File path: src/test/java/org/apache/maven/plugins/ear/util/ArtifactRepositoryTest.java ## @@ -34,14 +36,15 @@ extends AbstractEarTestBase

[GitHub] [maven-deploy-plugin] rfscholte commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2020-12-25 Thread GitBox
rfscholte commented on pull request #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751231372 I think the description is wrong, because MDEPLOY-231 is still valid to me. It looks like you're only restoring an IT, which is not the same.