[GitHub] [maven-scm] arturobernalg commented on a change in pull request #124: Simplify conditions with the same result and avoid extra validations.

2021-09-04 Thread GitBox
arturobernalg commented on a change in pull request #124: URL: https://github.com/apache/maven-scm/pull/124#discussion_r702370872 ## File path: maven-scm-providers/maven-scm-provider-integrity/src/main/java/org/apache/maven/scm/provider/integrity/Member.java ## @@ -247,10 +247

[GitHub] [maven-resolver] arturobernalg commented on a change in pull request #119: Simplify conditions with the same result and avoid extra validations.

2021-09-04 Thread GitBox
arturobernalg commented on a change in pull request #119: URL: https://github.com/apache/maven-resolver/pull/119#discussion_r702376911 ## File path: maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactResolutionException.java ## @@ -43,7 +43,7 @@ public

[GitHub] [maven-resolver] arturobernalg commented on a change in pull request #119: Simplify conditions with the same result and avoid extra validations.

2021-09-04 Thread GitBox
arturobernalg commented on a change in pull request #119: URL: https://github.com/apache/maven-resolver/pull/119#discussion_r702374636 ## File path: maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/manager/ClassicDependencyManager.java ## @@ -177,10 +177,7 @@ pu

[GitHub] [maven-resolver] arturobernalg commented on a change in pull request #119: Simplify conditions with the same result and avoid extra validations.

2021-09-04 Thread GitBox
arturobernalg commented on a change in pull request #119: URL: https://github.com/apache/maven-resolver/pull/119#discussion_r702374636 ## File path: maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/manager/ClassicDependencyManager.java ## @@ -177,10 +177,7 @@ pu

[GitHub] [maven-resolver] arturobernalg commented on a change in pull request #119: Simplify conditions with the same result and avoid extra validations.

2021-09-04 Thread GitBox
arturobernalg commented on a change in pull request #119: URL: https://github.com/apache/maven-resolver/pull/119#discussion_r702374437 ## File path: maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/ChecksumCalculator.java ## @@ -153,12 +153,8 @@

[GitHub] [maven-scm] arturobernalg commented on pull request #123: Unnecessary local variables. Inline variable.

2021-09-04 Thread GitBox
arturobernalg commented on pull request #123: URL: https://github.com/apache/maven-scm/pull/123#issuecomment-913094072 Hi @michael-o Solved. TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-scm] arturobernalg commented on pull request #125: Collapses Identical catch sections in a single try statement.

2021-09-04 Thread GitBox
arturobernalg commented on pull request #125: URL: https://github.com/apache/maven-scm/pull/125#issuecomment-913090929 HI @michael-o 'catch' sections are identical to 'FileNotFoundException'. Maybe would be better a custom message if any IO error comes? TY -- This is an automated

[jira] [Updated] (MRESOLVER-188) Improve documentation on using the named locks with redis/hazelcast

2021-09-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-188: - Fix Version/s: 1.7.2 > Improve documentation on using the named locks with redis/hazel

[GitHub] [maven-resolver] michael-o opened a new pull request #122: Document all named locks and name mappers

2021-09-04 Thread GitBox
michael-o opened a new pull request #122: URL: https://github.com/apache/maven-resolver/pull/122 @jebeaudet have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (MENFORCER-399) requireVariable = requireProperty or requireEnvironmentVariable

2021-09-04 Thread Jira
Hüseyin Kartal created MENFORCER-399: Summary: requireVariable = requireProperty or requireEnvironmentVariable Key: MENFORCER-399 URL: https://issues.apache.org/jira/browse/MENFORCER-399 Project:

[GitHub] [maven-scm] michael-o commented on a change in pull request #125: Collapses Identical catch sections in a single try statement.

2021-09-04 Thread GitBox
michael-o commented on a change in pull request #125: URL: https://github.com/apache/maven-scm/pull/125#discussion_r702322083 ## File path: maven-scm-providers/maven-scm-provider-clearcase/src/main/java/org/apache/maven/scm/provider/clearcase/util/ClearCaseUtil.java ## @@ -82,

[GitHub] [maven-scm] michael-o commented on a change in pull request #124: Simplify conditions with the same result and avoid extra validations.

2021-09-04 Thread GitBox
michael-o commented on a change in pull request #124: URL: https://github.com/apache/maven-scm/pull/124#discussion_r702321513 ## File path: maven-scm-providers/maven-scm-provider-integrity/src/main/java/org/apache/maven/scm/provider/integrity/Sandbox.java ## @@ -99,7 +99,7 @@

[GitHub] [maven-scm] michael-o commented on a change in pull request #123: Unnecessary local variables. Inline variable.

2021-09-04 Thread GitBox
michael-o commented on a change in pull request #123: URL: https://github.com/apache/maven-scm/pull/123#discussion_r702321233 ## File path: maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/HgScmProvider.java ## @@ -150,7 +148,7 @@ else i

[GitHub] [maven-scm] michael-o commented on a change in pull request #122: Replace assert by simpler but equivalent calls.

2021-09-04 Thread GitBox
michael-o commented on a change in pull request #122: URL: https://github.com/apache/maven-scm/pull/122#discussion_r700498192 ## File path: maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvs-commons/src/test/java/org/apache/maven/scm/provider/cvslib/command/changelog/C

[jira] [Closed] (MRESOLVER-199) Java 8 improvements

2021-09-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-199. Resolution: Fixed Fixed with [ee6aa7e11f24e802a33d8692ee8db5e9e8e9c842|https://gitbox.a

[jira] [Closed] (MRESOLVER-201) Make variables final whenever possible

2021-09-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-201. Resolution: Fixed Fixed with [be8ecb8ac9ad0953822b215f157baed113fc7767|https://gitbox.a

[jira] [Closed] (MRESOLVER-198) Replace assert by simpler but equivalent calls

2021-09-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-198. Resolution: Fixed Fixed with [0bcf62366b38a8da617608369a13c20d7fba210b|https://gitbox.a

[GitHub] [maven-resolver] asfgit closed pull request #118: java8 improvements:

2021-09-04 Thread GitBox
asfgit closed pull request #118: URL: https://github.com/apache/maven-resolver/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[GitHub] [maven-resolver] asfgit closed pull request #120: Make final variable when is possible.

2021-09-04 Thread GitBox
asfgit closed pull request #120: URL: https://github.com/apache/maven-resolver/pull/120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[GitHub] [maven-resolver] asfgit closed pull request #117: Replace assert by simpler but equivalent calls.

2021-09-04 Thread GitBox
asfgit closed pull request #117: URL: https://github.com/apache/maven-resolver/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[jira] [Updated] (MRESOLVER-201) Make variables final whenever possible

2021-09-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-201: - Summary: Make variables final whenever possible (was: Make final variable whenever po

[GitHub] [maven-resolver] michael-o commented on a change in pull request #119: Simplify conditions with the same result and avoid extra validations.

2021-09-04 Thread GitBox
michael-o commented on a change in pull request #119: URL: https://github.com/apache/maven-resolver/pull/119#discussion_r702318011 ## File path: maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/ChecksumCalculator.java ## @@ -153,12 +153,8 @@ publ

[jira] [Closed] (MDEP-763) Minor improvements

2021-09-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MDEP-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MDEP-763. --- Resolution: Fixed Fixed with [7d679c9f4ebc2d191997752d7e30b0e1df7957da|https://gitbox.apache.org/repos

[GitHub] [maven-dependency-plugin] asfgit closed pull request #160: MDEP-763 - Minor Improvements:

2021-09-04 Thread GitBox
asfgit closed pull request #160: URL: https://github.com/apache/maven-dependency-plugin/pull/160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: i

[jira] [Updated] (MDEP-763) Minor improvements

2021-09-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MDEP-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MDEP-763: Fix Version/s: next-release > Minor improvements > -- > > Key: MDEP-7

[jira] [Assigned] (MDEP-763) Minor improvements

2021-09-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MDEP-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MDEP-763: --- Assignee: Michael Osipov > Minor improvements > -- > > Key: MD

[GitHub] [maven-resolver] michael-o opened a new pull request #121: [MRESOLVER-196] Document named locks configuration options

2021-09-04 Thread GitBox
michael-o opened a new pull request #121: URL: https://github.com/apache/maven-resolver/pull/121 @jebeaudet have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (MRESOLVER-196) Document named locks configuration options

2021-09-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-196: - Summary: Document named locks configuration options (was: Add page with all support

[jira] [Updated] (MDEP-763) Minor improvements

2021-09-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MDEP-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MDEP-763: Summary: Minor improvements (was: Minor improvements:) > Minor improvements > -- > >

[jira] [Updated] (SCM-953) Deprecate non-OSS provider

2021-09-04 Thread Jira
[ https://issues.apache.org/jira/browse/SCM-953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clemens Quoß updated SCM-953: - Component/s: maven-scm-provider-vss maven-scm-provider-tfs maven-scm-provid

[jira] [Updated] (SCM-953) Deprecate non-OSS provider

2021-09-04 Thread Jira
[ https://issues.apache.org/jira/browse/SCM-953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clemens Quoß updated SCM-953: - Description: As part of the Maven SCM Cleanup process (see [Maven Ecosystem Cleanup - Apache Maven - Apache

[jira] [Updated] (SCM-953) Deprecate non-OSS provider

2021-09-04 Thread Jira
[ https://issues.apache.org/jira/browse/SCM-953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clemens Quoß updated SCM-953: - Description: As part of the Maven SCM Cleanup process (see [Maven Ecosystem Cleanup - Apache Maven - Apache

[jira] [Updated] (SCM-953) Deprecate non-OSS provider

2021-09-04 Thread Jira
[ https://issues.apache.org/jira/browse/SCM-953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clemens Quoß updated SCM-953: - Description: As part of the Maven SCM Cleanup process (see [Maven Ecosystem Cleanup - Apache Maven - Apache

[jira] [Updated] (SCM-953) Deprecate non-OSS provider

2021-09-04 Thread Jira
[ https://issues.apache.org/jira/browse/SCM-953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clemens Quoß updated SCM-953: - Summary: Deprecate non-OSS provider (was: Deprecate provider Synergy) > Deprecate non-OSS provider > --

[jira] [Updated] (SCM-953) Deprecate provider Synergy

2021-09-04 Thread Jira
[ https://issues.apache.org/jira/browse/SCM-953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clemens Quoß updated SCM-953: - Issue Type: Task (was: Improvement) > Deprecate provider Synergy > -- > >

[jira] [Updated] (SCM-953) Deprecate provider Synergy

2021-09-04 Thread Jira
[ https://issues.apache.org/jira/browse/SCM-953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clemens Quoß updated SCM-953: - Priority: Minor (was: Major) > Deprecate provider Synergy > -- > >

[jira] [Issue Comment Deleted] (MRESOLVER-196) Add page with all supported named locks configuration options

2021-09-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-196: - Comment: was deleted (was: Redisson and Hazelcast shall have their own pages.) > Add

[GitHub] [maven-resolver] asfgit closed pull request #116: Describe compatibility between Maven 3 and Maven 4 with resolver

2021-09-04 Thread GitBox
asfgit closed pull request #116: URL: https://github.com/apache/maven-resolver/pull/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[jira] [Commented] (MNG-7220) [REGRESSION] test-classpath incorrectly resolved

2021-09-04 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/MNG-7220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409991#comment-17409991 ] Stefan Seifert commented on MNG-7220: - the ticket [WTOOL-78|https://wcm-io.atlassian.ne

[jira] [Commented] (MNG-7049) Version range resolution downloads all poms, not just the highest version

2021-09-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409981#comment-17409981 ] Michael Osipov commented on MNG-7049: - Yes, that is the one. Thank you. An IT in Maven

[GitHub] [maven-dependency-plugin] arturobernalg commented on a change in pull request #160: MDEP-763 - Minor Improvements:

2021-09-04 Thread GitBox
arturobernalg commented on a change in pull request #160: URL: https://github.com/apache/maven-dependency-plugin/pull/160#discussion_r702288489 ## File path: src/main/java/org/apache/maven/plugins/dependency/fromDependencies/BuildClasspathMojo.java ## @@ -347,7 +347,7 @@ priv

[GitHub] [maven-dependency-plugin] arturobernalg commented on a change in pull request #160: MDEP-763 - Minor Improvements:

2021-09-04 Thread GitBox
arturobernalg commented on a change in pull request #160: URL: https://github.com/apache/maven-dependency-plugin/pull/160#discussion_r702288484 ## File path: src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java ## @@ -325,7 +325,7 @@ protected void un

[GitHub] [maven-dependency-plugin] michael-o commented on a change in pull request #160: MDEP-763 - Minor Improvements:

2021-09-04 Thread GitBox
michael-o commented on a change in pull request #160: URL: https://github.com/apache/maven-dependency-plugin/pull/160#discussion_r702280604 ## File path: src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java ## @@ -325,7 +325,7 @@ protected void unpack

[jira] [Commented] (SUREFIRE-1944) Fix Usage page for maven-surefire-plugin

2021-09-04 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409950#comment-17409950 ] Karl Heinz Marbaise commented on SUREFIRE-1944: --- First my posted answer

[jira] [Commented] (MCOMPILER-398) Simplify the implementation of the inclusion/exclusion logic

2021-09-04 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409917#comment-17409917 ] Hudson commented on MCOMPILER-398: -- Build succeeded in Jenkins: Maven » Maven TLP » m

[jira] [Closed] (MCOMPILER-398) Simplify the implementation of the inclusion/exclusion logic

2021-09-04 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MCOMPILER-398. Fix Version/s: 3.9.0 Assignee: Robert Scholte Resolution: Fixed Fixed in

[GitHub] [maven-compiler-plugin] rfscholte commented on pull request #24: [MCOMPILER-398] - Simplify includes/excludes scanning code

2021-09-04 Thread GitBox
rfscholte commented on pull request #24: URL: https://github.com/apache/maven-compiler-plugin/pull/24#issuecomment-912938927 Merged with https://github.com/apache/maven-compiler-plugin/commit/e64fd3b3ef93fc8831403cb9ca0147033bae12d6 -- This is an automated message from the Apache Git Se

[GitHub] [maven-compiler-plugin] rfscholte closed pull request #24: [MCOMPILER-398] - Simplify includes/excludes scanning code

2021-09-04 Thread GitBox
rfscholte closed pull request #24: URL: https://github.com/apache/maven-compiler-plugin/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: is

[jira] [Updated] (MWAR-438) Make Maven 3.1.0 the minimum version

2021-09-04 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MWAR-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MWAR-438: --- Fix Version/s: 3.3.1 > Make Maven 3.1.0 the minimum version > > >

[jira] [Updated] (MWAR-439) WAR Plugin 3.3.1 hits NPE when exploding if maven session start time is null

2021-09-04 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MWAR-439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MWAR-439: --- Fix Version/s: 3.3.2 > WAR Plugin 3.3.1 hits NPE when exploding if maven session start time is null > -

[jira] [Closed] (MWAR-442) WAR overlay not including the dependent WAR contents

2021-09-04 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MWAR-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MWAR-442. -- Resolution: Not A Bug > WAR overlay not including the dependent WAR contents > --

[jira] [Commented] (MWAR-443) Maven WAR plugin is deleting files generated by Maven Dependency plugin after upgrading to 3.3.1

2021-09-04 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MWAR-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409892#comment-17409892 ] Herve Boutemy commented on MWAR-443: did you check what timestamp is set with dependenc