arturobernalg commented on pull request #573:
URL: https://github.com/apache/maven/pull/573#issuecomment-939230468
> Did you search all java files in project? Also tests like
>
>
https://github.com/apache/maven/blob/d75bea415457b2eba7815bb9c3e9cd4e14b47fce/maven-model-builder/src/tes
[
https://issues.apache.org/jira/browse/MNG-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated MNG-7293:
---
Description:
see
[https://github.com/apache/maven/blob/d75bea415457b2eba7815bb9c3e9cd4e14b47fce/maven-wrapper/src/mai
lujie created MNG-7293:
--
Summary: Resource Leak due to Files.walk
Key: MNG-7293
URL: https://issues.apache.org/jira/browse/MNG-7293
Project: Maven
Issue Type: Improvement
Reporter: lujie
famod commented on pull request #570:
URL: https://github.com/apache/maven/pull/570#issuecomment-939153676
Btw, I might have an idea on how to solve MNG-6843 with a different
approach, isolated to `MojoExecutor`.
It won't be pretty (_if_ it works at all), but it should be less invasive
famod edited a comment on pull request #570:
URL: https://github.com/apache/maven/pull/570#issuecomment-939143274
Well, it was the very goal of
https://github.com/apache/maven/commit/76d5f0d942f52650d3bdf775b6af42d23d69066b
to make sure that one thread cannot modify (in a non-atomic way) t
[
https://issues.apache.org/jira/browse/SUREFIRE-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chanseok Oh updated SUREFIRE-1951:
--
Description:
Getting the following error when upgrading from 3.0.0-M4 to 3.0.0-M5.
[ERROR]
[
https://issues.apache.org/jira/browse/SUREFIRE-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chanseok Oh updated SUREFIRE-1951:
--
Description:
Getting the following error when upgrading from 3.0.0-M4 to 3.0.0-M5.
[ERROR]
[
https://issues.apache.org/jira/browse/SUREFIRE-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chanseok Oh updated SUREFIRE-1951:
--
Description:
Getting the following error when upgrading from 3.0.0-M4 to 3.0.0-M5.
[ERROR]
[
https://issues.apache.org/jira/browse/SUREFIRE-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chanseok Oh updated SUREFIRE-1951:
--
Description:
Getting the following error when upgrading from 3.0.0-M4 to 3.0.0-M5.
{{[ERROR
[
https://issues.apache.org/jira/browse/SUREFIRE-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chanseok Oh updated SUREFIRE-1951:
--
Description:
Getting the following error when upgrading from 3.0.0-M4 to 3.0.0-M5.
[ERROR]
Chanseok Oh created SUREFIRE-1951:
-
Summary: Required class missing (TestSetFailedException). Need to
add dependency explicilty.
Key: SUREFIRE-1951
URL: https://issues.apache.org/jira/browse/SUREFIRE-1951
famod commented on pull request #570:
URL: https://github.com/apache/maven/pull/570#issuecomment-939143274
Well, it was the very goal of
https://github.com/apache/maven/commit/76d5f0d942f52650d3bdf775b6af42d23d69066b
to make sure that one thread cannot modify (in a non-atomic way) the arti
slawekjaranowski commented on pull request #573:
URL: https://github.com/apache/maven/pull/573#issuecomment-939032613
Did you search all java files in project? Also tests like
https://github.com/apache/maven/blob/d75bea415457b2eba7815bb9c3e9cd4e14b47fce/maven-model-builder/src/test/java
slawekjaranowski commented on a change in pull request #565:
URL: https://github.com/apache/maven/pull/565#discussion_r725203766
##
File path:
maven-core/src/main/java/org/apache/maven/plugin/internal/MojoLog.java
##
@@ -0,0 +1,203 @@
+package org.apache.maven.plugin.internal;
slawekjaranowski commented on pull request #568:
URL: https://github.com/apache/maven/pull/568#issuecomment-938941294
I not marked every occurrence ... I'm lazy .. please search for `.equals(`
By the way good work 👏
--
This is an automated message from the Apache Git Service.
To respo
[
https://issues.apache.org/jira/browse/MNG-7286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal updated MNG-7286:
---
Summary: Maven Improvements: (was: Improvements:)
> Maven Improvements:
> ---
>
>
arturobernalg opened a new pull request #573:
URL: https://github.com/apache/maven/pull/573
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
f
[
https://issues.apache.org/jira/browse/MNG-7292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal updated MNG-7292:
---
Description: Remove unnecessarily escaped character
> Unnecessarily escaped character
> ---
Arturo Bernal created MNG-7292:
--
Summary: Unnecessarily escaped character
Key: MNG-7292
URL: https://issues.apache.org/jira/browse/MNG-7292
Project: Maven
Issue Type: Sub-task
Report
arturobernalg opened a new pull request #572:
URL: https://github.com/apache/maven/pull/572
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
f
Arturo Bernal created MNG-7291:
--
Summary: Avoid String concatenation in loops.
Key: MNG-7291
URL: https://issues.apache.org/jira/browse/MNG-7291
Project: Maven
Issue Type: Sub-task
R
arturobernalg opened a new pull request #571:
URL: https://github.com/apache/maven/pull/571
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
f
[
https://issues.apache.org/jira/browse/MNG-7290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal updated MNG-7290:
---
Description:
* Replace Lambda with method reference
* Simplify 'Map' operations
* Use lambda
> j
Arturo Bernal created MNG-7290:
--
Summary: java8 improvements
Key: MNG-7290
URL: https://issues.apache.org/jira/browse/MNG-7290
Project: Maven
Issue Type: Sub-task
Reporter: Arturo Be
arturobernalg commented on pull request #568:
URL: https://github.com/apache/maven/pull/568#issuecomment-938748794
> in this case of testing `equals` methods assertTrue/assertFalse is more
readable, we want to test equals
>
> original assertions show what we want to do, when using as
cstamas commented on a change in pull request #38:
URL: https://github.com/apache/maven-plugin-tools/pull/38#discussion_r725114382
##
File path:
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##
@@ -204,6 +204,25 @@ public void exec
cstamas commented on a change in pull request #565:
URL: https://github.com/apache/maven/pull/565#discussion_r725092076
##
File path: maven-core/src/main/java/org/apache/maven/execution/MavenSession.java
##
@@ -192,11 +194,12 @@ public MavenExecutionResult getResult()
//
cstamas commented on a change in pull request #565:
URL: https://github.com/apache/maven/pull/565#discussion_r725091336
##
File path:
maven-core/src/main/java/org/apache/maven/plugin/internal/MojoLog.java
##
@@ -22,24 +22,35 @@
import org.apache.maven.plugin.logging.Log;
imp
cstamas commented on a change in pull request #565:
URL: https://github.com/apache/maven/pull/565#discussion_r725091336
##
File path:
maven-core/src/main/java/org/apache/maven/plugin/internal/MojoLog.java
##
@@ -22,24 +22,35 @@
import org.apache.maven.plugin.logging.Log;
imp
cstamas commented on a change in pull request #565:
URL: https://github.com/apache/maven/pull/565#discussion_r725090593
##
File path: maven-core/src/main/java/org/apache/maven/execution/MavenSession.java
##
@@ -75,7 +76,8 @@
private boolean parallel;
-private final
[
https://issues.apache.org/jira/browse/MPH-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426137#comment-17426137
]
Michael Osipov commented on MPH-182:
I think this is rooted in the expression evaluator
Robert Scholte created MNG-7289:
---
Summary: Tests of Forked Execution fails with Guice provision
errors, while unforked succeeds
Key: MNG-7289
URL: https://issues.apache.org/jira/browse/MNG-7289
Project:
Matt smith created MPH-182:
--
Summary: mvn help:evaluate does not evaluate java.version correctly
Key: MPH-182
URL: https://issues.apache.org/jira/browse/MPH-182
Project: Maven Help Plugin
Issue Type
rmannibucau commented on a change in pull request #565:
URL: https://github.com/apache/maven/pull/565#discussion_r724859141
##
File path: maven-core/src/main/java/org/apache/maven/execution/MavenSession.java
##
@@ -192,11 +194,12 @@ public MavenExecutionResult getResult()
rfscholte commented on a change in pull request #565:
URL: https://github.com/apache/maven/pull/565#discussion_r724854811
##
File path: maven-core/src/main/java/org/apache/maven/execution/MavenSession.java
##
@@ -192,11 +194,12 @@ public MavenExecutionResult getResult()
mickaelistria commented on pull request #570:
URL: https://github.com/apache/maven/pull/570#issuecomment-938492128
> Did you also revert 4e5b3d5 because it is based on top of 76d5f0d?
No, just a revert of 76d5f0d was enough. I don't know how the revert
happened in details, bit it see
rfscholte commented on a change in pull request #38:
URL: https://github.com/apache/maven-plugin-tools/pull/38#discussion_r724843735
##
File path:
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##
@@ -204,6 +204,25 @@ public void ex
cstamas commented on a change in pull request #565:
URL: https://github.com/apache/maven/pull/565#discussion_r724842627
##
File path: maven-core/src/main/java/org/apache/maven/execution/MavenSession.java
##
@@ -192,11 +194,12 @@ public MavenExecutionResult getResult()
//
rfscholte commented on a change in pull request #565:
URL: https://github.com/apache/maven/pull/565#discussion_r724839217
##
File path: maven-core/src/main/java/org/apache/maven/execution/MavenSession.java
##
@@ -192,11 +194,12 @@ public MavenExecutionResult getResult()
michael-o commented on pull request #570:
URL: https://github.com/apache/maven/pull/570#issuecomment-938474734
>
>
> Reverting
[76d5f0d](https://github.com/apache/maven/commit/76d5f0d942f52650d3bdf775b6af42d23d69066b)
(no need to revert anything else) makes the test successful.
[
https://issues.apache.org/jira/browse/MNG-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426051#comment-17426051
]
Michael Osipov commented on MNG-7224:
-
This cannot be fixed in Maven and is not a bug i
rfscholte merged pull request #81:
URL: https://github.com/apache/maven-archetype/pull/81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-u
rfscholte opened a new pull request #81:
URL: https://github.com/apache/maven-archetype/pull/81
Reverts apache/maven-archetype#76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
mickaelistria commented on pull request #570:
URL: https://github.com/apache/maven/pull/570#issuecomment-938444503
Reverting 76d5f0d942f52650d3bdf775b6af42d23d69066b (no need to revert
anything else) makes the test successful.
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/MNG-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426033#comment-17426033
]
Michael Osipov commented on MNG-7224:
-
Still not working in Git Bash (MSYS2)?
> Exit C
[
https://issues.apache.org/jira/browse/MNG-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426027#comment-17426027
]
Lukas Kraushofer edited comment on MNG-7224 at 10/8/21, 7:58 AM:
[
https://issues.apache.org/jira/browse/MNG-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426027#comment-17426027
]
Lukas Kraushofer commented on MNG-7224:
---
This Issue and MNG-7234 have not been fixed
michael-o commented on pull request #570:
URL: https://github.com/apache/maven/pull/570#issuecomment-938415425
@mickaelistria Please revert those two commits and see whether it solves the
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
48 matches
Mail list logo
