[
https://issues.apache.org/jira/browse/MNG-6354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427462#comment-17427462
]
Romain Manni-Bucau commented on MNG-6354:
-
[~michael-o] thanks for the ping, sent n
gnodet edited a comment on pull request #578:
URL: https://github.com/apache/maven/pull/578#issuecomment-940689897
> I confirm that #476 seems to fix
[MNG-6843](https://issues.apache.org/jira/browse/MNG-6843) as well. I've built
maven-3.8.x with that `LockingEventSpy` and there were no fai
gnodet commented on pull request #578:
URL: https://github.com/apache/maven/pull/578#issuecomment-940689897
> I confirm that #476 seems to fix
[MNG-6843](https://issues.apache.org/jira/browse/MNG-6843) as well. I've built
maven-3.8.x with that `LockingEventSpy` and there were no failures i
gnodet commented on a change in pull request #476:
URL: https://github.com/apache/maven/pull/476#discussion_r726782484
##
File path:
maven-core/src/main/java/org/apache/maven/execution/LockingEventSpy.java
##
@@ -0,0 +1,98 @@
+package org.apache.maven.execution;
+
+/*
+ * Lice
arturobernalg opened a new pull request #583:
URL: https://github.com/apache/maven/pull/583
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
f
Arturo Bernal created MNG-7299:
--
Summary: Simplify conditional expression
Key: MNG-7299
URL: https://issues.apache.org/jira/browse/MNG-7299
Project: Maven
Issue Type: Sub-task
Report
[
https://issues.apache.org/jira/browse/MNG-7298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal updated MNG-7298:
---
Parent: MNG-7286
Issue Type: Sub-task (was: Improvement)
> Avoid redundant conditions
> --
dependabot[bot] opened a new pull request #83:
URL: https://github.com/apache/maven-archetype/pull/83
Bumps
[plexus-interactivity-api](https://github.com/codehaus-plexus/plexus-interactivity)
from 1.0 to 1.1.
Commits
https://github.com/codehaus-plexus/plexus-interactivity/com
dependabot[bot] opened a new pull request #35:
URL: https://github.com/apache/maven-help-plugin/pull/35
Bumps [maven-model](https://github.com/apache/maven) from 3.8.2 to 3.8.3.
Commits
https://github.com/apache/maven/commit/ff8e977a158738155dc465c6a97ffaf31982d739";>ff8e977
[
famod commented on pull request #578:
URL: https://github.com/apache/maven/pull/578#issuecomment-940512890
I confirm that #476 seems to fix MNG-6843 as well. I've built maven-3.8.x
with that `LockingEventSpy` and there were no failures in
https://github.com/famod/parallel-testbed/tree/comp
famod commented on a change in pull request #476:
URL: https://github.com/apache/maven/pull/476#discussion_r726609785
##
File path:
maven-core/src/main/java/org/apache/maven/execution/LockingEventSpy.java
##
@@ -0,0 +1,98 @@
+package org.apache.maven.execution;
+
+/*
+ * Licen
hboutemy commented on pull request #580:
URL: https://github.com/apache/maven/pull/580#issuecomment-940463313
> Did you try to run the IT's locally?
yes, but I didn't wait for the message at the end: now I see
thanks for the pointer, I'll fix the ITs runner
--
This is an automat
rfscholte edited a comment on pull request #580:
URL: https://github.com/apache/maven/pull/580#issuecomment-940429217
```
[ERROR] Tests run: 882, Failures: 0, Errors: 4, Skipped: 0, Time elapsed:
528.071 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
[ERROR] testitMNG593
rfscholte commented on pull request #580:
URL: https://github.com/apache/maven/pull/580#issuecomment-940429217
@hboutemy I think you need to update
https://github.com/apache/maven-integration-testing/blob/master/run-its.bat#L34-L35
and
https://github.com/apache/maven-integration-testing/
michael-o commented on a change in pull request #20:
URL: https://github.com/apache/maven-war-plugin/pull/20#discussion_r726557904
##
File path: pom.xml
##
@@ -62,9 +62,9 @@
-3.5.0
+3.5.1
3.1.1
-3.1.0
+3.2.5
Review comment:
>
>
> I
elharo commented on a change in pull request #20:
URL: https://github.com/apache/maven-war-plugin/pull/20#discussion_r726554427
##
File path: pom.xml
##
@@ -62,9 +62,9 @@
-3.5.0
+3.5.1
3.1.1
-3.1.0
+3.2.5
Review comment:
I feel like there'
rfscholte commented on pull request #580:
URL: https://github.com/apache/maven/pull/580#issuecomment-940418330
> I don't get why ITs are failing: I can't find any log that could point me
in a direction :/ can you help, please?
I thought @Tibor17 created something to download the comp
[
https://issues.apache.org/jira/browse/MNG-6354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427357#comment-17427357
]
Michael Osipov commented on MNG-6354:
-
[~romain.manni-bucau], don't forget about the th
michael-o commented on pull request #580:
URL: https://github.com/apache/maven/pull/580#issuecomment-940415554
>
>
> @michael-o I think there's a little bit of confusion here. The wrapper
scripts have never been part of the apache-maven distribution, but they have
exactly the same
rfscholte commented on pull request #580:
URL: https://github.com/apache/maven/pull/580#issuecomment-940414247
@michael-o I think there's a little bit of confusion here. The wrapper
scripts have never been part of the apache-maven distribution, but they have
exactly the same lifecycle, bec
hboutemy commented on pull request #580:
URL: https://github.com/apache/maven/pull/580#issuecomment-940413447
I don't get why ITs are failing: I can't find any log that could point me in
a direction :/
can you help, please?
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/MNG-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MNG-7270:
---
Assignee: Michael Osipov
> Maven startup script (init) calls which(1) which is an external com
timtebeek commented on pull request #113:
URL: https://github.com/apache/maven-enforcer/pull/113#issuecomment-940392342
So I think the failures are caused by the integration test not being able to
locate `enforcer-api`; a fairly easy solution could be to run `mvn install`
[rather than `mvn
arturobernalg opened a new pull request #582:
URL: https://github.com/apache/maven/pull/582
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
f
[
https://issues.apache.org/jira/browse/MNG-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427345#comment-17427345
]
Michael Osipov commented on MNG-7283:
-
bq. (1) Before executing maven, execute a script
[
https://issues.apache.org/jira/browse/MNG-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427344#comment-17427344
]
Michael Osipov commented on MNG-7283:
-
{quote}
I thought about ServiceLoader before, bu
michael-o commented on pull request #580:
URL: https://github.com/apache/maven/pull/580#issuecomment-940379837
Maven Wrapper must be removed from Core altogether and live in a separate
repo. I see no reason to bundle it with Core at all. Moreover, as Robert said,
the scripts are horrible.
michael-o commented on a change in pull request #20:
URL: https://github.com/apache/maven-war-plugin/pull/20#discussion_r726515756
##
File path: pom.xml
##
@@ -62,9 +62,9 @@
-3.5.0
+3.5.1
3.1.1
-3.1.0
+3.2.5
Review comment:
I even have ano
Arturo Bernal created MNG-7298:
--
Summary: Avoid redundant conditions
Key: MNG-7298
URL: https://issues.apache.org/jira/browse/MNG-7298
Project: Maven
Issue Type: Improvement
Reporter
slachiewicz commented on a change in pull request #20:
URL: https://github.com/apache/maven-war-plugin/pull/20#discussion_r726510483
##
File path: pom.xml
##
@@ -62,9 +62,9 @@
-3.5.0
+3.5.1
3.1.1
-3.1.0
+3.2.5
Review comment:
Yes, agree. i
elharo commented on a change in pull request #20:
URL: https://github.com/apache/maven-war-plugin/pull/20#discussion_r726509781
##
File path: pom.xml
##
@@ -62,9 +62,9 @@
-3.5.0
+3.5.1
3.1.1
-3.1.0
+3.2.5
Review comment:
Personally I'm OK
[
https://issues.apache.org/jira/browse/MNG-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427325#comment-17427325
]
Sylwester Lachiewicz commented on MNG-7297:
---
Done for 4.x with
[0080e84588492281
[
https://issues.apache.org/jira/browse/MNG-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz closed MNG-7297.
-
Resolution: Fixed
> Remove redundant type arguments
> ---
>
>
slachiewicz merged pull request #581:
URL: https://github.com/apache/maven/pull/581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
[
https://issues.apache.org/jira/browse/MNG-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz reassigned MNG-7297:
-
Assignee: Sylwester Lachiewicz
> Remove redundant type arguments
> ---
slachiewicz commented on a change in pull request #20:
URL: https://github.com/apache/maven-war-plugin/pull/20#discussion_r726498389
##
File path: pom.xml
##
@@ -62,9 +62,9 @@
-3.5.0
+3.5.1
3.1.1
-3.1.0
+3.2.5
Review comment:
we can stay w
[
https://issues.apache.org/jira/browse/MPLUGIN-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte updated MPLUGIN-350:
---
Description:
By knowing if parameters are input or output parameters, it is possible to
imp
arturobernalg opened a new pull request #581:
URL: https://github.com/apache/maven/pull/581
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
f
[
https://issues.apache.org/jira/browse/MNG-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427294#comment-17427294
]
Ran Biron commented on MNG-4173:
[~alan-czajkowski] I think that's a very "ivory tower" app
rfscholte commented on pull request #580:
URL: https://github.com/apache/maven/pull/580#issuecomment-940279955
The different between MNG-6914 and MNG-7073 is that with MNG-6914 the
structure of the mvnw scripts stays as donated. With MNG-7073 things are
regrouped, so we need less partial s
[
https://issues.apache.org/jira/browse/MNG-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal updated MNG-7297:
---
Summary: Remove redundant type arguments (was: Remmove redundant type
arguments)
> Remove redundant t
Arturo Bernal created MNG-7297:
--
Summary: Remmove redundant type arguments
Key: MNG-7297
URL: https://issues.apache.org/jira/browse/MNG-7297
Project: Maven
Issue Type: Sub-task
Repor
dependabot[bot] opened a new pull request #19:
URL: https://github.com/apache/maven-filtering/pull/19
Bumps [maven-shared-utils](https://github.com/apache/maven-shared-utils)
from 3.3.3 to 3.3.4.
Commits
https://github.com/apache/maven-shared-utils/commit/17091d82508deb9b7067f
dependabot[bot] opened a new pull request #18:
URL: https://github.com/apache/maven-filtering/pull/18
Bumps plexus-build-api from 0.0.4 to 0.0.7.
[ not returning correct value
[
https://issues.apache.org/jira/browse/MNG-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7285:
Affects Version/s: 4.0.0-alpha-1
> [Regression] MavenProject.getArtifacts() not returning correct val
[
https://issues.apache.org/jira/browse/MNG-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427203#comment-17427203
]
Michael Osipov commented on MNG-7285:
-
[~mickael.istria], I guess this issue applies to
[
https://issues.apache.org/jira/browse/MNG-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7285:
Fix Version/s: 3.8.x-candidate
> [Regression] MavenProject.getArtifacts() not returning correct value
[
https://issues.apache.org/jira/browse/MNG-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MNG-7285:
---
Assignee: Michael Osipov
> [Regression] MavenProject.getArtifacts() not returning correct valu
gnodet commented on pull request #578:
URL: https://github.com/apache/maven/pull/578#issuecomment-940077448
> @famod I will do asap. At first glance, I wonder if this is somewhat
related to https://issues.apache.org/jira/browse/MNG-7156 and #476. The problem
and locking strategy are differ
[
https://issues.apache.org/jira/browse/MDEP-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427151#comment-17427151
]
Michael Osipov commented on MDEP-761:
-
Not from we, all I did is to get down to the off
McFoggy commented on pull request #565:
URL: https://github.com/apache/maven/pull/565#issuecomment-940060099
Hi, as you ping me there for the replacement of #437 and #438 here is what I
can tell you.
When I created the PRs, I was looking for a standardized way to use & inject
"Logge
famod commented on pull request #578:
URL: https://github.com/apache/maven/pull/578#issuecomment-940057376
@michael-o
> Can you provide a PR for master when we have agreed on a solution?
Sure!
@gnodet
Thanks for the pointer, I'll have a look #476 later
--
This is an a
[
https://issues.apache.org/jira/browse/MDEP-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427138#comment-17427138
]
Jan commented on MDEP-761:
--
[~michael-o] [~elharo]
Any updates here?
> Tree plugin does not termi
michael-o commented on pull request #578:
URL: https://github.com/apache/maven/pull/578#issuecomment-940046179
I will take care of the merging when done.
@famod Can you provide a PR for master when we have agreed on a solution?
--
This is an automated message from the Apache Git Servi
mickaelistria commented on pull request #578:
URL: https://github.com/apache/maven/pull/578#issuecomment-940039853
Maybe you should consider adding #570 or similar test into this PR to
validate this fix and also prevent from future regressions.
--
This is an automated message from the Ap
mickaelistria commented on pull request #570:
URL: https://github.com/apache/maven/pull/570#issuecomment-940038736
Again, I'm not expert in MNG-6843 and family, but looking purely at the
code, I find #578 less intrusive, restricting and disruptive than the previous
related patches, so if #
cstamas commented on a change in pull request #20:
URL: https://github.com/apache/maven-war-plugin/pull/20#discussion_r726063097
##
File path: pom.xml
##
@@ -62,9 +62,9 @@
-3.5.0
+3.5.1
3.1.1
-3.1.0
+3.2.5
Review comment:
This is requireme
cstamas commented on a change in pull request #19:
URL: https://github.com/apache/maven-jar-plugin/pull/19#discussion_r726062940
##
File path: pom.xml
##
@@ -76,8 +75,8 @@
3.0.0
-3.5.0
-3.1.0
+3.5.1
+3.2.5
Review comment:
This is requirement d
elharo commented on a change in pull request #19:
URL: https://github.com/apache/maven-jar-plugin/pull/19#discussion_r726054957
##
File path: pom.xml
##
@@ -76,8 +75,8 @@
3.0.0
-3.5.0
-3.1.0
+3.5.1
+3.2.5
Review comment:
same comment as on war
elharo commented on a change in pull request #20:
URL: https://github.com/apache/maven-war-plugin/pull/20#discussion_r726054276
##
File path: pom.xml
##
@@ -62,9 +62,9 @@
-3.5.0
+3.5.1
3.1.1
-3.1.0
+3.2.5
Review comment:
Is this required?
[
https://issues.apache.org/jira/browse/MDEP-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427088#comment-17427088
]
Tommy Andersen commented on MDEP-773:
-
We have seen that on a project as well, where a
cstamas opened a new pull request #20:
URL: https://github.com/apache/maven-war-plugin/pull/20
Move maven to proper scope, update dependencies,
remove unused ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
cstamas opened a new pull request #19:
URL: https://github.com/apache/maven-jar-plugin/pull/19
And retain it still Java7. Make mvn core bits
proper scoped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
[
https://issues.apache.org/jira/browse/MDEPLOY-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Victoria updated MDEPLOY-288:
-
Description:
We have a project without primary artifact.
Previously, we were using _maven-deploy-plugin
[
https://issues.apache.org/jira/browse/MDEPLOY-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Victoria updated MDEPLOY-288:
-
Description:
We have a project without primary artifact.
Previously, we were using _maven-deploy-plugin
cstamas opened a new pull request #7:
URL: https://github.com/apache/maven-resources-plugin/pull/7
Set proper scope and update dependencies, those
that can be, while retaining Java7 level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
Victoria created MDEPLOY-288:
Summary: Deploy is failed when no primary artifact is present
Key: MDEPLOY-288
URL: https://issues.apache.org/jira/browse/MDEPLOY-288
Project: Maven Deploy Plugin
Is
[
https://issues.apache.org/jira/browse/MNG-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427068#comment-17427068
]
wangjie commented on MNG-7283:
--
I now have other ways to solve this problem:
(1) Before execut
[
https://issues.apache.org/jira/browse/MNG-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427067#comment-17427067
]
wangjie commented on MNG-7283:
--
thank you very much for your help.
I thought about ServiceLoad
[
https://issues.apache.org/jira/browse/MRRESOURCES-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MRRESOURCES-118.
---
Resolution: Fixed
> Require Maven 3.2.0
> ---
>
>
[
https://issues.apache.org/jira/browse/MRRESOURCES-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427024#comment-17427024
]
Robert Scholte commented on MRRESOURCES-118:
And yes, now I can fix the
[
https://issues.apache.org/jira/browse/MRRESOURCES-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427023#comment-17427023
]
Robert Scholte commented on MRRESOURCES-118:
I assume 3.0.0 is the right
[
https://issues.apache.org/jira/browse/MRRESOURCES-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427019#comment-17427019
]
Guillaume Nodet commented on MRRESOURCES-118:
-
[~rfscholte] would you mi
[
https://issues.apache.org/jira/browse/MRRESOURCES-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427016#comment-17427016
]
Guillaume Nodet commented on MRRESOURCES-118:
-
This is now fixed.
There
gnodet commented on pull request #578:
URL: https://github.com/apache/maven/pull/578#issuecomment-939781062
@famod I will do asap. At first glance, I wonder if this is somewhat
related to https://issues.apache.org/jira/browse/MNG-7156 and #476. The
problem and locking strategy are diffe
[
https://issues.apache.org/jira/browse/MRRESOURCES-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426982#comment-17426982
]
Guillaume Nodet edited comment on MRRESOURCES-118 at 10/11/21, 7:42 AM:
--
rfscholte commented on a change in pull request #580:
URL: https://github.com/apache/maven/pull/580#discussion_r725861215
##
File path: apache-maven-wrapper/src/assembly/shared.xml
##
@@ -42,11 +35,11 @@ under the License.
-src/assembly/shared/valida
rfscholte commented on pull request #580:
URL: https://github.com/apache/maven/pull/580#issuecomment-939767587
Do you consider this as a start for
https://issues.apache.org/jira/browse/MNG-7073 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
rfscholte commented on a change in pull request #580:
URL: https://github.com/apache/maven/pull/580#discussion_r725858768
##
File path: apache-maven/src/assembly/shared/run
##
@@ -16,4 +16,4 @@ exec "$JAVACMD" \
"-Dmaven.home=$MAVEN_HOME" \
"-Dlibrary.jansi.path=${MAVEN_H
rfscholte commented on pull request #580:
URL: https://github.com/apache/maven/pull/580#issuecomment-939758150
FYI, all wrapper related integrationtests are broken. Looks like you
refactored a bit too much.
--
This is an automated message from the Apache Git Service.
To respond to the me
[
https://issues.apache.org/jira/browse/MRRESOURCES-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426982#comment-17426982
]
Guillaume Nodet commented on MRRESOURCES-118:
-
[~rfscholte] on which pla
slachiewicz closed pull request #30:
URL: https://github.com/apache/maven-parent/pull/30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-un
dependabot[bot] commented on pull request #30:
URL: https://github.com/apache/maven-parent/pull/30#issuecomment-939748992
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor v
dependabot[bot] commented on pull request #50:
URL:
https://github.com/apache/maven-apache-parent/pull/50#issuecomment-939747796
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or
slachiewicz closed pull request #50:
URL: https://github.com/apache/maven-apache-parent/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: is
famod commented on pull request #578:
URL: https://github.com/apache/maven/pull/578#issuecomment-939740819
Oliver's PR doesn't help when thread pools are involved, btw.
@gnodet I'd love to hear your take on this.
--
This is an automated message from the Apache Git Service.
To respo
[
https://issues.apache.org/jira/browse/MRRESOURCES-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426976#comment-17426976
]
Robert Scholte commented on MRRESOURCES-118:
Most likely this commit nee
91 matches
Mail list logo
