[GitHub] [maven] michael-o commented on pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type

2021-12-30 Thread GitBox
michael-o commented on pull request #641: URL: https://github.com/apache/maven/pull/641#issuecomment-1002970252 > no, I'm not trying to automagically retain the original type: I'm just trying to use the (hand-written) factory to remove code duplication Agree, suboptimal. >

[jira] [Commented] (MNG-7380) Don't log non-threadsafe warning if only building a single module

2021-12-30 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17466787#comment-17466787 ] Michael Osipov commented on MNG-7380: - I wonder whether this applies to forked lifecycles also... >

[GitHub] [maven] mthmulders commented on a change in pull request #643: [MNG-5561] Plugin relocation loses configuration

2021-12-30 Thread GitBox
mthmulders commented on a change in pull request #643: URL: https://github.com/apache/maven/pull/643#discussion_r776665661 ## File path: maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/RelocatedArtifact.java ## @@ -86,6 +86,39 @@ public String

[GitHub] [maven] hboutemy commented on pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type

2021-12-30 Thread GitBox
hboutemy commented on pull request #641: URL: https://github.com/apache/maven/pull/641#issuecomment-1002967160 no, I'm not trying to automagically retain the original type: I'm just trying to use the (hand-written) factory to remove code duplication digging a little bit more, it

[jira] [Comment Edited] (MRESOLVER-228) Improve the maven dependency resolution speed by a skip & reconcile approach

2021-12-30 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17466786#comment-17466786 ] Michael Osipov edited comment on MRESOLVER-228 at 12/30/21, 10:30 AM:

[jira] [Commented] (MRESOLVER-228) Improve the maven dependency resolution speed by a skip & reconcile approach

2021-12-30 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17466786#comment-17466786 ] Michael Osipov commented on MRESOLVER-228: -- [~wecai], thanks! As far as I understand your

[GitHub] [maven] michael-o commented on pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type

2021-12-30 Thread GitBox
michael-o commented on pull request #641: URL: https://github.com/apache/maven/pull/641#issuecomment-1002965979 > @michael-o instead of copy/pasting the 3 methods, I think we could change "private Artifact newInstance" (from AbstractArtifact) to protected, then simply override this method

[GitHub] [maven] hboutemy commented on pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type

2021-12-30 Thread GitBox
hboutemy commented on pull request #641: URL: https://github.com/apache/maven/pull/641#issuecomment-1002963399 @michael-o instead of copy/pasting the 3 methods, I think we could change "private Artifact newInstance" (from AbstractArtifact) to protected, then simply override this method

[GitHub] [maven-integration-testing] mthmulders commented on a change in pull request #132: [MNG-5561] Plugin relocation loses configuration

2021-12-30 Thread GitBox
mthmulders commented on a change in pull request #132: URL: https://github.com/apache/maven-integration-testing/pull/132#discussion_r776661962 ## File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5561PluginRelocationLosesConfigurationTest.java ## @@ -0,0

[GitHub] [maven-integration-testing] michael-o commented on a change in pull request #132: [MNG-5561] Plugin relocation loses configuration

2021-12-30 Thread GitBox
michael-o commented on a change in pull request #132: URL: https://github.com/apache/maven-integration-testing/pull/132#discussion_r776661361 ## File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5561PluginRelocationLosesConfigurationTest.java ## @@ -0,0

[jira] [Assigned] (MSHARED-1009) Allow to provide Maven executable from workspace

2021-12-30 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MSHARED-1009: Assignee: Slawomir Jaranowski > Allow to provide Maven executable from

[jira] [Created] (MSHARED-1009) Allow to provide Maven executable from workspace

2021-12-30 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MSHARED-1009: Summary: Allow to provide Maven executable from workspace Key: MSHARED-1009 URL: https://issues.apache.org/jira/browse/MSHARED-1009 Project: Maven

[jira] [Closed] (MSHARED-577) Remove usage of M2_HOME environment variable

2021-12-30 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-577. --- Resolution: Fixed > Remove usage of M2_HOME environment variable >

[GitHub] [maven-invoker] slawekjaranowski merged pull request #35: [MSHARED-577] Remove usage of M2_HOME environment variable

2021-12-30 Thread GitBox
slawekjaranowski merged pull request #35: URL: https://github.com/apache/maven-invoker/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MRESOLVER-228) Improve the maven dependency resolution speed by a skip & reconcile approach

2021-12-30 Thread wei cai (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17466764#comment-17466764 ] wei cai commented on MRESOLVER-228: --- [~ibabiankou]  Thanks for your comments!  Kudos for the

[GitHub] [maven-mvnd] yxxcrtd edited a comment on issue #554: macOS Monterey doesn

2021-12-30 Thread GitBox
yxxcrtd edited a comment on issue #554: URL: https://github.com/apache/maven-mvnd/issues/554#issuecomment-1002938817 I config env in .zshrc export PATH=$PATH:/Users/yxx/mvnd-0.7.1/bin then execute mvnd show: zsh: permission denied: mvnd -- This is an automated message from the

[GitHub] [maven-mvnd] Fzoss commented on issue #549: How do i set other maven repository?

2021-12-30 Thread GitBox
Fzoss commented on issue #549: URL: https://github.com/apache/maven-mvnd/issues/549#issuecomment-1002938999 look https://github.com/apache/maven-mvnd/issues/553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-mvnd] yxxcrtd commented on issue #554: macOS Monterey doesn

2021-12-30 Thread GitBox
yxxcrtd commented on issue #554: URL: https://github.com/apache/maven-mvnd/issues/554#issuecomment-1002938817 I config env in .zshrc export PATH=$PATH:/Users/yxx/mvnd-0.7.1/bin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [maven-mvnd] yxxcrtd commented on issue #552: How to use mvnd in Jenkins?

2021-12-30 Thread GitBox
yxxcrtd commented on issue #552: URL: https://github.com/apache/maven-mvnd/issues/552#issuecomment-1002932385 The same question ! I config Global Tool Configuration in jenkins, and set Maven's Name is **mvnd**, and MAVEN_HOME is **/home/mvnd-0.7.1/mvn**, then build without mvnd,

[GitHub] [maven-integration-testing] mthmulders commented on a change in pull request #132: [MNG-5561] Plugin relocation loses configuration

2021-12-30 Thread GitBox
mthmulders commented on a change in pull request #132: URL: https://github.com/apache/maven-integration-testing/pull/132#discussion_r776487433 ## File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5561PluginRelocationLosesConfigurationTest.java ## @@ -0,0

[jira] [Commented] (MDEPLOY-250) add documentation on managing network issues

2021-12-30 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MDEPLOY-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17466719#comment-17466719 ] Herve Boutemy commented on MDEPLOY-250: --- documentation created in

<    1   2