[jira] [Commented] (MSKINS-161) Upgrade Facebook Like button integration

2022-04-05 Thread Swarup Patra (Jira)
[ https://issues.apache.org/jira/browse/MSKINS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517837#comment-17517837 ] Swarup Patra commented on MSKINS-161: - There Are Method Of Completecity Are There Behind More Away

[jira] [Updated] (MNG-7448) if we delete bin directory in apache-maven/src, we can not find because git has ignore it .

2022-04-05 Thread Daqian Liao (Jira)
[ https://issues.apache.org/jira/browse/MNG-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daqian Liao updated MNG-7448: - Description: when we download sourcecode, and push code to github, the apache-maven/src/bin directory

[jira] [Comment Edited] (MSHADE-323) Flatten Maven Plugin conflicts with Maven Shade Plugin

2022-04-05 Thread James Z.M. Gao (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517764#comment-17517764 ] James Z.M. Gao edited comment on MSHADE-323 at 4/6/22 1:05 AM: --- [~ilyak]

[jira] [Commented] (MSHADE-323) Flatten Maven Plugin conflicts with Maven Shade Plugin

2022-04-05 Thread James Z.M. Gao (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517764#comment-17517764 ] James Z.M. Gao commented on MSHADE-323: --- [~ilyak] this

[GitHub] [maven-shade-plugin] gzm55 opened a new pull request, #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

2022-04-05 Thread GitBox
gzm55 opened a new pull request, #129: URL: https://github.com/apache/maven-shade-plugin/pull/129 The runtime injected pom will be set via `MavenProject::setFile` or`MavenProject::setPomFile`, including this plugin and the flatten plugin. So to chain these kind of plugins, when generating

[jira] [Created] (MSHARED-1051) Require Java 8

2022-04-05 Thread Jira
Jorge Solórzano created MSHARED-1051: Summary: Require Java 8 Key: MSHARED-1051 URL: https://issues.apache.org/jira/browse/MSHARED-1051 Project: Maven Shared Components Issue Type:

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #505: [SUREFIRE-2055] Always show random seed

2022-04-05 Thread GitBox
slawekjaranowski commented on PR #505: URL: https://github.com/apache/maven-surefire/pull/505#issuecomment-1089418286 build approval ... we will see the result -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #505: [SUREFIRE-2055] Always show random seed

2022-04-05 Thread GitBox
slawekjaranowski commented on PR #505: URL: https://github.com/apache/maven-surefire/pull/505#issuecomment-1089407118 you cen edit PR description and copy template from https://github.com/apache/maven-surefire/blob/master/.github/pull_request_template.md -- This is an automated message

[GitHub] [maven-surefire] delanym commented on pull request #505: [SUREFIRE-2055] Always show random seed

2022-04-05 Thread GitBox
delanym commented on PR #505: URL: https://github.com/apache/maven-surefire/pull/505#issuecomment-1089388850 @slawekjaranowski how do I get the PR template back? What's wrong with my IT test? -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (MCOMPILER-489) User property for multiReleaseOutput

2022-04-05 Thread John Patrick (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517711#comment-17517711 ] John Patrick commented on MCOMPILER-489: I know what you are saying, and that is what i'm

[GitHub] [maven-invoker-plugin] slawekjaranowski opened a new pull request, #110: [MINVOKER-299] fix filtering-extensions test

2022-04-05 Thread GitBox
slawekjaranowski opened a new pull request, #110: URL: https://github.com/apache/maven-invoker-plugin/pull/110 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA

[jira] [Assigned] (MINVOKER-299) IT test filtering-extensions fails on Maven 3.8.5

2022-04-05 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MINVOKER-299: Assignee: Slawomir Jaranowski > IT test filtering-extensions fails on

[jira] [Created] (MINVOKER-299) IT test filtering-extensions fails on Maven 3.8.5

2022-04-05 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MINVOKER-299: Summary: IT test filtering-extensions fails on Maven 3.8.5 Key: MINVOKER-299 URL: https://issues.apache.org/jira/browse/MINVOKER-299 Project: Maven

[jira] [Commented] (MNG-7238) Dependency deprecation indicators

2022-04-05 Thread Chris Kilding (Jira)
[ https://issues.apache.org/jira/browse/MNG-7238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517686#comment-17517686 ] Chris Kilding commented on MNG-7238: In light of the recent Log4Shell and Spring4Shell vulnerabilities,

[GitHub] [maven-surefire] dependabot[bot] commented on pull request #509: Bump junit from 4.13 to 4.13.1 in /surefire-its/src/test/resources/junit-4-5

2022-04-05 Thread GitBox
dependabot[bot] commented on PR #509: URL: https://github.com/apache/maven-surefire/pull/509#issuecomment-1089279325 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [maven-surefire] slawekjaranowski closed pull request #509: Bump junit from 4.13 to 4.13.1 in /surefire-its/src/test/resources/junit-4-5

2022-04-05 Thread GitBox
slawekjaranowski closed pull request #509: Bump junit from 4.13 to 4.13.1 in /surefire-its/src/test/resources/junit-4-5 URL: https://github.com/apache/maven-surefire/pull/509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [maven-surefire] dependabot[bot] commented on pull request #510: Bump junit from 4.8.1 to 4.13.1 in /surefire-its/src/test/resources/surefire-1004-RunTestFromDependencyJarsTypeAndClassifier/s

2022-04-05 Thread GitBox
dependabot[bot] commented on PR #510: URL: https://github.com/apache/maven-surefire/pull/510#issuecomment-1089279059 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [maven-surefire] slawekjaranowski closed pull request #510: Bump junit from 4.8.1 to 4.13.1 in /surefire-its/src/test/resources/surefire-1004-RunTestFromDependencyJarsTypeAndClassifier/surefi

2022-04-05 Thread GitBox
slawekjaranowski closed pull request #510: Bump junit from 4.8.1 to 4.13.1 in /surefire-its/src/test/resources/surefire-1004-RunTestFromDependencyJarsTypeAndClassifier/surefire-1004-testjar URL: https://github.com/apache/maven-surefire/pull/510 -- This is an automated message from the Apache

[GitHub] [maven-surefire] dependabot[bot] commented on pull request #511: Bump junit from 4.13 to 4.13.1 in /surefire-its/src/test/resources/surefire-1733-junit4

2022-04-05 Thread GitBox
dependabot[bot] commented on PR #511: URL: https://github.com/apache/maven-surefire/pull/511#issuecomment-1089278614 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [maven-surefire] slawekjaranowski closed pull request #511: Bump junit from 4.13 to 4.13.1 in /surefire-its/src/test/resources/surefire-1733-junit4

2022-04-05 Thread GitBox
slawekjaranowski closed pull request #511: Bump junit from 4.13 to 4.13.1 in /surefire-its/src/test/resources/surefire-1733-junit4 URL: https://github.com/apache/maven-surefire/pull/511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [maven-surefire] slawekjaranowski closed pull request #512: Bump log4j-core from 2.13.1 to 2.17.1 in /surefire-its/src/test/resources/surefire-1659-stream-corruption

2022-04-05 Thread GitBox
slawekjaranowski closed pull request #512: Bump log4j-core from 2.13.1 to 2.17.1 in /surefire-its/src/test/resources/surefire-1659-stream-corruption URL: https://github.com/apache/maven-surefire/pull/512 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-surefire] dependabot[bot] commented on pull request #513: Bump commons-io from 2.2 to 2.7 in /surefire-its/src/test/resources/surefire-979-smartStackTrace-wrongClassloader/module1

2022-04-05 Thread GitBox
dependabot[bot] commented on PR #513: URL: https://github.com/apache/maven-surefire/pull/513#issuecomment-1089278047 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [maven-surefire] dependabot[bot] commented on pull request #512: Bump log4j-core from 2.13.1 to 2.17.1 in /surefire-its/src/test/resources/surefire-1659-stream-corruption

2022-04-05 Thread GitBox
dependabot[bot] commented on PR #512: URL: https://github.com/apache/maven-surefire/pull/512#issuecomment-1089278282 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [maven-surefire] slawekjaranowski closed pull request #513: Bump commons-io from 2.2 to 2.7 in /surefire-its/src/test/resources/surefire-979-smartStackTrace-wrongClassloader/module1

2022-04-05 Thread GitBox
slawekjaranowski closed pull request #513: Bump commons-io from 2.2 to 2.7 in /surefire-its/src/test/resources/surefire-979-smartStackTrace-wrongClassloader/module1 URL: https://github.com/apache/maven-surefire/pull/513 -- This is an automated message from the Apache Git Service. To respond

[jira] [Created] (MNG-7452) Remove JDK7 run on Maven 3.9.X Branch

2022-04-05 Thread Karl Heinz Marbaise (Jira)
Karl Heinz Marbaise created MNG-7452: Summary: Remove JDK7 run on Maven 3.9.X Branch Key: MNG-7452 URL: https://issues.apache.org/jira/browse/MNG-7452 Project: Maven Issue Type: Task

[jira] [Commented] (MNG-828) log all mojo parameters and their populated values in debug mode

2022-04-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517678#comment-17517678 ] Hudson commented on MNG-828: Build unstable in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #10 See

[jira] [Commented] (MNG-7447) Several Improvements by using Stream API

2022-04-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517677#comment-17517677 ] Hudson commented on MNG-7447: - Build unstable in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #10 See

[GitHub] [maven-surefire] dependabot[bot] opened a new pull request, #514: Bump junit from 4.8.2 to 4.13.1 in /surefire-providers/surefire-junit47

2022-04-05 Thread GitBox
dependabot[bot] opened a new pull request, #514: URL: https://github.com/apache/maven-surefire/pull/514 Bumps [junit](https://github.com/junit-team/junit4) from 4.8.2 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases;>junit's releases.

[jira] [Commented] (MNG-828) log all mojo parameters and their populated values in debug mode

2022-04-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517673#comment-17517673 ] Hudson commented on MNG-828: Build succeeded in Jenkins: Maven » Maven TLP » maven » master #24 See

[jira] [Commented] (MNG-7447) Several Improvements by using Stream API

2022-04-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517672#comment-17517672 ] Hudson commented on MNG-7447: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #24 See

[jira] [Closed] (SUREFIRE-2044) Upgrade Maven Verifier to 1.8.0

2022-04-05 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed SUREFIRE-2044. - Fix Version/s: 3.0.0-M7 Resolution: Fixed > Upgrade Maven Verifier to

[GitHub] [maven-surefire] dependabot[bot] opened a new pull request, #513: Bump commons-io from 2.2 to 2.7 in /surefire-its/src/test/resources/surefire-979-smartStackTrace-wrongClassloader/module1

2022-04-05 Thread GitBox
dependabot[bot] opened a new pull request, #513: URL: https://github.com/apache/maven-surefire/pull/513 Bumps commons-io from 2.2 to 2.7. [![Dependabot compatibility

[GitHub] [maven-surefire] dependabot[bot] opened a new pull request, #512: Bump log4j-core from 2.13.1 to 2.17.1 in /surefire-its/src/test/resources/surefire-1659-stream-corruption

2022-04-05 Thread GitBox
dependabot[bot] opened a new pull request, #512: URL: https://github.com/apache/maven-surefire/pull/512 Bumps log4j-core from 2.13.1 to 2.17.1. [![Dependabot compatibility

[GitHub] [maven-surefire] dependabot[bot] opened a new pull request, #511: Bump junit from 4.13 to 4.13.1 in /surefire-its/src/test/resources/surefire-1733-junit4

2022-04-05 Thread GitBox
dependabot[bot] opened a new pull request, #511: URL: https://github.com/apache/maven-surefire/pull/511 Bumps [junit](https://github.com/junit-team/junit4) from 4.13 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases;>junit's releases. JUnit

[GitHub] [maven-surefire] dependabot[bot] opened a new pull request, #509: Bump junit from 4.13 to 4.13.1 in /surefire-its/src/test/resources/junit-4-5

2022-04-05 Thread GitBox
dependabot[bot] opened a new pull request, #509: URL: https://github.com/apache/maven-surefire/pull/509 Bumps [junit](https://github.com/junit-team/junit4) from 4.13 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases;>junit's releases. JUnit

[GitHub] [maven-surefire] dependabot[bot] opened a new pull request, #510: Bump junit from 4.8.1 to 4.13.1 in /surefire-its/src/test/resources/surefire-1004-RunTestFromDependencyJarsTypeAndClassifier/

2022-04-05 Thread GitBox
dependabot[bot] opened a new pull request, #510: URL: https://github.com/apache/maven-surefire/pull/510 Bumps [junit](https://github.com/junit-team/junit4) from 4.8.1 to 4.13.1. Release notes Sourced from https://github.com/junit-team/junit4/releases;>junit's releases.

[GitHub] [maven-surefire] slawekjaranowski merged pull request #507: [SUREFIRE-2044] Upgrade Maven Verifier to 1.8.0

2022-04-05 Thread GitBox
slawekjaranowski merged PR #507: URL: https://github.com/apache/maven-surefire/pull/507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #505: [SUREFIRE-2055] Always show random seed

2022-04-05 Thread GitBox
slawekjaranowski commented on PR #505: URL: https://github.com/apache/maven-surefire/pull/505#issuecomment-1089241967 @delanym - please check build result - PR template contains important things - should be preserved -- This is an automated message from the Apache Git

[GitHub] [maven-deploy-plugin] slawekjaranowski commented on a diff in pull request #21: [doc] improve site documentation deploy-ssh-external example

2022-04-05 Thread GitBox
slawekjaranowski commented on code in PR #21: URL: https://github.com/apache/maven-deploy-plugin/pull/21#discussion_r843179383 ## src/site/apt/examples/deploy-ssh-external.apt: ## @@ -58,9 +58,26 @@ Deployment of artifacts in an external SSH command ++ - If you are

[jira] [Commented] (MNG-7447) Several Improvements by using Stream API

2022-04-05 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517658#comment-17517658 ] Karl Heinz Marbaise commented on MNG-7447: -- Done in

[jira] [Closed] (MNG-7447) Several Improvements by using Stream API

2022-04-05 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MNG-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MNG-7447. Resolution: Done > Several Improvements by using Stream API >

[GitHub] [maven] asfgit merged pull request #702: [MNG-7447] - Several Improvements by using Stream API

2022-04-05 Thread GitBox
asfgit merged PR #702: URL: https://github.com/apache/maven/pull/702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (SUREFIRE-1651) JUnit5 Vintage + Maven-Failsafe + Category = ???

2022-04-05 Thread Reuben Sivan (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517650#comment-17517650 ] Reuben Sivan commented on SUREFIRE-1651: On further inspection, there is a problem with

[GitHub] [maven-deploy-plugin] plotters opened a new pull request, #21: [doc] improve site documentation deploy-ssh-external example

2022-04-05 Thread GitBox
plotters opened a new pull request, #21: URL: https://github.com/apache/maven-deploy-plugin/pull/21 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPH) filed

[GitHub] [maven-invoker] slawekjaranowski merged pull request #48: Add Release Drafter to project

2022-04-05 Thread GitBox
slawekjaranowski merged PR #48: URL: https://github.com/apache/maven-invoker/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-invoker] slawekjaranowski opened a new pull request, #48: Add Release Drafter to project

2022-04-05 Thread GitBox
slawekjaranowski opened a new pull request, #48: URL: https://github.com/apache/maven-invoker/pull/48 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/MSHARED)

[jira] [Created] (MCLEAN-102) Fast is slower on windows with many cores

2022-04-05 Thread Delany (Jira)
Delany created MCLEAN-102: - Summary: Fast is slower on windows with many cores Key: MCLEAN-102 URL: https://issues.apache.org/jira/browse/MCLEAN-102 Project: Maven Clean Plugin Issue Type: Bug

[GitHub] [maven] mthmulders commented on a diff in pull request #697: [MNG-7360] Fix xml transformation to ensure proper context

2022-04-05 Thread GitBox
mthmulders commented on code in PR #697: URL: https://github.com/apache/maven/pull/697#discussion_r842727086 ## maven-model-transform/src/main/java/org/apache/maven/model/transform/pull/NodeBufferingParser.java: ## @@ -38,44 +37,54 @@ private final List buffer = new

[jira] [Commented] (MRELEASE-1079) scm tag is added to child module

2022-04-05 Thread Jira
[ https://issues.apache.org/jira/browse/MRELEASE-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517392#comment-17517392 ] Markus Schäfer commented on MRELEASE-1079: -- Yes, we use git as vcs. I've forked the

[jira] [Commented] (MRELEASE-1079) scm tag is added to child module

2022-04-05 Thread Karl Heinz Marbaise (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517384#comment-17517384 ] Karl Heinz Marbaise commented on MRELEASE-1079: --- Do you have an example project to

[jira] [Created] (SUREFIRE-2058) Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging

2022-04-05 Thread Zoltan Meze (Jira)
Zoltan Meze created SUREFIRE-2058: - Summary: Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging Key: SUREFIRE-2058 URL:

[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #507: [SUREFIRE-2044] Upgrade Maven Verifier to 1.8.0

2022-04-05 Thread GitBox
slawekjaranowski commented on code in PR #507: URL: https://github.com/apache/maven-surefire/pull/507#discussion_r842466292 ## surefire-its/src/test/java/org/apache/maven/surefire/its/fixture/MavenLauncher.java: ## @@ -186,9 +186,9 @@ public MavenLauncher addEnvVar( String key,

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #161: [MRESOLVER-248] Make BF and DF collectors coexists

2022-04-05 Thread GitBox
cstamas commented on code in PR #161: URL: https://github.com/apache/maven-resolver/pull/161#discussion_r842419539 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyGraphTransformationContext.java: ## @@ -28,15 +28,15 @@ /** */

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #161: [MRESOLVER-248] Make BF and DF collectors coexists

2022-04-05 Thread GitBox
cstamas commented on code in PR #161: URL: https://github.com/apache/maven-resolver/pull/161#discussion_r842416268 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/bf/BfProcessingContext.java: ## @@ -29,7 +29,7 @@ import

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #161: [MRESOLVER-248] Make BF and DF collectors coexists

2022-04-05 Thread GitBox
cstamas commented on code in PR #161: URL: https://github.com/apache/maven-resolver/pull/161#discussion_r842415939 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DependencyCollectorDelegate.java: ## @@ -0,0 +1,96 @@ +package

[GitHub] [maven-surefire] yrodiere commented on pull request #506: SUREFIRE-2056 BufferOverflowException when encoding message with null testId

2022-04-05 Thread GitBox
yrodiere commented on PR #506: URL: https://github.com/apache/maven-surefire/pull/506#issuecomment-1088329572 @Tibor17 I would have, but the bug only occurs the message is an empty string, unlike the existing test, and I assumed this would be too big of a change? Not testing the nominal

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #161: [MRESOLVER-248] Make BF and DF collectors coexists

2022-04-05 Thread GitBox
cstamas commented on code in PR #161: URL: https://github.com/apache/maven-resolver/pull/161#discussion_r842415793 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCycle.java: ## @@ -30,17 +30,16 @@ import

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #161: [MRESOLVER-248] Make BF and DF collectors coexists

2022-04-05 Thread GitBox
cstamas commented on code in PR #161: URL: https://github.com/apache/maven-resolver/pull/161#discussion_r842415618 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DataPool.java: ## @@ -49,7 +49,7 @@ /** */ -final class DataPool +public final

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #161: [MRESOLVER-248] Make BF and DF collectors coexists

2022-04-05 Thread GitBox
cstamas commented on code in PR #161: URL: https://github.com/apache/maven-resolver/pull/161#discussion_r842415466 ## maven-resolver-impl/src/main/java/org/eclipse/aether/impl/guice/AetherModule.java: ## @@ -212,6 +221,19 @@ protected void configure() } +@Provides

[GitHub] [maven-resolver] cstamas commented on pull request #161: [MRESOLVER-248] Make BF and DF collectors coexists

2022-04-05 Thread GitBox
cstamas commented on PR #161: URL: https://github.com/apache/maven-resolver/pull/161#issuecomment-1088318575 General remark: the convention to name package as "internal" or "impl" should automatically imply this is INTERNAL thing (AFAIK, some OSGi tooling and Takari life-cycle even enforce

[jira] [Commented] (MSHADE-160) change default location of dependency-reduced-pom.xml

2022-04-05 Thread James Z.M. Gao (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517235#comment-17517235 ] James Z.M. Gao commented on MSHADE-160: --- as [~rfscholte] suggest, a new