[GitHub] [maven-jarsigner-plugin] jrivard commented on pull request #2: Mark verify and sign Mojos thread safe

2022-06-22 Thread GitBox
jrivard commented on PR #2: URL: https://github.com/apache/maven-jarsigner-plugin/pull/2#issuecomment-1164011163 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [maven-install-plugin] slachiewicz commented on pull request #31: [MINSTALL-175] Drop MAT

2022-06-22 Thread GitBox
slachiewicz commented on PR #31: URL: https://github.com/apache/maven-install-plugin/pull/31#issuecomment-1163920536 @cstamas idea was to save us time and with few lines of code - drop m-a-t-p -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (MSHARED-944) Set minimum Maven version to 3.1.1

2022-06-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557799#comment-17557799 ] ASF GitHub Bot commented on MSHARED-944: olamy commented on PR #20: URL: https:

[GitHub] [maven-artifact-transfer] olamy commented on pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1

2022-06-22 Thread GitBox
olamy commented on PR #20: URL: https://github.com/apache/maven-artifact-transfer/pull/20#issuecomment-1163917147 was a good idea to get RID of old dependencies until we go away correctly from org.eclipse package. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [maven-install-plugin] olamy commented on pull request #31: [MINSTALL-175] Drop MAT

2022-06-22 Thread GitBox
olamy commented on PR #31: URL: https://github.com/apache/maven-install-plugin/pull/31#issuecomment-1163916642 > [apache/maven-artifact-transfer#20](https://github.com/apache/maven-artifact-transfer/pull/20) almost 2 years later maybe it's now finally a good move to do I would

[GitHub] [maven-install-plugin] slachiewicz commented on pull request #31: [MINSTALL-175] Drop MAT

2022-06-22 Thread GitBox
slachiewicz commented on PR #31: URL: https://github.com/apache/maven-install-plugin/pull/31#issuecomment-1163913451 https://github.com/apache/maven-artifact-transfer/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [maven-integration-testing] olamy merged pull request #25: Importing a BOM works even when it has the same components in dep mgmt

2022-06-22 Thread GitBox
olamy merged PR #25: URL: https://github.com/apache/maven-integration-testing/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [maven-install-plugin] olamy commented on pull request #31: [MINSTALL-175] Drop MAT

2022-06-22 Thread GitBox
olamy commented on PR #31: URL: https://github.com/apache/maven-install-plugin/pull/31#issuecomment-1163833952 > Let's imagine that we change package to o.a.m for resolver. It's like change like jakarta from javax. How this will look like? If we just change it, all old plugins will be brok

[GitHub] [maven] naveensrinivasan opened a new pull request, #760: chore: Set permissions for GitHub actions

2022-06-22 Thread GitBox
naveensrinivasan opened a new pull request, #760: URL: https://github.com/apache/maven/pull/760 Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much. - Included perm

[GitHub] [maven-wrapper] luschmar commented on pull request #51: [MWRAPPER-68] fix issue with MVNW_REPOURL path resolving

2022-06-22 Thread GitBox
luschmar commented on PR #51: URL: https://github.com/apache/maven-wrapper/pull/51#issuecomment-1163613927 @jorsol @slawekjaranowski any new input for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Commented] (MWRAPPER-68) MVNW_REPOURL improperly formed distributionUrl

2022-06-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557711#comment-17557711 ] ASF GitHub Bot commented on MWRAPPER-68: luschmar commented on PR #51: URL: http

[jira] [Commented] (DOXIA-536) AptParser does not force linebreak in Sink after a comment is written

2022-06-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557690#comment-17557690 ] Michael Osipov commented on DOXIA-536: -- [~hboutemy], ping again. > AptParser does no

[GitHub] [maven-resolver] cstamas commented on pull request #185: Add some TLP doco about shared local repo access

2022-06-22 Thread GitBox
cstamas commented on PR #185: URL: https://github.com/apache/maven-resolver/pull/185#issuecomment-1163487452 https://maven.apache.org/resolver-archives/resolver-LATEST/local-repository.html -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Comment Edited] (MRESOLVER-264) Make file-lock the default locking

2022-06-22 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557612#comment-17557612 ] Tamás Cservenák edited comment on MRESOLVER-264 at 6/22/22 6:43 PM:

[jira] [Comment Edited] (MRESOLVER-264) Make file-lock the default locking

2022-06-22 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557612#comment-17557612 ] Tamás Cservenák edited comment on MRESOLVER-264 at 6/22/22 6:39 PM:

[jira] [Commented] (MRESOLVER-264) Make file-lock the default locking

2022-06-22 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557612#comment-17557612 ] Tamás Cservenák commented on MRESOLVER-264: --- Well, I bet very few people wor

[jira] [Commented] (MRESOLVER-264) Make file-lock the default locking

2022-06-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557609#comment-17557609 ] Michael Osipov commented on MRESOLVER-264: -- I completely veto that: * It is n

[GitHub] [maven-integration-testing] jglick commented on pull request #25: Importing a BOM works even when it has the same components in dep mgmt

2022-06-22 Thread GitBox
jglick commented on PR #25: URL: https://github.com/apache/maven-integration-testing/pull/25#issuecomment-1163457199 ``` 2022-06-22T18:08:34.5840918Z 0199 CyclicImportScope.it0199().. OK (2.2 s) ``` -- This is an automated message from the Apache Git Ser

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #185: Add some TLP doco about shared local repo access

2022-06-22 Thread GitBox
cstamas commented on code in PR #185: URL: https://github.com/apache/maven-resolver/pull/185#discussion_r904095056 ## maven-resolver-named-locks/src/site/markdown/index.md.vm: ## @@ -52,8 +56,7 @@ Finally, "distributed" named lock implementations are the following (separate mo

[GitHub] [maven-resolver] kwin commented on a diff in pull request #185: Add some TLP doco about shared local repo access

2022-06-22 Thread GitBox
kwin commented on code in PR #185: URL: https://github.com/apache/maven-resolver/pull/185#discussion_r904088244 ## maven-resolver-named-locks/src/site/markdown/index.md.vm: ## @@ -52,8 +56,7 @@ Finally, "distributed" named lock implementations are the following (separate mo -

[GitHub] [maven-resolver] kwin commented on a diff in pull request #185: Add some TLP doco about shared local repo access

2022-06-22 Thread GitBox
kwin commented on code in PR #185: URL: https://github.com/apache/maven-resolver/pull/185#discussion_r904088244 ## maven-resolver-named-locks/src/site/markdown/index.md.vm: ## @@ -52,8 +56,7 @@ Finally, "distributed" named lock implementations are the following (separate mo -

[GitHub] [maven-resolver] cstamas commented on pull request #184: Clarify `file-lock` being a distributed name lock

2022-06-22 Thread GitBox
cstamas commented on PR #184: URL: https://github.com/apache/maven-resolver/pull/184#issuecomment-1163441806 Superseded by https://github.com/apache/maven-resolver/pull/185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [maven-resolver] cstamas closed pull request #184: Clarify `file-lock` being a distributed name lock

2022-06-22 Thread GitBox
cstamas closed pull request #184: Clarify `file-lock` being a distributed name lock URL: https://github.com/apache/maven-resolver/pull/184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-resolver] kwin commented on pull request #185: Add some TLP doco about shared local repo access

2022-06-22 Thread GitBox
kwin commented on PR #185: URL: https://github.com/apache/maven-resolver/pull/185#issuecomment-1163425146 Thanks looks good to me, can you also update https://maven.apache.org/resolver/maven-resolver-named-locks/index.html in this PR based on #184 as I think you guys know best how to clarif

[jira] [Updated] (MRESOLVER-264) Make file-lock the default locking

2022-06-22 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MRESOLVER-264: -- Description: Default locking in Resolver is RW locks, that is only in-JVM (so covers

[jira] [Created] (MRESOLVER-264) Make file-lock the default locking

2022-06-22 Thread Jira
Tamás Cservenák created MRESOLVER-264: - Summary: Make file-lock the default locking Key: MRESOLVER-264 URL: https://issues.apache.org/jira/browse/MRESOLVER-264 Project: Maven Resolver Iss

[GitHub] [maven-resolver] cstamas commented on pull request #185: Add some TLP doco about shared local repo access

2022-06-22 Thread GitBox
cstamas commented on PR #185: URL: https://github.com/apache/maven-resolver/pull/185#issuecomment-1163418698 @kwin ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [maven-resolver] cstamas opened a new pull request, #185: Add some TLP doco about shared local repo access

2022-06-22 Thread GitBox
cstamas opened a new pull request, #185: URL: https://github.com/apache/maven-resolver/pull/185 Add short intro to page available from TLP, not buried in some module... Inspired by https://github.com/apache/maven-resolver/pull/184 -- This is an automated message from the Apache Git

[GitHub] [maven-resolver] michael-o commented on pull request #184: Clarify `file-lock` being a distributed name lock

2022-06-22 Thread GitBox
michael-o commented on PR #184: URL: https://github.com/apache/maven-resolver/pull/184#issuecomment-1163392688 This should also go to the docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-resolver] cstamas commented on pull request #184: Clarify `file-lock` being a distributed name lock

2022-06-22 Thread GitBox
cstamas commented on PR #184: URL: https://github.com/apache/maven-resolver/pull/184#issuecomment-1163386314 In short: if your FS correctly support locking, should work. Local FS usually is okay. For NFS your mileage may vary. -- This is an automated message from the Apache Git Service. T

[GitHub] [maven-resolver] michael-o commented on pull request #184: Clarify `file-lock` being a distributed name lock

2022-06-22 Thread GitBox
michael-o commented on PR #184: URL: https://github.com/apache/maven-resolver/pull/184#issuecomment-1163384643 > That was my thought as well: only NFSv4 w/ all the services needed (so not "bare" nfs server, but all rpc and whistles and bells needed) Correct, no blanket v4. -- This

[GitHub] [maven-resolver] cstamas commented on pull request #184: Clarify `file-lock` being a distributed name lock

2022-06-22 Thread GitBox
cstamas commented on PR #184: URL: https://github.com/apache/maven-resolver/pull/184#issuecomment-1163382488 That was my thought as well: only NFSv4 w/ all the services needed (so not "bare" nfs server, but all rpc and whistles and bells needed) -- This is an automated message from the Ap

[GitHub] [maven-resolver] michael-o commented on pull request #184: Clarify `file-lock` being a distributed name lock

2022-06-22 Thread GitBox
michael-o commented on PR #184: URL: https://github.com/apache/maven-resolver/pull/184#issuecomment-1163381694 Ceph and friends, no idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [maven-resolver] michael-o commented on pull request #184: Clarify `file-lock` being a distributed name lock

2022-06-22 Thread GitBox
michael-o commented on PR #184: URL: https://github.com/apache/maven-resolver/pull/184#issuecomment-1163380917 Looking at https://www.freebsd.org/cgi/man.cgi?query=nfsv4&sektion=4&manpath=FreeBSD+9.0-RELEASE NFSv4 has advisory locks. Forget 3 or older. Now there many impls of it and I don'

[GitHub] [maven-build-cache-extension] kwin opened a new pull request, #22: fix link

2022-06-22 Thread GitBox
kwin opened a new pull request, #22: URL: https://github.com/apache/maven-build-cache-extension/pull/22 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed

[GitHub] [maven-resolver] cstamas commented on pull request #184: Clarify `file-lock` being a distributed name lock

2022-06-22 Thread GitBox
cstamas commented on PR #184: URL: https://github.com/apache/maven-resolver/pull/184#issuecomment-1163245207 Unsure about NFS file locking... @michael-o ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [maven-resolver] kwin commented on pull request #184: Clarify `file-lock` being a distributed name lock

2022-06-22 Thread GitBox
kwin commented on PR #184: URL: https://github.com/apache/maven-resolver/pull/184#issuecomment-1163238802 Why is it not MH if you have e.g. a NFS network share mounted? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [maven-resolver] cstamas commented on pull request #184: Clarify `file-lock` being a distributed name lock

2022-06-22 Thread GitBox
cstamas commented on PR #184: URL: https://github.com/apache/maven-resolver/pull/184#issuecomment-1163236669 Well, it is not "distributed" as is not for multi hosts case. I'd rather distinguish like ST, MT, MP and MH (single thread, multi thread, multi process/single-host and multi-host).

[jira] [Updated] (MGPG-87) NullPointerException when gpg setup in .m2/settings.xml not set up properly

2022-06-22 Thread Dave Wichers (Jira)
[ https://issues.apache.org/jira/browse/MGPG-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Wichers updated MGPG-87: - Affects Version/s: 3.0.1 > NullPointerException when gpg setup in .m2/settings.xml not set up properly > ---

[jira] [Created] (MGPG-87) NullPointerException when gpg setup in .m2/settings.xml not set up properly

2022-06-22 Thread Dave Wichers (Jira)
Dave Wichers created MGPG-87: Summary: NullPointerException when gpg setup in .m2/settings.xml not set up properly Key: MGPG-87 URL: https://issues.apache.org/jira/browse/MGPG-87 Project: Maven GPG Plugin

[jira] [Commented] (MSHARED-1067) Improve Reproducible Builds methods

2022-06-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557487#comment-17557487 ] Hudson commented on MSHARED-1067: - Build succeeded in Jenkins: Maven » Maven TLP » mave

[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557486#comment-17557486 ] Hudson commented on MSHARED-1066: - Build succeeded in Jenkins: Maven » Maven TLP » mave

[jira] [Closed] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSHARED-1066. --- Resolution: Fixed Fixed with [cd79d3959afce50e90b3bcc5cd7d7b88aee98df6|https://gitbox.apac

[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557483#comment-17557483 ] ASF GitHub Bot commented on MSHARED-1066: - asfgit merged PR #22: URL: https://g

[jira] [Closed] (MSHARED-1067) Improve Reproducible Builds methods

2022-06-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSHARED-1067. --- Resolution: Fixed Fixed with [03153b544edebeed2d11d8b7a135337394d97205|https://gitbox.apac

[GitHub] [maven-archiver] asfgit merged pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods

2022-06-22 Thread GitBox
asfgit merged PR #22: URL: https://github.com/apache/maven-archiver/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apa

[jira] [Updated] (MSHARED-1067) Improve Reproducible Builds methods

2022-06-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSHARED-1067: Summary: Improve Reproducible Builds methods (was: Improve the Reproducible Builds metho

[GitHub] [maven-resolver] cstamas commented on pull request #183: Example of using japicmp to ensure binary API compatibility

2022-06-22 Thread GitBox
cstamas commented on PR #183: URL: https://github.com/apache/maven-resolver/pull/183#issuecomment-1163161846 https://github.com/siom79/japicmp/pull/326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Closed] (MSHARED-955) Make MavenArchiver.parseOutputTimestamp static

2022-06-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSHARED-955. -- Fix Version/s: (was: maven-archiver-3.6.0) Resolution: Won't Do > Make MavenArchive

[jira] [Assigned] (MSHARED-1067) Improve the Reproducible Builds methods in Maven-Archiver

2022-06-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MSHARED-1067: --- Assignee: Michael Osipov > Improve the Reproducible Builds methods in Maven-Archiv

[jira] [Assigned] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MSHARED-1066: --- Assignee: Michael Osipov > Upgrade Plexus Archiver to 4.3.0 >

[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557448#comment-17557448 ] ASF GitHub Bot commented on MSHARED-1066: - michael-o commented on PR #22: URL:

[GitHub] [maven-archiver] michael-o commented on pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods

2022-06-22 Thread GitBox
michael-o commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1163090024 I will assign issues in JIRA to me and handle this PR. Muchas gracias por tu ayuda! -- This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557446#comment-17557446 ] ASF GitHub Bot commented on MSHARED-1066: - michael-o commented on PR #22: URL:

[GitHub] [maven-archiver] michael-o commented on pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods

2022-06-22 Thread GitBox
michael-o commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1163087875 Here it is: ``` osipovmi@deblndw011x:~/var/Projekte/maven-source-plugin (master *=) $ ~/.local/bin/diffoscope /tmp/reproducible-1.0-sources.jar ./target/it/reproducible/targe

[GitHub] [maven-resolver] cstamas opened a new pull request, #183: Example of using japicmp to ensure binary API compatibility

2022-06-22 Thread GitBox
cstamas opened a new pull request, #183: URL: https://github.com/apache/maven-resolver/pull/183 This now fails when building, as 1.8.x breaks vs 1.6.3 (and is ok, this is merely a "demo" that we should integrate) -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557444#comment-17557444 ] ASF GitHub Bot commented on MSHARED-1066: - michael-o commented on PR #22: URL:

[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557443#comment-17557443 ] ASF GitHub Bot commented on MSHARED-1066: - michael-o commented on PR #22: URL:

[GitHub] [maven-archiver] michael-o commented on pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods

2022-06-22 Thread GitBox
michael-o commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1163082079 I will use diffoscope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [maven-archiver] michael-o commented on pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods

2022-06-22 Thread GitBox
michael-o commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1163081959 > > > I can confirm that maven-source-plugin passes from master, but not this PR. > > The IT from `maven-source-plugin` uses a sha1 checksum (which does not ne

[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557441#comment-17557441 ] ASF GitHub Bot commented on MSHARED-1066: - jorsol commented on PR #22: URL: htt

[GitHub] [maven-archiver] jorsol commented on pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods

2022-06-22 Thread GitBox
jorsol commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1163074940 > I can confirm that maven-source-plugin passes from master, but not this PR. The IT from `maven-source-plugin` uses a sha1 checksum (which does not necessarily test that is repro

[jira] [Updated] (SUREFIRE-2104) user.language and user.region in systemPropertyVariables don't set default locale

2022-06-22 Thread Krzysztof Sobolewski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Sobolewski updated SUREFIRE-2104: --- Affects Version/s: 3.0.0-M7 (was: 3.0.0-M5) > u

[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557424#comment-17557424 ] ASF GitHub Bot commented on MSHARED-1066: - michael-o commented on PR #22: URL:

[GitHub] [maven-archiver] michael-o commented on pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods

2022-06-22 Thread GitBox
michael-o commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1163045228 I can confirm that maven-source-plugin passes from master, but not this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (SUREFIRE-2104) user.language and user.region in systemPropertyVariables don't set default locale

2022-06-22 Thread Krzysztof Sobolewski (Jira)
Krzysztof Sobolewski created SUREFIRE-2104: -- Summary: user.language and user.region in systemPropertyVariables don't set default locale Key: SUREFIRE-2104 URL: https://issues.apache.org/jira/browse/SUREFI

[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557421#comment-17557421 ] ASF GitHub Bot commented on MSHARED-1066: - michael-o commented on PR #22: URL:

[GitHub] [maven-archiver] michael-o commented on pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods

2022-06-22 Thread GitBox
michael-o commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1163039282 > > Please have a look (maven-javadoc-plugin): > > The `maven-javadoc-plugin` declares the `plexus-archiver` dependency, so it needs to be updated to 4.3.0 (or removed to be us

[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557412#comment-17557412 ] ASF GitHub Bot commented on MSHARED-1066: - michael-o commented on PR #22: URL:

[GitHub] [maven-archiver] michael-o commented on pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods

2022-06-22 Thread GitBox
michael-o commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1163025729 Users: https://github.com/search?q=org%3Aapache+maven-archiver+path%3A%2F+language%3A%22Maven+POM%22+language%3A%22Maven+POM%22&type=Code&ref=advsearch&l=Maven+POM&l=Maven+POM -- T

[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557411#comment-17557411 ] ASF GitHub Bot commented on MSHARED-1066: - jorsol commented on PR #22: URL: htt

[GitHub] [maven-archiver] jorsol commented on pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods

2022-06-22 Thread GitBox
jorsol commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1163024977 > Please have a look (maven-javadoc-plugin): The `maven-javadoc-plugin` declares the `plexus-archiver` dependency, so it needs to be updated to 4.3.0 (or removed to be used transi

[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557408#comment-17557408 ] ASF GitHub Bot commented on MSHARED-1066: - michael-o commented on PR #22: URL:

[GitHub] [maven-archiver] michael-o commented on pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods

2022-06-22 Thread GitBox
michael-o commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1163021605 Please have a look (maven-source-plugin): ``` [INFO] Building: reproducible/pom.xml [INFO] run post-build script verify.groovy [INFO] The post-build script did not succee

[jira] [Commented] (MENFORCER-417) requireUpperBoundDeps doesn't work when dependencies are managed

2022-06-22 Thread James Howe (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557401#comment-17557401 ] James Howe commented on MENFORCER-417: -- I found the cause, and I think it's not a

[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557384#comment-17557384 ] ASF GitHub Bot commented on MSHARED-1066: - michael-o commented on PR #22: URL:

[GitHub] [maven-archiver] michael-o commented on pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods

2022-06-22 Thread GitBox
michael-o commented on PR #22: URL: https://github.com/apache/maven-archiver/pull/22#issuecomment-1162979430 Except for the remaining comments this looks good. I will run this snapshot against MJAR, MWAR, and likely other projects just to make sure. -- This is an automated message from th

[jira] [Updated] (MENFORCER-417) requireUpperBoundDeps doesn't work when dependencies are managed

2022-06-22 Thread James Howe (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Howe updated MENFORCER-417: - Affects Version/s: 3.1.0 > requireUpperBoundDeps doesn't work when dependencies are managed >

[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557382#comment-17557382 ] ASF GitHub Bot commented on MSHARED-1066: - michael-o commented on code in PR #2

[GitHub] [maven-archiver] michael-o commented on a diff in pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods

2022-06-22 Thread GitBox
michael-o commented on code in PR #22: URL: https://github.com/apache/maven-archiver/pull/22#discussion_r903614719 ## src/main/java/org/apache/maven/archiver/MavenArchiver.java: ## @@ -812,28 +820,80 @@ public void setBuildJdkSpecDefaultEntry( boolean buildJdkSpecDefaultEntry )

[jira] [Commented] (MNG-7417) Several classes do not set properties properly for building requests

2022-06-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557363#comment-17557363 ] Michael Osipov commented on MNG-7417: - [~chesnay], I would recommend to open a separate

[jira] [Commented] (MNG-7417) Several classes do not set properties properly for building requests

2022-06-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/MNG-7417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557355#comment-17557355 ] Chesnay Schepler commented on MNG-7417: --- FYI, this change broke something in our proj

[jira] [Commented] (MSITE-904) Unable to generate zh_TW locale of site document

2022-06-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557346#comment-17557346 ] Michael Osipov commented on MSITE-904: -- That is a tag, not a branch. M is milestone =

[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557340#comment-17557340 ] ASF GitHub Bot commented on MSHARED-1066: - michael-o commented on code in PR #2

[GitHub] [maven-archiver] michael-o commented on a diff in pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods

2022-06-22 Thread GitBox
michael-o commented on code in PR #22: URL: https://github.com/apache/maven-archiver/pull/22#discussion_r903528625 ## src/main/java/org/apache/maven/archiver/MavenArchiver.java: ## @@ -812,28 +820,78 @@ public void setBuildJdkSpecDefaultEntry( boolean buildJdkSpecDefaultEntry )

[GitHub] [maven-archiver] cstamas commented on pull request #25: Update Plexus IO and Archiver

2022-06-22 Thread GitBox
cstamas commented on PR #25: URL: https://github.com/apache/maven-archiver/pull/25#issuecomment-1162869638 Agreed, but my PR does not want to mess with rel mgr job 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557328#comment-17557328 ] ASF GitHub Bot commented on MSHARED-1066: - michael-o commented on code in PR #2

[GitHub] [maven-archiver] michael-o commented on a diff in pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods

2022-06-22 Thread GitBox
michael-o commented on code in PR #22: URL: https://github.com/apache/maven-archiver/pull/22#discussion_r903487556 ## src/main/java/org/apache/maven/archiver/MavenArchiver.java: ## @@ -97,6 +101,10 @@ "${artifact.groupIdPath}/${artifact.artifactId}/" + "${artifact.base

[jira] [Commented] (MSHARED-1066) Upgrade Plexus Archiver to 4.3.0

2022-06-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557326#comment-17557326 ] ASF GitHub Bot commented on MSHARED-1066: - michael-o commented on code in PR #2

[jira] [Commented] (MSITE-904) Unable to generate zh_TW locale of site document

2022-06-22 Thread Will (Jira)
[ https://issues.apache.org/jira/browse/MSITE-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557325#comment-17557325 ] Will commented on MSITE-904: May I ask what's the *[maven-site-plugin-4.0.0-M1|https://github

[GitHub] [maven-archiver] michael-o commented on a diff in pull request #22: [MSHARED-1066] - Upgrade Plexus Archiver to 4.3.0, Improve the Reproducible Builds methods

2022-06-22 Thread GitBox
michael-o commented on code in PR #22: URL: https://github.com/apache/maven-archiver/pull/22#discussion_r903484876 ## src/main/java/org/apache/maven/archiver/MavenArchiver.java: ## @@ -812,28 +820,78 @@ public void setBuildJdkSpecDefaultEntry( boolean buildJdkSpecDefaultEntry )

[GitHub] [maven-archiver] cstamas opened a new pull request, #25: Update Plexus IO and Archiver

2022-06-22 Thread GitBox
cstamas opened a new pull request, #25: URL: https://github.com/apache/maven-archiver/pull/25 Once they are released. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Updated] (MSITE-904) Unable to generate zh_TW locale of site document

2022-06-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSITE-904: - Fix Version/s: 4.0.0-candidate > Unable to generate zh_TW locale of site document > --

[jira] [Updated] (MSITE-820) change localized output from language to full locale, like source

2022-06-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSITE-820: - Fix Version/s: 4.0.0-candidate (was: backlog) > change localized output fro

[jira] [Updated] (MSITE-827) Site builds rely on HTTP 404

2022-06-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSITE-827: - Fix Version/s: 4.0.0-candidate > Site builds rely on HTTP 404 > > >

[jira] [Commented] (MSITE-671) Regression: site:stage no longer functions for MM projects.

2022-06-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557315#comment-17557315 ] Michael Osipov commented on MSITE-671: -- Still waiting for an answer... > Regression:

[jira] [Commented] (MSITE-904) Unable to generate zh_TW locale of site document

2022-06-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557311#comment-17557311 ] Michael Osipov commented on MSITE-904: -- No, I guess sometime this year. I am the only