[jira] [Commented] (MWRAPPER-77) wrapper:wrapper does not update scripts

2022-09-05 Thread Jira
[ https://issues.apache.org/jira/browse/MWRAPPER-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600600#comment-17600600 ] Tamás Cservenák commented on MWRAPPER-77: - This was UnArchiver bug, hence, once

[GitHub] [maven-invoker] dependabot[bot] opened a new pull request, #53: Bump maven-pmd-plugin from 3.18.0 to 3.19.0

2022-09-05 Thread GitBox
dependabot[bot] opened a new pull request, #53: URL: https://github.com/apache/maven-invoker/pull/53 Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.18.0 to 3.19.0. Release notes Sourced from https://github.com/apache/maven-pmd-plugin/releases";>maven-pm

[GitHub] [maven-parent] dependabot[bot] closed pull request #77: Bump maven-pmd-plugin from 3.17.0 to 3.18.0

2022-09-05 Thread GitBox
dependabot[bot] closed pull request #77: Bump maven-pmd-plugin from 3.17.0 to 3.18.0 URL: https://github.com/apache/maven-parent/pull/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-parent] dependabot[bot] commented on pull request #77: Bump maven-pmd-plugin from 3.17.0 to 3.18.0

2022-09-05 Thread GitBox
dependabot[bot] commented on PR #77: URL: https://github.com/apache/maven-parent/pull/77#issuecomment-1237632565 Superseded by #78. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [maven-parent] dependabot[bot] opened a new pull request, #78: Bump maven-pmd-plugin from 3.17.0 to 3.19.0

2022-09-05 Thread GitBox
dependabot[bot] opened a new pull request, #78: URL: https://github.com/apache/maven-parent/pull/78 Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.17.0 to 3.19.0. Release notes Sourced from https://github.com/apache/maven-pmd-plugin/releases";>maven-pmd

[jira] [Updated] (MSHARED-1075) Upgrade Parent to 36

2022-09-05 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MSHARED-1075: - Fix Version/s: maven-verifier-2.0.0 (was: maven-verifier-

[jira] [Commented] (MNG-7532) Revert MNG-6931 deprecation since list shows no consensus on that

2022-09-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600514#comment-17600514 ] ASF GitHub Bot commented on MNG-7532: - rmannibucau commented on PR #793: URL: https://g

[GitHub] [maven] rmannibucau commented on pull request #793: [MNG-7532] Log shouldn't have been deprecated so ensure it is not

2022-09-05 Thread GitBox
rmannibucau commented on PR #793: URL: https://github.com/apache/maven/pull/793#issuecomment-1237402830 @slachiewicz there are some discussions about the related pages since there was never a consensus nor a consistent update of that on our website. Short term goal of that pr was to avoid

[jira] [Commented] (MNG-7532) Revert MNG-6931 deprecation since list shows no consensus on that

2022-09-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600503#comment-17600503 ] ASF GitHub Bot commented on MNG-7532: - slachiewicz commented on PR #793: URL: https://g

[GitHub] [maven] slachiewicz commented on pull request #793: [MNG-7532] Log shouldn't have been deprecated so ensure it is not

2022-09-05 Thread GitBox
slachiewicz commented on PR #793: URL: https://github.com/apache/maven/pull/793#issuecomment-1237364037 it's incomplete - we would also update maven site and say that slf4j introduced for logging in 3.1 is now obsolete? -- This is an automated message from the Apache Git Service. To respo

[GitHub] [maven-shade-plugin] slawekjaranowski commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

2022-09-05 Thread GitBox
slawekjaranowski commented on PR #150: URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1237182567 m-pmd-p -> maven-pmd-plugin 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-shade-plugin] tisonkun commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

2022-09-05 Thread GitBox
tisonkun commented on PR #150: URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1237143519 Thanks! I'm subscribing d...@maven.apache.org mailing list now. > m-pmd-p Out of curiosity, what does this stand for? -- This is an automated message from the Ap

[GitHub] [maven-shade-plugin] slawekjaranowski commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

2022-09-05 Thread GitBox
slawekjaranowski commented on PR #150: URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1237138580 if you wish we can discuss on dev list look last pending release of m-pmd-p -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven] cstamas commented on pull request #703: New API with immutable model

2022-09-05 Thread GitBox
cstamas commented on PR #703: URL: https://github.com/apache/maven/pull/703#issuecomment-1237122245 :+1: as well, will take a deeper look tonight... but that should not block anything -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [maven] slawekjaranowski commented on pull request #703: New API with immutable model

2022-09-05 Thread GitBox
slawekjaranowski commented on PR #703: URL: https://github.com/apache/maven/pull/703#issuecomment-1237118848 👍 for merge and for release alpha -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven] gnodet commented on pull request #703: New API with immutable model

2022-09-05 Thread GitBox
gnodet commented on PR #703: URL: https://github.com/apache/maven/pull/703#issuecomment-1237058033 All tests are passing. I'd like to go on and merge this PR (and release an alpha version if possible). This would allow further work on other components and plugins (see the various PRs in t

[GitHub] [maven-shade-plugin] rmannibucau commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

2022-09-05 Thread GitBox
rmannibucau commented on PR #150: URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1237057442 @slawekjaranowski nop, only a PMC can achieve it (for goods) so if a commiter can start it he can't end it so always better to ensure some PMC is there to handle all the nee

[GitHub] [maven-shade-plugin] slawekjaranowski commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

2022-09-05 Thread GitBox
slawekjaranowski commented on PR #150: URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1237031901 drop a line on dev list is good idea @rmannibucau each committer has enough karma/privileges for releases -- This is an automated message from the Apache Git Servi

[GitHub] [maven-shade-plugin] rmannibucau commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

2022-09-05 Thread GitBox
rmannibucau commented on PR #150: URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1237021750 @tisonkun guess a mail on the mailing list can make people more aware of it (at least the ones with the full karma to do it ;)) -- This is an automated message from the Ap

[GitHub] [maven-shade-plugin] tisonkun commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

2022-09-05 Thread GitBox
tisonkun commented on PR #150: URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236968426 @rmannibucau @slawekjaranowski I may a bit in a hurry but I'd like to know whether/when we can have a release for this fix. It resolves one or several downstream use case and I

[jira] [Commented] (MSHADE-416) Jenkins URL is wrong.

2022-09-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600358#comment-17600358 ] Hudson commented on MSHADE-416: --- Build succeeded in Jenkins: Maven » Maven TLP » maven-shad

[jira] [Closed] (MSHADE-416) Jenkins URL is wrong.

2022-09-05 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHADE-416. -- Assignee: Slawomir Jaranowski Resolution: Fixed > Jenkins URL is wrong. > ---

[GitHub] [maven-shade-plugin] slawekjaranowski merged pull request #152: [MSHADE-416] Fix Jenkins URL

2022-09-05 Thread GitBox
slawekjaranowski merged PR #152: URL: https://github.com/apache/maven-shade-plugin/pull/152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [maven-shade-plugin] slawekjaranowski opened a new pull request, #152: [MSHADE-416] Fix Jenkins URL

2022-09-05 Thread GitBox
slawekjaranowski opened a new pull request, #152: URL: https://github.com/apache/maven-shade-plugin/pull/152 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHADE)

[GitHub] [maven-shared-utils] jukzi commented on pull request #114: [MSHARED-1122] FileUtils: avoid getCanonicalPath()

2022-09-05 Thread GitBox
jukzi commented on PR #114: URL: https://github.com/apache/maven-shared-utils/pull/114#issuecomment-1236833041 @slawekjaranowski mind to review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Commented] (MSHADE-425) Maven shade plugin build fails without 'clean' goal

2022-09-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600318#comment-17600318 ] Hudson commented on MSHADE-425: --- Build succeeded in Jenkins: Maven » Maven TLP » maven-shad

[jira] [Commented] (MRESOLVER-7) Download dependency POMs in parallel

2022-09-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600315#comment-17600315 ] ASF GitHub Bot commented on MRESOLVER-7: michael-o commented on PR #178: URL: ht

[GitHub] [maven-resolver] michael-o commented on pull request #178: [MRESOLVER-7] download poms in parallel

2022-09-05 Thread GitBox
michael-o commented on PR #178: URL: https://github.com/apache/maven-resolver/pull/178#issuecomment-1236813296 > > Proper evaluation I'd mandatory > > I understand and appreciate all the work you guys have done. If I remember clearly, some integration tests and details were discussed

[jira] [Updated] (MSHADE-425) Maven shade plugin build fails without 'clean' goal

2022-09-05 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MSHADE-425: --- Issue Type: Bug (was: Improvement) > Maven shade plugin build fails without 'clean'

[jira] [Closed] (MSHADE-425) Maven shade plugin build fails without 'clean' goal

2022-09-05 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHADE-425. -- Fix Version/s: 3.4.0 Assignee: Slawomir Jaranowski Resolution: Fixed >

[GitHub] [maven-shade-plugin] slawekjaranowski merged pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

2022-09-05 Thread GitBox
slawekjaranowski merged PR #150: URL: https://github.com/apache/maven-shade-plugin/pull/150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[jira] [Updated] (MSHADE-415) Upgrade maven-plugin parent to 37

2022-09-05 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MSHADE-415: --- Summary: Upgrade maven-plugin parent to 37 (was: Upgrade maven-plugin parent to 35)

[jira] [Commented] (MSHADE-415) Upgrade maven-plugin parent to 37

2022-09-05 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600300#comment-17600300 ] Slawomir Jaranowski commented on MSHADE-415: and https://github.com/apache/ma

[GitHub] [maven-shade-plugin] slawekjaranowski merged pull request #151: Use GHA shared v3

2022-09-05 Thread GitBox
slawekjaranowski merged PR #151: URL: https://github.com/apache/maven-shade-plugin/pull/151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [maven-shade-plugin] dependabot[bot] commented on pull request #146: Bump mavenVersion from 3.1.1 to 3.8.6

2022-09-05 Thread GitBox
dependabot[bot] commented on PR #146: URL: https://github.com/apache/maven-shade-plugin/pull/146#issuecomment-1236764189 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dep

[GitHub] [maven-shade-plugin] slawekjaranowski closed pull request #146: Bump mavenVersion from 3.1.1 to 3.8.6

2022-09-05 Thread GitBox
slawekjaranowski closed pull request #146: Bump mavenVersion from 3.1.1 to 3.8.6 URL: https://github.com/apache/maven-shade-plugin/pull/146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-shade-plugin] tisonkun commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

2022-09-05 Thread GitBox
tisonkun commented on PR #150: URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236749411 Squashed. Though, you can use GitHub "Squash and Commit" button to perform the squash, so that we don't need one more CI turn. -- This is an automated message from the

[GitHub] [maven-shade-plugin] slawekjaranowski commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

2022-09-05 Thread GitBox
slawekjaranowski commented on PR #150: URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236745915 you can squash to one final commit and will be ok for me also. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [maven-shade-plugin] rmannibucau commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

2022-09-05 Thread GitBox
rmannibucau commented on PR #150: URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236740264 @tisonkun on my side I was just waiting for @slawekjaranowski to ack (or merge, no issue) but otherwise no blocker for this pr for me -- This is an automated message from

[GitHub] [maven-shade-plugin] tisonkun commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

2022-09-05 Thread GitBox
tisonkun commented on PR #150: URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236725899 @rmannibucau @slawekjaranowski do we still wait for other conditions to merge this patch? -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [maven-shade-plugin] tisonkun commented on a diff in pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

2022-09-05 Thread GitBox
tisonkun commented on code in PR #150: URL: https://github.com/apache/maven-shade-plugin/pull/150#discussion_r962580071 ## src/test/java/org/apache/maven/plugins/shade/resource/ServiceResourceTransformerTest.java: ## @@ -85,6 +85,49 @@ public void relocatedClasses() throws Excep

[GitHub] [maven-shade-plugin] tisonkun commented on a diff in pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

2022-09-05 Thread GitBox
tisonkun commented on code in PR #150: URL: https://github.com/apache/maven-shade-plugin/pull/150#discussion_r962577433 ## src/test/java/org/apache/maven/plugins/shade/resource/ServiceResourceTransformerTest.java: ## @@ -85,6 +85,49 @@ public void relocatedClasses() throws Excep

[GitHub] [maven-shade-plugin] slawekjaranowski commented on a diff in pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

2022-09-05 Thread GitBox
slawekjaranowski commented on code in PR #150: URL: https://github.com/apache/maven-shade-plugin/pull/150#discussion_r962576368 ## src/test/java/org/apache/maven/plugins/shade/resource/ServiceResourceTransformerTest.java: ## @@ -85,6 +85,49 @@ public void relocatedClasses() thro

[GitHub] [maven-shade-plugin] tisonkun commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

2022-09-05 Thread GitBox
tisonkun commented on PR #150: URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236624546 @slawekjaranowski Added at d29c633cea770ef59464e0b523a938bcd7590c50. Also verify locally that without this patch the test failed. -- This is an automated message from the Apa

[GitHub] [maven-shade-plugin] tisonkun commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

2022-09-05 Thread GitBox
tisonkun commented on PR #150: URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236617125 @slawekjaranowski Yes. I would say this patch is simple enough to be correct. But I'm glad to add some tests to prevent regressions. -- This is an automated message from the

[GitHub] [maven-shade-plugin] slawekjaranowski commented on pull request #150: [MSHADE-425] Relocate services name before add to serviceEntries

2022-09-05 Thread GitBox
slawekjaranowski commented on PR #150: URL: https://github.com/apache/maven-shade-plugin/pull/150#issuecomment-1236612996 There is a https://github.com/apache/maven-shade-plugin/blob/master/src/test/java/org/apache/maven/plugins/shade/resource/ServiceResourceTransformerTest.java mayb