[jira] [Comment Edited] (MRELEASE-839) Unable to supply tag to release for release:perform

[ https://issues.apache.org/jira/browse/MRELEASE-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602581#comment-17602581 ] Edward Lynch-Milner edited comment on MRELEASE-839 at 9/9/22 11:56 PM:

[jira] [Commented] (MRELEASE-839) Unable to supply tag to release for release:perform

[ https://issues.apache.org/jira/browse/MRELEASE-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602581#comment-17602581 ] Edward Lynch-Milner commented on MRELEASE-839: -- *Update:* [~ViliusS]  [~sjaranowski]  I

[GitHub] [maven-scm] JLLeitschuh commented on pull request #162: [SECURITY] Fix Partial Path Traversal Vulnerability

JLLeitschuh commented on PR #162: URL: https://github.com/apache/maven-scm/pull/162#issuecomment-1242417432 > No, we expect report through official ASF channel. Unfortunately, due to the amount of time this takes, this is not possible for me to do across every repository. I created

[GitHub] [maven-scm] michael-o commented on pull request #162: [SECURITY] Fix Partial Path Traversal Vulnerability

michael-o commented on PR #162: URL: https://github.com/apache/maven-scm/pull/162#issuecomment-1242216132 > By closing this PR are you communicating that do the maintainers not consider this a vulnerability for this project? I respect if that's your decision, but I'd like to know your

[GitHub] [maven-scm] JLLeitschuh commented on pull request #162: [SECURITY] Fix Partial Path Traversal Vulnerability

JLLeitschuh commented on PR #162: URL: https://github.com/apache/maven-scm/pull/162#issuecomment-1242181481 By closing this PR are you communicating that do the maintainers not consider this a vulnerability for this project? I respect if that's your decision, but I'd like to know your

[jira] [Commented] (MNGSITE-492) Create maven repository documentation

[ https://issues.apache.org/jira/browse/MNGSITE-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602430#comment-17602430 ] ASF GitHub Bot commented on MNGSITE-492: cstamas commented on code in PR #287: URL:

[GitHub] [maven-site] cstamas commented on a diff in pull request #287: [MNGSITE-492] Maven Repositories documentation

cstamas commented on code in PR #287: URL: https://github.com/apache/maven-site/pull/287#discussion_r967224408 ## content/markdown/repositories/layout.md: ## @@ -0,0 +1,115 @@ +# Maven Repository Layout + + + +The layout is responsible to translate the artifact coordinates into

[jira] [Commented] (MNGSITE-492) Create maven repository documentation

[ https://issues.apache.org/jira/browse/MNGSITE-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602429#comment-17602429 ] ASF GitHub Bot commented on MNGSITE-492: cstamas commented on code in PR #287: URL:

[GitHub] [maven-site] cstamas commented on a diff in pull request #287: [MNGSITE-492] Maven Repositories documentation

cstamas commented on code in PR #287: URL: https://github.com/apache/maven-site/pull/287#discussion_r967223140 ## content/markdown/repositories/layout.md: ## @@ -0,0 +1,115 @@ +# Maven Repository Layout + + + +The layout is responsible to translate the artifact coordinates into

[GitHub] [maven-integration-testing] gnodet merged pull request #198: Remove remaining reference to verifier.getCliOptions()

gnodet merged PR #198: URL: https://github.com/apache/maven-integration-testing/pull/198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MNG-7485) Failed To Load JANSI Native Library

[ https://issues.apache.org/jira/browse/MNG-7485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602357#comment-17602357 ] Issa Gorissen commented on MNG-7485: Hello [~michael-o] , have a look   the jansi.tmpdir is not taken

[jira] [Commented] (MNGSITE-492) Create maven repository documentation

[ https://issues.apache.org/jira/browse/MNGSITE-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602310#comment-17602310 ] ASF GitHub Bot commented on MNGSITE-492: gnodet commented on code in PR #287: URL:

[GitHub] [maven-site] gnodet commented on a diff in pull request #287: [MNGSITE-492] Maven Repositories documentation

gnodet commented on code in PR #287: URL: https://github.com/apache/maven-site/pull/287#discussion_r967019021 ## content/markdown/repositories/artifacts.md: ## @@ -0,0 +1,126 @@ +# Maven Artifacts + + + +An Artifact is "anything" (any file) that can be addressed using their

[jira] [Commented] (MNGSITE-492) Create maven repository documentation

[ https://issues.apache.org/jira/browse/MNGSITE-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602296#comment-17602296 ] ASF GitHub Bot commented on MNGSITE-492: gnodet commented on code in PR #287: URL:

[GitHub] [maven-site] gnodet commented on a diff in pull request #287: [MNGSITE-492] Maven Repositories documentation

gnodet commented on code in PR #287: URL: https://github.com/apache/maven-site/pull/287#discussion_r966996094 ## content/markdown/repositories/artifacts.md: ## @@ -0,0 +1,122 @@ +# Maven Artifacts + + + +Artifact is "anything" that Maven downloads, installs or deploys for you.

[jira] [Commented] (MNGSITE-492) Create maven repository documentation

[ https://issues.apache.org/jira/browse/MNGSITE-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602295#comment-17602295 ] ASF GitHub Bot commented on MNGSITE-492: gnodet commented on code in PR #287: URL:

[GitHub] [maven-site] gnodet commented on a diff in pull request #287: [MNGSITE-492] Maven Repositories documentation

gnodet commented on code in PR #287: URL: https://github.com/apache/maven-site/pull/287#discussion_r966993926 ## content/markdown/repositories/artifacts.md: ## @@ -0,0 +1,122 @@ +# Maven Artifacts + + + +Artifact is "anything" that Maven downloads, installs or deploys for you.

[GitHub] [maven-site] gnodet commented on a diff in pull request #287: Maven Repositories documentation

gnodet commented on code in PR #287: URL: https://github.com/apache/maven-site/pull/287#discussion_r966992065 ## content/markdown/repositories/artifacts.md: ## @@ -0,0 +1,122 @@ +# Maven Artifacts + + + +Artifact is "anything" that Maven downloads, installs or deploys for you.

[GitHub] [maven-site] gnodet commented on a diff in pull request #287: Maven Repositories documentation

gnodet commented on code in PR #287: URL: https://github.com/apache/maven-site/pull/287#discussion_r966987214 ## content/markdown/repositories/artifacts.md: ## @@ -0,0 +1,122 @@ +# Maven Artifacts + + + +Artifact is "anything" that Maven downloads, installs or deploys for you.

[GitHub] [maven-integration-testing] michael-o commented on pull request #197: Remove verifier.getCliOptions().add( x ) pattern

michael-o commented on PR #197: URL: https://github.com/apache/maven-integration-testing/pull/197#issuecomment-1241886236 > New instance of Verifier should be used for each executions - Verifier should be immutable Yes, this makes it idiotproof. -- This is an automated message

[GitHub] [maven-site] gnodet commented on a diff in pull request #287: Maven Repositories documentation

gnodet commented on code in PR #287: URL: https://github.com/apache/maven-site/pull/287#discussion_r966987214 ## content/markdown/repositories/artifacts.md: ## @@ -0,0 +1,122 @@ +# Maven Artifacts + + + +Artifact is "anything" that Maven downloads, installs or deploys for you.

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602290#comment-17602290 ] ASF GitHub Bot commented on MNGSITE-491: cstamas commented on PR #321: URL:

[GitHub] [maven-site] cstamas commented on pull request #321: [MNGSITE-491] Update commit policy related document

cstamas commented on PR #321: URL: https://github.com/apache/maven-site/pull/321#issuecomment-1241883595 My take on "stable branch": a branch that was used for, or is decided that will be used for release". Hence, in case of maven repo, this means: master (future Maven4), maven-3.9.x (we

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602288#comment-17602288 ] ASF GitHub Bot commented on MNGSITE-491: olamy commented on code in PR #321: URL:

[GitHub] [maven-site] olamy commented on a diff in pull request #321: [MNGSITE-491] Update commit policy related document

olamy commented on code in PR #321: URL: https://github.com/apache/maven-site/pull/321#discussion_r966983964 ## content/apt/developers/conventions/git.apt: ## @@ -64,8 +64,12 @@ Maven Git Convention ** For committers Committers may, of course, commit directly to the ASF

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602287#comment-17602287 ] ASF GitHub Bot commented on MNGSITE-491: slawekjaranowski commented on code in PR #321: URL:

[GitHub] [maven-site] slawekjaranowski commented on a diff in pull request #321: [MNGSITE-491] Update commit policy related document

slawekjaranowski commented on code in PR #321: URL: https://github.com/apache/maven-site/pull/321#discussion_r966975814 ## content/markdown/project-roles.md: ## @@ -134,11 +134,25 @@ These are those people who have been given write access to the Apache Maven code repository

[GitHub] [maven-scm] olamy closed pull request #162: [SECURITY] Fix Partial Path Traversal Vulnerability

olamy closed pull request #162: [SECURITY] Fix Partial Path Traversal Vulnerability URL: https://github.com/apache/maven-scm/pull/162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-scm] olamy commented on pull request #162: [SECURITY] Fix Partial Path Traversal Vulnerability

olamy commented on PR #162: URL: https://github.com/apache/maven-scm/pull/162#issuecomment-1241880941 please follow the defined Apache process and please avoid vulnerability disclosure -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602286#comment-17602286 ] ASF GitHub Bot commented on MNGSITE-491: cstamas commented on code in PR #321: URL:

[GitHub] [maven-site] cstamas commented on a diff in pull request #321: [MNGSITE-491] Update commit policy related document

cstamas commented on code in PR #321: URL: https://github.com/apache/maven-site/pull/321#discussion_r966980955 ## content/apt/developers/conventions/git.apt: ## @@ -64,8 +64,12 @@ Maven Git Convention ** For committers Committers may, of course, commit directly to the ASF

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602285#comment-17602285 ] ASF GitHub Bot commented on MNGSITE-491: olamy commented on code in PR #321: URL:

[GitHub] [maven-site] olamy commented on a diff in pull request #321: [MNGSITE-491] Update commit policy related document

olamy commented on code in PR #321: URL: https://github.com/apache/maven-site/pull/321#discussion_r966978360 ## content/apt/developers/conventions/git.apt: ## @@ -64,8 +64,12 @@ Maven Git Convention ** For committers Committers may, of course, commit directly to the ASF

[jira] [Commented] (MNG-7098) Project counter should be cumulative when using resume

[ https://issues.apache.org/jira/browse/MNG-7098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602284#comment-17602284 ] ASF GitHub Bot commented on MNG-7098: - michael-o commented on code in PR #783: URL:

[GitHub] [maven] michael-o commented on a diff in pull request #783: [MNG-7098] Keep the project counter intact when resuming a multi-module project.

michael-o commented on code in PR #783: URL: https://github.com/apache/maven/pull/783#discussion_r966979227 ## maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java: ## @@ -143,7 +143,11 @@ public void sessionStarted( ExecutionEvent event )

[GitHub] [maven-scm] JLLeitschuh commented on pull request #162: [SECURITY] Fix Partial Path Traversal Vulnerability

JLLeitschuh commented on PR #162: URL: https://github.com/apache/maven-scm/pull/162#issuecomment-1241877688 Hi @olamy, Normally I would, but in this case, I'm fixing vulnerabilities at scale and this is impractical. Please see the section above titled "Why didn't you disclose

[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #131: [MNG-7310] Add a test for MNG-7310

michael-o commented on code in PR #131: URL: https://github.com/apache/maven-integration-testing/pull/131#discussion_r966978659 ## core-it-suite/src/test/resources/mng-7310-lifecycle-activated-in-specified-module/extension/pom.xml: ## @@ -0,0 +1,105 @@ + + + +

[jira] [Created] (MNGSITE-492) Create maven repository documentation

Tamás Cservenák created MNGSITE-492: --- Summary: Create maven repository documentation Key: MNGSITE-492 URL: https://issues.apache.org/jira/browse/MNGSITE-492 Project: Maven Project Web Site

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602276#comment-17602276 ] ASF GitHub Bot commented on MNGSITE-491: cstamas commented on PR #321: URL:

[GitHub] [maven-site] cstamas commented on pull request #321: [MNGSITE-491] Update commit policy related document

cstamas commented on PR #321: URL: https://github.com/apache/maven-site/pull/321#issuecomment-1241856118 @khmarbaise eh, you were too fast, I wanted to add one remark: @khmarbaise (w/ your PMC chair hat on): am unsure was this ever voted or decided upon, but I think it is

[jira] [Comment Edited] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602263#comment-17602263 ] Tamás Cservenák edited comment on MNGSITE-491 at 9/9/22 11:24 AM: --

[jira] [Comment Edited] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602263#comment-17602263 ] Tamás Cservenák edited comment on MNGSITE-491 at 9/9/22 11:23 AM: --

[jira] [Comment Edited] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602263#comment-17602263 ] Tamás Cservenák edited comment on MNGSITE-491 at 9/9/22 11:22 AM: --

[GitHub] [maven-site] cstamas opened a new pull request, #321: [MNGSITE-491] Update commit policy related document

cstamas opened a new pull request, #321: URL: https://github.com/apache/maven-site/pull/321 Last update to ASF Maven commit policy happened while it sources were hosted in Subversion repository... Update relevant bits w/ respect to changes happened since then. -- This is an automated

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602272#comment-17602272 ] ASF GitHub Bot commented on MNGSITE-491: cstamas opened a new pull request, #321: URL:

[jira] [Comment Edited] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602263#comment-17602263 ] Tamás Cservenák edited comment on MNGSITE-491 at 9/9/22 11:08 AM: --

[jira] [Commented] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602263#comment-17602263 ] Tamás Cservenák commented on MNGSITE-491: - Biggest problem: Curent maven site on page

[jira] [Created] (MNGSITE-491) Update commit policy related documents to avoid any misunderstanding

Tamás Cservenák created MNGSITE-491: --- Summary: Update commit policy related documents to avoid any misunderstanding Key: MNGSITE-491 URL: https://issues.apache.org/jira/browse/MNGSITE-491 Project:

[jira] [Commented] (MNG-7463) Improve documentation about deprecation in Mojo

[ https://issues.apache.org/jira/browse/MNG-7463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602243#comment-17602243 ] Hudson commented on MNG-7463: - Build succeeded in Jenkins: Maven » Maven TLP » maven-site » PR-287 #35 See

[jira] [Commented] (MSHARED-831) Configuration in reporting section not taken into account when running from cli

[ https://issues.apache.org/jira/browse/MSHARED-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602242#comment-17602242 ] Hudson commented on MSHARED-831: Build succeeded in Jenkins: Maven » Maven TLP » maven-site » PR-287 #35

[jira] [Commented] (MNGSITE-482) "introduction-to-profiles" document format error

[ https://issues.apache.org/jira/browse/MNGSITE-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602241#comment-17602241 ] Hudson commented on MNGSITE-482: Build succeeded in Jenkins: Maven » Maven TLP » maven-site » PR-287 #35

[jira] [Commented] (MNG-7408) Explain reporting plugin version automatic selection (in Maven 3)

[ https://issues.apache.org/jira/browse/MNG-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602238#comment-17602238 ] Hudson commented on MNG-7408: - Build succeeded in Jenkins: Maven » Maven TLP » maven-site » PR-287 #35 See

[jira] [Commented] (MNG-7449) [REGRESSION] StringVisitorModelInterpolator NullPointerException

[ https://issues.apache.org/jira/browse/MNG-7449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602240#comment-17602240 ] Hudson commented on MNG-7449: - Build succeeded in Jenkins: Maven » Maven TLP » maven-site » PR-287 #35 See

[jira] [Commented] (MNG-7432) [REGRESSION] Resolver session contains non-MavenWorkspaceReader

[ https://issues.apache.org/jira/browse/MNG-7432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602239#comment-17602239 ] Hudson commented on MNG-7432: - Build succeeded in Jenkins: Maven » Maven TLP » maven-site » PR-287 #35 See

[jira] [Commented] (MNG-7537) Create a branch for pre 3.9.x integration testing and remove old tests in master

[ https://issues.apache.org/jira/browse/MNG-7537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602220#comment-17602220 ] Hudson commented on MNG-7537: - Build failed in Jenkins: Maven » Maven TLP » maven » maven-3.8.x #43 See

[jira] [Commented] (MNG-7098) Project counter should be cumulative when using resume

[ https://issues.apache.org/jira/browse/MNG-7098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602219#comment-17602219 ] ASF GitHub Bot commented on MNG-7098: - MartinKanters commented on code in PR #783: URL:

[GitHub] [maven] MartinKanters commented on a diff in pull request #783: [MNG-7098] Keep the project counter intact when resuming a multi-module project.

MartinKanters commented on code in PR #783: URL: https://github.com/apache/maven/pull/783#discussion_r966805017 ## maven-embedder/src/test/java/org/apache/maven/cli/event/ExecutionEventLoggerTest.java: ## @@ -191,6 +194,80 @@ public void testProjectStartedNoPom()

[jira] [Commented] (MNG-7098) Project counter should be cumulative when using resume

[ https://issues.apache.org/jira/browse/MNG-7098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602210#comment-17602210 ] ASF GitHub Bot commented on MNG-7098: - MartinKanters commented on code in PR #783: URL:

[GitHub] [maven] MartinKanters commented on a diff in pull request #783: [MNG-7098] Keep the project counter intact when resuming a multi-module project.

MartinKanters commented on code in PR #783: URL: https://github.com/apache/maven/pull/783#discussion_r966788232 ## maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java: ## @@ -143,7 +143,11 @@ public void sessionStarted( ExecutionEvent event )

[jira] [Closed] (MNG-7537) Create a branch for pre 3.9.x integration testing and remove old tests in master

[ https://issues.apache.org/jira/browse/MNG-7537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7537. Resolution: Fixed > Create a branch for pre 3.9.x integration testing and remove old tests in >

[jira] [Commented] (MNG-7537) Create a branch for pre 3.9.x integration testing and remove old tests in master

[ https://issues.apache.org/jira/browse/MNG-7537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602208#comment-17602208 ] Guillaume Nodet commented on MNG-7537: --

[jira] [Commented] (MNG-7537) Create a branch for pre 3.9.x integration testing and remove old tests in master

[ https://issues.apache.org/jira/browse/MNG-7537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602205#comment-17602205 ] ASF GitHub Bot commented on MNG-7537: - gnodet merged PR #799: URL:

[GitHub] [maven] gnodet merged pull request #799: [MNG-7537] Point to the old IT branch when building 3.8.x

gnodet merged PR #799: URL: https://github.com/apache/maven/pull/799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #197: Remove verifier.getCliOptions().add( x ) pattern

slawekjaranowski commented on PR #197: URL: https://github.com/apache/maven-integration-testing/pull/197#issuecomment-1241680441 New instance of Verifier should be used for each executions - Verifier should be immutable -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (MNG-7537) Create a branch for pre 3.9.x integration testing and remove old tests in master

[ https://issues.apache.org/jira/browse/MNG-7537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602203#comment-17602203 ] ASF GitHub Bot commented on MNG-7537: - slawekjaranowski commented on PR #799: URL:

[GitHub] [maven-integration-testing] gnodet commented on pull request #197: Remove verifier.getCliOptions().add( x ) pattern

gnodet commented on PR #197: URL: https://github.com/apache/maven-integration-testing/pull/197#issuecomment-1241677967 > > > > Good catch. @slawekjaranowski This list should be read only. > > > > > > > > > exactly > > > > > > Note that there's one test which uses

[GitHub] [maven] slawekjaranowski commented on pull request #799: [MNG-7537] Point to the old IT branch when building 3.8.x

slawekjaranowski commented on PR #799: URL: https://github.com/apache/maven/pull/799#issuecomment-1241677158 We should do the same for Jenkins but it looks more complicated - now Jenkins always use master -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-integration-testing] MartinKanters commented on a diff in pull request #131: [MNG-7310] Add a test for MNG-7310

MartinKanters commented on code in PR #131: URL: https://github.com/apache/maven-integration-testing/pull/131#discussion_r966779299 ## core-it-suite/src/test/resources/mng-7310-lifecycle-activated-in-specified-module/extension/pom.xml: ## @@ -0,0 +1,105 @@ + + + +

[GitHub] [maven-integration-testing] michael-o commented on pull request #197: Remove verifier.getCliOptions().add( x ) pattern

michael-o commented on PR #197: URL: https://github.com/apache/maven-integration-testing/pull/197#issuecomment-1241672442 > > > Good catch. @slawekjaranowski This list should be read only. > > > > > > exactly > > Note that there's one test which uses

[GitHub] [maven-integration-testing] gnodet merged pull request #197: Remove verifier.getCliOptions().add( x ) pattern

gnodet merged PR #197: URL: https://github.com/apache/maven-integration-testing/pull/197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-integration-testing] gnodet commented on a diff in pull request #197: Remove verifier.getCliOptions().add( x ) pattern

gnodet commented on code in PR #197: URL: https://github.com/apache/maven-integration-testing/pull/197#discussion_r966772931 ## core-it-support/maven-it-helper/src/main/java/org/apache/maven/it/AbstractMavenIntegrationTestCase.java: ## @@ -592,7 +592,7 @@ protected Verifier

[GitHub] [maven-integration-testing] gnodet commented on pull request #197: Remove verifier.getCliOptions().add( x ) pattern

gnodet commented on PR #197: URL: https://github.com/apache/maven-integration-testing/pull/197#issuecomment-1241666859 > > Good catch. @slawekjaranowski This list should be read only. > > exactly Note that there's one test which uses `verifier.getCliOptions().remove( ... )` !

[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #197: Remove verifier.getCliOptions().add( x ) pattern

michael-o commented on code in PR #197: URL: https://github.com/apache/maven-integration-testing/pull/197#discussion_r966770751 ## core-it-support/maven-it-helper/src/main/java/org/apache/maven/it/AbstractMavenIntegrationTestCase.java: ## @@ -592,7 +592,7 @@ protected Verifier

[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #197: Remove verifier.getCliOptions().add( x ) pattern

slawekjaranowski commented on PR #197: URL: https://github.com/apache/maven-integration-testing/pull/197#issuecomment-1241665814 > Good catch. @slawekjaranowski This list should be read only. exactly -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-integration-testing] michael-o commented on pull request #197: Remove verifier.getCliOptions().add( x ) pattern

michael-o commented on PR #197: URL: https://github.com/apache/maven-integration-testing/pull/197#issuecomment-1241663984 Good catch. @slawekjaranowski This list should be read only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [maven-integration-testing] gnodet opened a new pull request, #197: Remove verifier.getCliOptions().add( x ) pattern

gnodet opened a new pull request, #197: URL: https://github.com/apache/maven-integration-testing/pull/197 Follow up to ecf4a04cd1c4b7698f28e3332cd24c23116c1467 which missed a few tests using the above pattern -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-integration-testing] gnodet commented on pull request #176: Move ITs to JDK 8 / JUnit 5

gnodet commented on PR #176: URL: https://github.com/apache/maven-integration-testing/pull/176#issuecomment-1241649841 I've just rebased this PR. Note that it currently depends on verifier 2.0.0-SNAPSHOT, but that one is available in apache public snapshot repository. -- This is an

[jira] [Commented] (MNG-7537) Create a branch for pre 3.9.x integration testing and remove old tests in master

[ https://issues.apache.org/jira/browse/MNG-7537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602190#comment-17602190 ] Guillaume Nodet commented on MNG-7537: -- PR to point to the

[jira] [Assigned] (MNG-7537) Create a branch for pre 3.9.x integration testing and remove old tests in master

[ https://issues.apache.org/jira/browse/MNG-7537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned MNG-7537: Assignee: Guillaume Nodet > Create a branch for pre 3.9.x integration testing and remove

[GitHub] [maven-integration-testing] gnodet merged pull request #196: Remove pre 3.9.x tests

gnodet merged PR #196: URL: https://github.com/apache/maven-integration-testing/pull/196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (MNG-7537) Create a branch for pre 3.9.x integration testing and remove old tests in master

Guillaume Nodet created MNG-7537: Summary: Create a branch for pre 3.9.x integration testing and remove old tests in master Key: MNG-7537 URL: https://issues.apache.org/jira/browse/MNG-7537 Project:

[GitHub] [maven-integration-testing] MartinKanters commented on a diff in pull request #131: [MNG-7310] Add a test for MNG-7310

MartinKanters commented on code in PR #131: URL: https://github.com/apache/maven-integration-testing/pull/131#discussion_r966739127 ## core-it-suite/src/test/resources/mng-7310-lifecycle-activated-in-specified-module/extension/pom.xml: ## @@ -0,0 +1,105 @@ + + + +

[GitHub] [maven-integration-testing] MartinKanters commented on a diff in pull request #131: [MNG-7310] Add a test for MNG-7310

MartinKanters commented on code in PR #131: URL: https://github.com/apache/maven-integration-testing/pull/131#discussion_r966726466 ## core-it-suite/src/test/resources/mng-7310-lifecycle-activated-in-specified-module/extension/pom.xml: ## @@ -0,0 +1,105 @@ + + + +

[jira] [Commented] (MRELEASE-839) Unable to supply tag to release for release:perform

[ https://issues.apache.org/jira/browse/MRELEASE-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602176#comment-17602176 ] Edward Lynch-Milner commented on MRELEASE-839: -- [~sjaranowski] I am taking a look into

[jira] [Commented] (MNG-7310) Maven loads extension from another submodule

[ https://issues.apache.org/jira/browse/MNG-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602172#comment-17602172 ] Martin Kanters commented on MNG-7310: - bq. It only leaks because demo1 is run first? Does it leak into

[jira] [Commented] (MNG-7502) Upgrade Guice to 5.1.0

[ https://issues.apache.org/jira/browse/MNG-7502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602166#comment-17602166 ] ASF GitHub Bot commented on MNG-7502: - michael-o commented on PR #798: URL:

[GitHub] [maven] michael-o commented on pull request #798: [MNG-7502] Upgrade to Guice 5.1.0

michael-o commented on PR #798: URL: https://github.com/apache/maven/pull/798#issuecomment-1241596870 While testing this: We have active dep management for this Guice/Guava. Is this affected at all? Can we drop/simplify something? E.g., exclusions and stuff. -- This is an automated

[GitHub] [maven-integration-testing] michael-o commented on pull request #196: Remove pre 3.9.x tests

michael-o commented on PR #196: URL: https://github.com/apache/maven-integration-testing/pull/196#issuecomment-1241583321 > > LGTM. Please squash and merge. I think this is a fundemantal change which should have a JIRA issue. > > Yes, and I think if we should create a branch at that

[jira] [Commented] (MNG-7502) Upgrade Guice to 5.1.0

[ https://issues.apache.org/jira/browse/MNG-7502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602160#comment-17602160 ] ASF GitHub Bot commented on MNG-7502: - michael-o commented on PR #798: URL:

[GitHub] [maven] michael-o commented on pull request #798: [MNG-7502] Upgrade to Guice 5.1.0

michael-o commented on PR #798: URL: https://github.com/apache/maven/pull/798#issuecomment-1241582578 Looking through this now... I'd like at least another commit to check this as well and bless it. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-integration-testing] gnodet commented on pull request #196: Remove pre 3.9.x tests

gnodet commented on PR #196: URL: https://github.com/apache/maven-integration-testing/pull/196#issuecomment-1241578723 > LGTM. Please squash and merge. I think this is a fundemantal change which should have a JIRA issue. Yes, and I think if we should create a branch at that point

[GitHub] [maven-mvnd] gnodet commented on issue #685: Console coloring is off when artifact download is under way

gnodet commented on issue #685: URL: https://github.com/apache/maven-mvnd/issues/685#issuecomment-1241550853 The 3 blocks of the following code are not consistent wrt to the project id colouring: