[GitHub] [maven] gnodet commented on pull request #844: Move the modello velocity plugin out of the API

2022-10-23 Thread GitBox
gnodet commented on PR #844: URL: https://github.com/apache/maven/pull/844#issuecomment-1288502529 Prefer https://github.com/apache/maven/pull/848 and https://github.com/codehaus-plexus/modello/pull/269 instead. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [maven] gnodet closed pull request #844: Move the modello velocity plugin out of the API

2022-10-23 Thread GitBox
gnodet closed pull request #844: Move the modello velocity plugin out of the API URL: https://github.com/apache/maven/pull/844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [maven] gnodet opened a new pull request, #848: Use the new velocity goal from the modello-maven-plugin

2022-10-23 Thread GitBox
gnodet opened a new pull request, #848: URL: https://github.com/apache/maven/pull/848 Use the new velocity plugin from the modello-maven-plugin added from https://github.com/codehaus-plexus/modello/pull/269. -- This is an automated message from the Apache Git Service. To respond t

[jira] [Updated] (MNG-7571) add new Maven immutable API to reference documentation

2022-10-23 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MNG-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MNG-7571: --- Fix Version/s: 4.0.0-alpha-3 > add new Maven immutable API to reference documentation > ---

[GitHub] [maven-parent] gnodet commented on a diff in pull request #82: [MPOM-349] Apply spotless to check/reformat code + poms

2022-10-23 Thread GitBox
gnodet commented on code in PR #82: URL: https://github.com/apache/maven-parent/pull/82#discussion_r1002922674 ## pom.xml: ## @@ -1170,19 +1175,63 @@ under the License. + + com.diffplug.spotless + spotless-maven-plugi

[GitHub] [maven-shared-resources] gnodet opened a new pull request, #5: [MSHARED-1155] New checkstyle rules configuration to use with spotless

2022-10-23 Thread GitBox
gnodet opened a new pull request, #5: URL: https://github.com/apache/maven-shared-resources/pull/5 - [MSHARED-1155] New checkstyle rules configuration to use with spotless - [MSHARED-1155] Remove rules to be enforced related to code style -- This is an automated message from the Apa

[jira] [Created] (MSHARED-1155) New checkstyle rules configuration to use with spotless

2022-10-23 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MSHARED-1155: Summary: New checkstyle rules configuration to use with spotless Key: MSHARED-1155 URL: https://issues.apache.org/jira/browse/MSHARED-1155 Project: Maven Share

[GitHub] [maven-shared-resources] gnodet merged pull request #2: Update download page

2022-10-23 Thread GitBox
gnodet merged PR #2: URL: https://github.com/apache/maven-shared-resources/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mav

[GitHub] [maven-shared-resources] gnodet closed pull request #3: Change code style

2022-10-23 Thread GitBox
gnodet closed pull request #3: Change code style URL: https://github.com/apache/maven-shared-resources/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [maven-parent] gnodet commented on a diff in pull request #84: [MPOM-351] Upgrade plexus-utils 3.4.2

2022-10-23 Thread GitBox
gnodet commented on code in PR #84: URL: https://github.com/apache/maven-parent/pull/84#discussion_r1002913512 ## pom.xml: ## @@ -966,7 +966,7 @@ under the License. org.codehaus.plexus plexus-utils -3.3.0 +3.4.2 Review Comment: Done

[GitHub] [maven-checkstyle-plugin] dependabot[bot] opened a new pull request, #98: Bump plexus-utils from 3.4.2 to 3.5.0

2022-10-23 Thread GitBox
dependabot[bot] opened a new pull request, #98: URL: https://github.com/apache/maven-checkstyle-plugin/pull/98 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.2 to 3.5.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/relea

[GitHub] [maven-assembly-plugin] dependabot[bot] closed pull request #89: Bump mockito-core from 4.6.1 to 4.8.0

2022-10-23 Thread GitBox
dependabot[bot] closed pull request #89: Bump mockito-core from 4.6.1 to 4.8.0 URL: https://github.com/apache/maven-assembly-plugin/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-assembly-plugin] dependabot[bot] commented on pull request #89: Bump mockito-core from 4.6.1 to 4.8.0

2022-10-23 Thread GitBox
dependabot[bot] commented on PR #89: URL: https://github.com/apache/maven-assembly-plugin/pull/89#issuecomment-1288422929 Superseded by #94. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven-assembly-plugin] dependabot[bot] opened a new pull request, #94: Bump mockito-core from 4.6.1 to 4.8.1

2022-10-23 Thread GitBox
dependabot[bot] opened a new pull request, #94: URL: https://github.com/apache/maven-assembly-plugin/pull/94 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.6.1 to 4.8.1. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's release

[GitHub] [maven-gpg-plugin] dependabot[bot] opened a new pull request, #27: Bump plexus-utils from 3.4.2 to 3.5.0

2022-10-23 Thread GitBox
dependabot[bot] opened a new pull request, #27: URL: https://github.com/apache/maven-gpg-plugin/pull/27 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.2 to 3.5.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";>p

[GitHub] [maven-resources-plugin] dependabot[bot] opened a new pull request, #37: Bump plexus-utils from 3.4.2 to 3.5.0

2022-10-23 Thread GitBox
dependabot[bot] opened a new pull request, #37: URL: https://github.com/apache/maven-resources-plugin/pull/37 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.2 to 3.5.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releas

[GitHub] [maven-release] dependabot[bot] closed pull request #148: Bump mockito-core from 2.28.2 to 4.8.0

2022-10-23 Thread GitBox
dependabot[bot] closed pull request #148: Bump mockito-core from 2.28.2 to 4.8.0 URL: https://github.com/apache/maven-release/pull/148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [maven-release] dependabot[bot] opened a new pull request, #155: Bump mockito-core from 2.28.2 to 4.8.1

2022-10-23 Thread GitBox
dependabot[bot] opened a new pull request, #155: URL: https://github.com/apache/maven-release/pull/155 Bumps [mockito-core](https://github.com/mockito/mockito) from 2.28.2 to 4.8.1. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases.

[GitHub] [maven-release] dependabot[bot] commented on pull request #148: Bump mockito-core from 2.28.2 to 4.8.0

2022-10-23 Thread GitBox
dependabot[bot] commented on PR #148: URL: https://github.com/apache/maven-release/pull/148#issuecomment-1288405014 Superseded by #155. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-help-plugin] dependabot[bot] opened a new pull request, #75: Bump plexus-utils from 3.4.2 to 3.5.0

2022-10-23 Thread GitBox
dependabot[bot] opened a new pull request, #75: URL: https://github.com/apache/maven-help-plugin/pull/75 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.2 to 3.5.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";>

[GitHub] [maven-jlink-plugin] dependabot[bot] closed pull request #120: Bump mockito-core from 4.2.0 to 4.8.0

2022-10-23 Thread GitBox
dependabot[bot] closed pull request #120: Bump mockito-core from 4.2.0 to 4.8.0 URL: https://github.com/apache/maven-jlink-plugin/pull/120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-jlink-plugin] dependabot[bot] commented on pull request #120: Bump mockito-core from 4.2.0 to 4.8.0

2022-10-23 Thread GitBox
dependabot[bot] commented on PR #120: URL: https://github.com/apache/maven-jlink-plugin/pull/120#issuecomment-1288390627 Superseded by #122. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request, #122: Bump mockito-core from 4.2.0 to 4.8.1

2022-10-23 Thread GitBox
dependabot[bot] opened a new pull request, #122: URL: https://github.com/apache/maven-jlink-plugin/pull/122 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.2.0 to 4.8.1. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases

[GitHub] [maven-invoker-plugin] dependabot[bot] opened a new pull request, #149: Bump plexus-utils from 3.4.2 to 3.5.0

2022-10-23 Thread GitBox
dependabot[bot] opened a new pull request, #149: URL: https://github.com/apache/maven-invoker-plugin/pull/149 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.2 to 3.5.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releas

[GitHub] [maven-invoker-plugin] dependabot[bot] closed pull request #139: Bump mockito-core from 4.6.1 to 4.8.0

2022-10-23 Thread GitBox
dependabot[bot] closed pull request #139: Bump mockito-core from 4.6.1 to 4.8.0 URL: https://github.com/apache/maven-invoker-plugin/pull/139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [maven-invoker-plugin] dependabot[bot] commented on pull request #139: Bump mockito-core from 4.6.1 to 4.8.0

2022-10-23 Thread GitBox
dependabot[bot] commented on PR #139: URL: https://github.com/apache/maven-invoker-plugin/pull/139#issuecomment-1288389424 Superseded by #148. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-invoker-plugin] dependabot[bot] opened a new pull request, #148: Bump mockito-core from 4.6.1 to 4.8.1

2022-10-23 Thread GitBox
dependabot[bot] opened a new pull request, #148: URL: https://github.com/apache/maven-invoker-plugin/pull/148 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.6.1 to 4.8.1. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releas

[GitHub] [maven-dependency-analyzer] dependabot[bot] opened a new pull request, #72: Bump plexus-utils from 3.4.2 to 3.5.0

2022-10-23 Thread GitBox
dependabot[bot] opened a new pull request, #72: URL: https://github.com/apache/maven-dependency-analyzer/pull/72 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.2 to 3.5.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/rel

[GitHub] [maven-shade-plugin] dependabot[bot] opened a new pull request, #163: Bump plexus-utils from 3.4.2 to 3.5.0

2022-10-23 Thread GitBox
dependabot[bot] opened a new pull request, #163: URL: https://github.com/apache/maven-shade-plugin/pull/163 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.2 to 3.5.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases

[GitHub] [maven-indexer] dependabot[bot] opened a new pull request, #256: Bump plexus-utils from 3.4.2 to 3.5.0

2022-10-23 Thread GitBox
dependabot[bot] opened a new pull request, #256: URL: https://github.com/apache/maven-indexer/pull/256 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.2 to 3.5.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";>pl

[GitHub] [maven-parent] dependabot[bot] opened a new pull request, #87: Bump plexus-utils from 3.3.0 to 3.5.0

2022-10-23 Thread GitBox
dependabot[bot] opened a new pull request, #87: URL: https://github.com/apache/maven-parent/pull/87 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.3.0 to 3.5.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";>plexu

[GitHub] [maven-doxia-converter] dependabot[bot] opened a new pull request, #34: Bump plexus-utils from 3.4.2 to 3.5.0

2022-10-23 Thread GitBox
dependabot[bot] opened a new pull request, #34: URL: https://github.com/apache/maven-doxia-converter/pull/34 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.2 to 3.5.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/release

[GitHub] [maven-site-plugin] dependabot[bot] opened a new pull request, #106: Bump plexus-utils from 3.4.2 to 3.5.0

2022-10-23 Thread GitBox
dependabot[bot] opened a new pull request, #106: URL: https://github.com/apache/maven-site-plugin/pull/106 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.2 to 3.5.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases"

[GitHub] [maven-jar-plugin] dependabot[bot] opened a new pull request, #54: Bump plexus-utils from 3.4.2 to 3.5.0

2022-10-23 Thread GitBox
dependabot[bot] opened a new pull request, #54: URL: https://github.com/apache/maven-jar-plugin/pull/54 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.2 to 3.5.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";>p

[GitHub] [maven-wrapper] dependabot[bot] closed pull request #62: Bump mockito-core from 4.6.1 to 4.8.0

2022-10-23 Thread GitBox
dependabot[bot] closed pull request #62: Bump mockito-core from 4.6.1 to 4.8.0 URL: https://github.com/apache/maven-wrapper/pull/62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [maven-wrapper] dependabot[bot] commented on pull request #62: Bump mockito-core from 4.6.1 to 4.8.0

2022-10-23 Thread GitBox
dependabot[bot] commented on PR #62: URL: https://github.com/apache/maven-wrapper/pull/62#issuecomment-1288296801 Superseded by #66. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [maven-wrapper] dependabot[bot] opened a new pull request, #66: Bump mockito-core from 4.6.1 to 4.8.1

2022-10-23 Thread GitBox
dependabot[bot] opened a new pull request, #66: URL: https://github.com/apache/maven-wrapper/pull/66 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.6.1 to 4.8.1. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases.

[GitHub] [maven-javadoc-plugin] elharo merged pull request #171: an --> a

2022-10-23 Thread GitBox
elharo merged PR #171: URL: https://github.com/apache/maven-javadoc-plugin/pull/171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

[GitHub] [maven-parent] gnodet commented on a diff in pull request #82: [MPOM-349] Apply spotless to check/reformat code + poms

2022-10-23 Thread GitBox
gnodet commented on code in PR #82: URL: https://github.com/apache/maven-parent/pull/82#discussion_r1002757523 ## pom.xml: ## @@ -1170,19 +1175,63 @@ under the License. + + com.diffplug.spotless + spotless-maven-plugi

[GitHub] [maven] gnodet commented on a diff in pull request #846: change goal type to StringBuilder

2022-10-23 Thread GitBox
gnodet commented on code in PR #846: URL: https://github.com/apache/maven/pull/846#discussion_r1002756710 ## maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java: ## @@ -225,10 +225,10 @@ else if ( numTokens == 3 ) plugin = findPlu

[jira] [Commented] (MNG-7578) Building Linux image on Windows impossible (patch incuded)

2022-10-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622864#comment-17622864 ] Michael Osipov commented on MNG-7578: - Makes sense, this also applies to other executal

[GitHub] [maven-parent] bmarwell commented on a diff in pull request #82: [MPOM-349] Apply spotless to check/reformat code + poms

2022-10-23 Thread GitBox
bmarwell commented on code in PR #82: URL: https://github.com/apache/maven-parent/pull/82#discussion_r1002744187 ## pom.xml: ## @@ -1170,19 +1175,63 @@ under the License. + + com.diffplug.spotless + spotless-maven-plu

[GitHub] [maven-dependency-analyzer] elharo commented on a diff in pull request #71: [MSHARED-1149] – Replace System.out by logger

2022-10-23 Thread GitBox
elharo commented on code in PR #71: URL: https://github.com/apache/maven-dependency-analyzer/pull/71#discussion_r1002744101 ## pom.xml: ## @@ -95,6 +96,12 @@ 9.3 + Review Comment: Third party logging frameworks haven't been needed since Java 1.4. Post lo

[GitHub] [maven-mvnd] gzm55 commented on pull request #717: Try native image then fallback to pure java version

2022-10-23 Thread GitBox
gzm55 commented on PR #717: URL: https://github.com/apache/maven-mvnd/pull/717#issuecomment-1288157350 @ppalaga i add a post-install script `bin/mvnd-persist-native` for detecting and moving the native mage as the default entry -- This is an automated message from the Apache Git Service.

[jira] [Updated] (MASSEMBLY-941) file permissions removed during assembly:single since 3.2.0

2022-10-23 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MASSEMBLY-941: Fix Version/s: next-release > file permissions removed during assembly:single since 3.2.

[jira] [Commented] (MASSEMBLY-941) file permissions removed during assembly:single since 3.2.0

2022-10-23 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622846#comment-17622846 ] Herve Boutemy commented on MASSEMBLY-941: - plexus-archiver PR created https:/

[GitHub] [maven-javadoc-plugin] elharo opened a new pull request, #171: an --> a

2022-10-23 Thread GitBox
elharo opened a new pull request, #171: URL: https://github.com/apache/maven-javadoc-plugin/pull/171 @michael-o Minor type fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-parent] slawekjaranowski commented on a diff in pull request #82: [MPOM-349] Apply spotless to check/reformat code + poms

2022-10-23 Thread GitBox
slawekjaranowski commented on code in PR #82: URL: https://github.com/apache/maven-parent/pull/82#discussion_r1002739612 ## pom.xml: ## @@ -1170,19 +1175,63 @@ under the License. + + com.diffplug.spotless + spotless-m

[GitHub] [maven-dependency-analyzer] slawekjaranowski commented on a diff in pull request #71: [MSHARED-1149] – Replace System.out by logger

2022-10-23 Thread GitBox
slawekjaranowski commented on code in PR #71: URL: https://github.com/apache/maven-dependency-analyzer/pull/71#discussion_r1002737753 ## pom.xml: ## @@ -95,6 +96,12 @@ 9.3 + Review Comment: This library is used in Maven plugins ... so does Maven support

[jira] [Updated] (MPOM-332) Upgrade maven-deploy-plugin to 3.0.0

2022-10-23 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MPOM-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MPOM-332: - Fix Version/s: (was: ASF-28) > Upgrade maven-deploy-plugin to 3.0.0 > -

[jira] [Updated] (MPOM-347) Allow custom Release Distribution Repository

2022-10-23 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MPOM-347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MPOM-347: - Component/s: asf > Allow custom Release Distribution Repository > -

[jira] [Closed] (MPOM-347) Allow custom Release Distribution Repository

2022-10-23 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MPOM-347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPOM-347. Fix Version/s: ASF-28 Resolution: Fixed > Allow custom Release Distribution Repository

[jira] [Assigned] (MPOM-347) Allow custom Release Distribution Repository

2022-10-23 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MPOM-347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MPOM-347: Assignee: Slawomir Jaranowski > Allow custom Release Distribution Repository > -

[jira] [Commented] (MPOM-347) Allow custom Release Distribution Repository

2022-10-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MPOM-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622842#comment-17622842 ] Hudson commented on MPOM-347: - Build succeeded in Jenkins: Maven » Maven TLP » maven-apache-par

[GitHub] [maven-apache-parent] slawekjaranowski merged pull request #111: [MPOM-347] Allow custom Release Distribution Repository

2022-10-23 Thread GitBox
slawekjaranowski merged PR #111: URL: https://github.com/apache/maven-apache-parent/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[GitHub] [maven-dependency-analyzer] elharo commented on a diff in pull request #71: [MSHARED-1149] – Replace System.out by logger

2022-10-23 Thread GitBox
elharo commented on code in PR #71: URL: https://github.com/apache/maven-dependency-analyzer/pull/71#discussion_r1002735103 ## pom.xml: ## @@ -95,6 +96,12 @@ 9.3 + Review Comment: Ick, no. Can we please stop adding third party logging libraries willy nil

[GitHub] [maven-war-plugin] elharo merged pull request #33: Remove broken link

2022-10-23 Thread GitBox
elharo merged PR #33: URL: https://github.com/apache/maven-war-plugin/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.a

[GitHub] [maven-parent] slawekjaranowski commented on a diff in pull request #84: [MPOM-351] Upgrade plexus-utils 3.4.2

2022-10-23 Thread GitBox
slawekjaranowski commented on code in PR #84: URL: https://github.com/apache/maven-parent/pull/84#discussion_r1002720928 ## pom.xml: ## @@ -966,7 +966,7 @@ under the License. org.codehaus.plexus plexus-utils -3.3.0 +3.4.2 Review Comment

[jira] [Updated] (MEAR-322) Module repackaged as invalid archive

2022-10-23 Thread Piotr Zygielo (Jira)
[ https://issues.apache.org/jira/browse/MEAR-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Zygielo updated MEAR-322: --- Description: After m-ear-p upgrade from 3.2.0 to 3.3.0, ear produced by plugin contains invalid entry.

[jira] [Commented] (MPOM-353) Use standard value for ignoreFailures at m-invoker-p

2022-10-23 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MPOM-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622805#comment-17622805 ] Hudson commented on MPOM-353: - Build succeeded in Jenkins: Maven » Maven TLP » maven-parent » m

[jira] [Closed] (MPOM-353) Use standard value for ignoreFailures at m-invoker-p

2022-10-23 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MPOM-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPOM-353. Assignee: Slawomir Jaranowski Resolution: Fixed > Use standard value for ignoreFailures

[GitHub] [maven-parent] slawekjaranowski merged pull request #86: [MPOM-353] Use standard value for ignoreFailures at m-invoker-p

2022-10-23 Thread GitBox
slawekjaranowski merged PR #86: URL: https://github.com/apache/maven-parent/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

[GitHub] [maven-war-plugin] elharo opened a new pull request, #33: Remove broken link

2022-10-23 Thread GitBox
elharo opened a new pull request, #33: URL: https://github.com/apache/maven-war-plugin/pull/33 @slachiewicz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[jira] [Commented] (MWAR-351) Optional dependency not being included in the WEB-INF/lib folder

2022-10-23 Thread elharo (Jira)
[ https://issues.apache.org/jira/browse/MWAR-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622801#comment-17622801 ] elharo commented on MWAR-351: - This might be working as intended. "When A declares B as an opti

[jira] [Commented] (MEAR-322) Module repackaged as invalid archive

2022-10-23 Thread Robert Scholte (Jira)
[ https://issues.apache.org/jira/browse/MEAR-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622799#comment-17622799 ] Robert Scholte commented on MEAR-322: - Everybody can report a bug, but due to a huge am

[jira] [Updated] (MNG-7578) Building Linux image on Windows impossible (patch incuded)

2022-10-23 Thread Eugen Labun (Jira)
[ https://issues.apache.org/jira/browse/MNG-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eugen Labun updated MNG-7578: - Description: If you try to find `javac` in a Linux JDK using `Toolchain.findTool()` method, this will fail

[jira] [Created] (MNG-7578) Building Linux image on Windows impossible (patch incuded)

2022-10-23 Thread Eugen Labun (Jira)
Eugen Labun created MNG-7578: Summary: Building Linux image on Windows impossible (patch incuded) Key: MNG-7578 URL: https://issues.apache.org/jira/browse/MNG-7578 Project: Maven Issue Type: Bug

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2022-10-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622795#comment-17622795 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on PR #840: URL: https://github

[GitHub] [maven] gnodet commented on pull request #840: [MNG-7038] Introducing project.topdir

2022-10-23 Thread GitBox
gnodet commented on PR #840: URL: https://github.com/apache/maven/pull/840#issuecomment-1288104958 > A practical example is in this project https://github.com/nielsbasjes/yauaa I wanted to have a single set of project specific checkstyle config. I ended up with packaging these files in a ja

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2022-10-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622790#comment-17622790 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on PR #840: URL: https://github

[GitHub] [maven] gnodet commented on pull request #840: [MNG-7038] Introducing project.topdir

2022-10-23 Thread GitBox
gnodet commented on PR #840: URL: https://github.com/apache/maven/pull/840#issuecomment-1288099174 > @gnodet My first class of usecases is a consistent location for project level settings ( https://issues.apache.org/jira/browse/MNG-5659 ) which will solve a lot of practical problems for man

[jira] [Comment Edited] (MEAR-322) Module repackaged as invalid archive

2022-10-23 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MEAR-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622786#comment-17622786 ] Slawomir Jaranowski edited comment on MEAR-322 at 10/23/22 11:50 AM:

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2022-10-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622787#comment-17622787 ] ASF GitHub Bot commented on MNG-7038: - nielsbasjes commented on PR #840: URL: https://g

[GitHub] [maven] nielsbasjes commented on pull request #840: [MNG-7038] Introducing project.topdir

2022-10-23 Thread GitBox
nielsbasjes commented on PR #840: URL: https://github.com/apache/maven/pull/840#issuecomment-1288093272 A practical example is in this project https://github.com/nielsbasjes/yauaa I wanted to have a single set of project specific checkstyle config. I ended up with packaging these files in a

[GitHub] [maven-parent] slawekjaranowski commented on pull request #83: [MPOM-350] Raise JDK requirement to 1.8

2022-10-23 Thread GitBox
slawekjaranowski commented on PR #83: URL: https://github.com/apache/maven-parent/pull/83#issuecomment-1288092913 There is also configuration related to JDK 7 like ``` ${https.protocols} ``` should be removed also -- This is an automated

[jira] [Commented] (MEAR-322) Module repackaged as invalid archive

2022-10-23 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MEAR-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622786#comment-17622786 ] Slawomir Jaranowski commented on MEAR-322: -- By the way issues on JDK should be ref

[jira] [Commented] (MEAR-322) Module repackaged as invalid archive

2022-10-23 Thread Piotr Zygielo (Jira)
[ https://issues.apache.org/jira/browse/MEAR-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622785#comment-17622785 ] Piotr Zygielo commented on MEAR-322: Thanks for checking more JDKs and providing links.

[jira] [Updated] (MPOM-353) Use standard value for ignoreFailures at m-invoker-p

2022-10-23 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MPOM-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MPOM-353: - Description: On Jenkins we execute jobs with: {{-Dmaven.test.failure.ignore=true}} propert

[jira] [Updated] (MPOM-353) Use standard value for ignoreFailures at m-invoker-p

2022-10-23 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MPOM-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MPOM-353: - Description: On Jenkins we execute jobs with: {{-Dmaven.test.failure.ignore=true}} propert

[jira] [Created] (MPOM-353) Use standard value for ignoreFailures at m-invoker-p

2022-10-23 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPOM-353: Summary: Use standard value for ignoreFailures at m-invoker-p Key: MPOM-353 URL: https://issues.apache.org/jira/browse/MPOM-353 Project: Maven POMs I

[jira] [Commented] (MNG-7568) [WARNING] The requested profile "ABCDEF" could not be activated because it does not exist.

2022-10-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622783#comment-17622783 ] ASF GitHub Bot commented on MNG-7568: - pzygielo commented on PR #809: URL: https://gith

[GitHub] [maven] pzygielo commented on pull request #809: [MNG-7568] Consider inactive profiles for validation

2022-10-23 Thread GitBox
pzygielo commented on PR #809: URL: https://github.com/apache/maven/pull/809#issuecomment-1288089277 > This does not appear in master or 3.9.x? if (this == this issue) - no such problem in master. Never heard of maven 3.9.x. if (this == this change) - not proposed for master

[GitHub] [maven-integration-testing] pzygielo commented on a diff in pull request #205: [MNG-7568] Test for deactivating profile defined in settings and project

2022-10-23 Thread GitBox
pzygielo commented on code in PR #205: URL: https://github.com/apache/maven-integration-testing/pull/205#discussion_r1002692381 ## core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7568SettingsProfileDeactivationTest.java: ## @@ -0,0 +1,59 @@ +package org.apache.maven.i

[jira] [Updated] (MEAR-322) Module repackaged as invalid archive

2022-10-23 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MEAR-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MEAR-322: - Fix Version/s: more-investigation > Module repackaged as invalid archive >

[jira] [Commented] (MEAR-322) Module repackaged as invalid archive

2022-10-23 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MEAR-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622780#comment-17622780 ] Slawomir Jaranowski commented on MEAR-322: -- Such issue occurs only on JDK 11 when

[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #205: [MNG-7568] Test for deactivating profile defined in settings and project

2022-10-23 Thread GitBox
michael-o commented on code in PR #205: URL: https://github.com/apache/maven-integration-testing/pull/205#discussion_r1002691139 ## core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7568SettingsProfileDeactivationTest.java: ## @@ -0,0 +1,59 @@ +package org.apache.maven.

[jira] [Commented] (MNG-7568) [WARNING] The requested profile "ABCDEF" could not be activated because it does not exist.

2022-10-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622779#comment-17622779 ] ASF GitHub Bot commented on MNG-7568: - michael-o commented on PR #809: URL: https://git

[GitHub] [maven] michael-o commented on pull request #809: [MNG-7568] Consider inactive profiles for validation

2022-10-23 Thread GitBox
michael-o commented on PR #809: URL: https://github.com/apache/maven/pull/809#issuecomment-1288087207 This does not appear in master or 3.9.x? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-ear-plugin] slawekjaranowski closed pull request #80: [MEAR-322] Try to reproduce issue

2022-10-23 Thread GitBox
slawekjaranowski closed pull request #80: [MEAR-322] Try to reproduce issue URL: https://github.com/apache/maven-ear-plugin/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [maven-parent] gnodet commented on pull request #82: [MPOM-349] Apply spotless to check/reformat code + poms

2022-10-23 Thread GitBox
gnodet commented on PR #82: URL: https://github.com/apache/maven-parent/pull/82#issuecomment-1288069866 > > > LGTM but if we move to spotless. I would remove `checkstyle:check` as well as we do not need really to check sources style twice during the build > > > And it's a bit confusin

[GitHub] [maven-parent] gnodet commented on pull request #82: [MPOM-349] Apply spotless to check/reformat code + poms

2022-10-23 Thread GitBox
gnodet commented on PR #82: URL: https://github.com/apache/maven-parent/pull/82#issuecomment-1288069391 > LGTM but if we move to spotless. I would remove `checkstyle:check` as well as we do not need really to check sources style twice during the build > And it's a bit confusing as whe

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2022-10-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622773#comment-17622773 ] ASF GitHub Bot commented on MNG-7038: - nielsbasjes commented on PR #840: URL: https://g

[GitHub] [maven] nielsbasjes commented on pull request #840: [MNG-7038] Introducing project.topdir

2022-10-23 Thread GitBox
nielsbasjes commented on PR #840: URL: https://github.com/apache/maven/pull/840#issuecomment-1288068788 @gnodet My first class of usecases is a consistent location for project level settings ( https://issues.apache.org/jira/browse/MNG-5659 ) which will solve a lot of practical problems for

[GitHub] [maven-scm] michael-o commented on pull request #31: SCM-706 finer-grained handling of file rename status for gitexe provider...

2022-10-23 Thread GitBox
michael-o commented on PR #31: URL: https://github.com/apache/maven-scm/pull/31#issuecomment-1288068419 Anyone wants to pick this up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2022-10-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622771#comment-17622771 ] ASF GitHub Bot commented on MNG-7038: - nielsbasjes commented on PR #840: URL: https://g

[GitHub] [maven] nielsbasjes commented on pull request #840: [MNG-7038] Introducing project.topdir

2022-10-23 Thread GitBox
nielsbasjes commented on PR #840: URL: https://github.com/apache/maven/pull/840#issuecomment-1288068151 Cases to think about I just thought of: Context: Multi module project, all `parent modules` have pointers towards their `child modules`. - A child module points to the correct parent

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2022-10-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622770#comment-17622770 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on PR #840: URL: https://github

[GitHub] [maven] gnodet commented on pull request #840: [MNG-7038] Introducing project.topdir

2022-10-23 Thread GitBox
gnodet commented on PR #840: URL: https://github.com/apache/maven/pull/840#issuecomment-1288067732 > @gnodet Thanks for the code pointer. This really helps in my understanding the code. > > > For the per-project settings.xml, I don't think they should use the topdir, at least not usi

[GitHub] [maven-parent] olamy commented on pull request #82: [MPOM-349] Apply spotless to check/reformat code + poms

2022-10-23 Thread GitBox
olamy commented on PR #82: URL: https://github.com/apache/maven-parent/pull/82#issuecomment-1288066873 > > LGTM but if we move to spotless. I would remove `checkstyle:check` as well as we do not need really to check sources style twice during the build > > And it's a bit confusing as

[jira] [Commented] (MRESOLVER-279) Simplify and improve trusted checksum sources

2022-10-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622768#comment-17622768 ] ASF GitHub Bot commented on MRESOLVER-279: -- michael-o commented on code in PR

  1   2   >