[GitHub] [maven-archetypes] nitind commented on pull request #6: [MARCHETYPES-75] Bump web archetype deployment descriptor to v4, portlet to v3

2023-01-13 Thread GitBox
nitind commented on PR #6: URL: https://github.com/apache/maven-archetypes/pull/6#issuecomment-1382670270 @slawekjaranowski Opened [MARCHETYPES-75](https://issues.apache.org/jira/browse/MARCHETYPES-75) -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-archetypes] nitind commented on pull request #6: Bump web archetype deployment descriptor to v4, portlet to v3

2023-01-13 Thread GitBox
nitind commented on PR #6: URL: https://github.com/apache/maven-archetypes/pull/6#issuecomment-1382670147 Servlet 5 involved API breakages, so still putting forth this change to 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Created] (MARCHETYPES-75) Bump web archetype deployment descriptor to v4, portlet to v3

2023-01-13 Thread Nitin Dahyabhai (Jira)
Nitin Dahyabhai created MARCHETYPES-75: -- Summary: Bump web archetype deployment descriptor to v4, portlet to v3 Key: MARCHETYPES-75 URL: https://issues.apache.org/jira/browse/MARCHETYPES-75 Proje

[GitHub] [maven-jlink-plugin] bmarwell commented on a diff in pull request #78: [MJLINK-64] Fix addOptions arguments passing

2023-01-13 Thread GitBox
bmarwell commented on code in PR #78: URL: https://github.com/apache/maven-jlink-plugin/pull/78#discussion_r1070024403 ## src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java: ## @@ -108,6 +108,8 @@ * * The command line equivalent is: {@code jlink --add-optio

[GitHub] [maven] michael-o closed pull request #957: Swcurity policy

2023-01-13 Thread GitBox
michael-o closed pull request #957: Swcurity policy URL: https://github.com/apache/maven/pull/957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[jira] [Updated] (MSHARED-1132) Improved handling of system and user properties

2023-01-13 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSHARED-1132: Description: In embedded mode system properties are overridden by values provided by user

[GitHub] [maven-wrapper] bmarwell commented on pull request #84: [BUILD] add prettier config for shell

2023-01-13 Thread GitBox
bmarwell commented on PR #84: URL: https://github.com/apache/maven-wrapper/pull/84#issuecomment-1382351592 You might want to talk about: https://github.com/apache/maven-wrapper/pull/84/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R110-R111 `onlymvnw` u

[jira] [Updated] (MWRAPPER-88) mvnw is not POSIX compatible

2023-01-13 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MWRAPPER-88: - Fix Version/s: 3.2.0 > mvnw is not POSIX compatible > > >

[jira] [Resolved] (MWRAPPER-88) mvnw is not POSIX compatible

2023-01-13 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MWRAPPER-88. -- Resolution: Fixed fixed with https://github.com/apache/maven-wrapper/commit/7840c9036

[GitHub] [maven-wrapper] bmarwell opened a new pull request, #84: [BUILD] add prettier config for shell

2023-01-13 Thread GitBox
bmarwell opened a new pull request, #84: URL: https://github.com/apache/maven-wrapper/pull/84 Signed-off-by: Benjamin Marwell Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apach

[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible

2023-01-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676736#comment-17676736 ] ASF GitHub Bot commented on MWRAPPER-88: bmarwell merged PR #79: URL: https://gi

[GitHub] [maven-wrapper] bmarwell merged pull request #83: Bump junit-bom from 5.9.1 to 5.9.2

2023-01-13 Thread GitBox
bmarwell merged PR #83: URL: https://github.com/apache/maven-wrapper/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[GitHub] [maven-wrapper] bmarwell merged pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity

2023-01-13 Thread GitBox
bmarwell merged PR #79: URL: https://github.com/apache/maven-wrapper/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[jira] [Commented] (MBUILDCACHE-33) Support remote cache credentials from environment variables

2023-01-13 Thread Alexander Schwartz (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676726#comment-17676726 ] Alexander Schwartz commented on MBUILDCACHE-33: --- In a previous comment,

[GitHub] [maven-integration-testing] psiroky opened a new pull request, #233: [MNG-7661] Replace deprecated 'verifier.newDefaultFilterProperties()'

2023-01-13 Thread GitBox
psiroky opened a new pull request, #233: URL: https://github.com/apache/maven-integration-testing/pull/233 * this should be the last _big_ PR. * these three calls are basically identical (at least with the current version of the Verifier): ```java (1) verifier.filterFile( "settings

[jira] [Commented] (MBUILDCACHE-37) Allow disabled-by-default configuration

2023-01-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676713#comment-17676713 ] ASF GitHub Bot commented on MBUILDCACHE-37: --- ahus1 commented on PR #37: URL

[GitHub] [maven-build-cache-extension] ahus1 commented on pull request #37: [MBUILDCACHE-37] Allow disabled-by-default configuration to be enabled on the CLI

2023-01-13 Thread GitBox
ahus1 commented on PR #37: URL: https://github.com/apache/maven-build-cache-extension/pull/37#issuecomment-1382182236 I'm looking forward to have this feature in a patch release as it would allow me to use this extension "opt in" for the developers of the Keycloak project. Thanks! -- Th

[jira] [Updated] (MBUILDCACHE-37) Allow disabled-by-default configuration

2023-01-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated MBUILDCACHE-37: -- Labels: pull-request-available (was: ) > Allow disabled-by-default configuration >

[jira] [Commented] (MBUILDCACHE-37) Allow disabled-by-default configuration

2023-01-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676705#comment-17676705 ] ASF GitHub Bot commented on MBUILDCACHE-37: --- ahus1 opened a new pull reques

[GitHub] [maven-build-cache-extension] ahus1 opened a new pull request, #37: [MBUILDCACHE-37] Allow disabled-by-default configuration to be enabled on the CLI

2023-01-13 Thread GitBox
ahus1 opened a new pull request, #37: URL: https://github.com/apache/maven-build-cache-extension/pull/37 This allows this plugin to be enabled on the CLI with ``` -Dmaven.build.cache.enabled=true ``` when it is disabled by default in the XML. --- Following t

[jira] [Commented] (SUREFIRE-2142) user.dir is changed in forkCount=0

2023-01-13 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676704#comment-17676704 ] Michael Osipov commented on SUREFIRE-2142: -- [~sjaranowski], what I a coincide

[GitHub] [maven-reporting-impl] michael-o commented on pull request #15: [MSHARED-480] Use maven-site-plugin's site.xml to use site's skin instead of default when run as mojo

2023-01-13 Thread GitBox
michael-o commented on PR #15: URL: https://github.com/apache/maven-reporting-impl/pull/15#issuecomment-1382143266 @hboutemy ping... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (DOXIA-685) Replace SinkEventAttributes#BOXED and clearly separate between regular verbatim and verbatim source (code)

2023-01-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676702#comment-17676702 ] ASF GitHub Bot commented on DOXIA-685: -- michael-o commented on PR #135: URL: https://

[GitHub] [maven] samkenxstream opened a new pull request, #957: Swcurity policy

2023-01-13 Thread GitBox
samkenxstream opened a new pull request, #957: URL: https://github.com/apache/maven/pull/957 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for

[GitHub] [maven-doxia] michael-o commented on pull request #135: [DOXIA-685] Replace SinkEventAttributes#BOXED and clearly separate between regular verbatim and verbatim source (code)

2023-01-13 Thread GitBox
michael-o commented on PR #135: URL: https://github.com/apache/maven-doxia/pull/135#issuecomment-1382142481 @hboutemy Please review on the weekend. This is the last change I want to merge for M5 and perform a release. -- This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (MSHARED-1132) Improved handling of system and user properties

2023-01-13 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676693#comment-17676693 ] Slawomir Jaranowski commented on MSHARED-1132: -- https://github.com/apache/

[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #232: Remove a few system properties before initializing the maven verifier

2023-01-13 Thread GitBox
slawekjaranowski commented on code in PR #232: URL: https://github.com/apache/maven-integration-testing/pull/232#discussion_r1069688846 ## core-it-suite/src/test/java/org/apache/maven/it/TestSuiteOrdering.java: ## @@ -50,6 +50,9 @@ private static void infoProperty( PrintStream

[jira] [Created] (SUREFIRE-2142) user.dir is changed in forkCount=0

2023-01-13 Thread Ivan Iliev (Jira)
Ivan Iliev created SUREFIRE-2142: Summary: user.dir is changed in forkCount=0 Key: SUREFIRE-2142 URL: https://issues.apache.org/jira/browse/SUREFIRE-2142 Project: Maven Surefire Issue Type: B

[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #226: [MNG-7661] Replace deprecated 'verifier.addCliOption()'

2023-01-13 Thread GitBox
slawekjaranowski merged PR #226: URL: https://github.com/apache/maven-integration-testing/pull/226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[jira] [Closed] (DOXIA-687) Introduce Sink#verbatim(void) method

2023-01-13 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIA-687. Resolution: Fixed Fixed with [3af3b81337e373e3f6a8b2c7cef02d0a0c839963|https://gitbox.apache.org/re

[jira] [Commented] (DOXIA-687) Introduce Sink#verbatim(void) method

2023-01-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676671#comment-17676671 ] ASF GitHub Bot commented on DOXIA-687: -- michael-o merged PR #140: URL: https://github

[GitHub] [maven-doxia] michael-o merged pull request #140: [DOXIA-687] Introduce Sink#verbatim(void) method

2023-01-13 Thread GitBox
michael-o merged PR #140: URL: https://github.com/apache/maven-doxia/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.a

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #231: [MENFORCER-458] Move Require Property,Environment to new API

2023-01-13 Thread GitBox
slawekjaranowski merged PR #231: URL: https://github.com/apache/maven-enforcer/pull/231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (DOXIA-687) Introduce Sink#verbatim(void) method

2023-01-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676641#comment-17676641 ] ASF GitHub Bot commented on DOXIA-687: -- michael-o opened a new pull request, #140: UR

[GitHub] [maven-doxia] michael-o opened a new pull request, #140: [DOXIA-687] Introduce Sink#verbatim(void) method

2023-01-13 Thread GitBox
michael-o opened a new pull request, #140: URL: https://github.com/apache/maven-doxia/pull/140 This closes #140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[jira] [Updated] (DOXIA-687) Introduce Sink#verbatim(void) method

2023-01-13 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIA-687: - Description: For the sake of convenience it is often sufficient to short cut {{sink.verbatim(null)

[jira] [Created] (DOXIA-687) Introduce Sink#verbatim(void) method

2023-01-13 Thread Michael Osipov (Jira)
Michael Osipov created DOXIA-687: Summary: Introduce Sink#verbatim(void) method Key: DOXIA-687 URL: https://issues.apache.org/jira/browse/DOXIA-687 Project: Maven Doxia Issue Type: Improvemen

[GitHub] [maven-integration-testing] gnodet commented on pull request #232: Remove a few system properties before initializing the maven verifier

2023-01-13 Thread GitBox
gnodet commented on PR #232: URL: https://github.com/apache/maven-integration-testing/pull/232#issuecomment-1381765022 The `maven.conf` is only used as a default in the `m2.conf`, so when using a non forked verifier, the current system property is set. It points to the maven home from the

[GitHub] [maven] slawekjaranowski merged pull request #953: Jenkinsfile: pickup results from ITs and Maven 3.8.x for build

2023-01-13 Thread GitBox
slawekjaranowski merged PR #953: URL: https://github.com/apache/maven/pull/953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

[GitHub] [maven-mvnd] meiMingle commented on issue #773: The built-in 4.0.0 version of maven will invalidate the flatten-maven-plugin plugin

2023-01-13 Thread GitBox
meiMingle commented on issue #773: URL: https://github.com/apache/maven-mvnd/issues/773#issuecomment-138152 Now the relevant PR has been merged into the main branch of maven, maybe this problem will disappear in the next version of maven [Restore compatibility with flatten-maven-plugi

[jira] [Commented] (SUREFIRE-2141) Surefire 3.0.0-M8 tests don't pass on Mac M1 (Surefire1295AttributeJvmCrashesToTestsIT)

2023-01-13 Thread Enrico Olivelli (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676537#comment-17676537 ] Enrico Olivelli commented on SUREFIRE-2141: --- In my experience all the new de

[GitHub] [maven-mvnd] gnodet commented on issue #773: The built-in 4.0.0 version of maven will invalidate the flatten-maven-plugin plugin

2023-01-13 Thread GitBox
gnodet commented on issue #773: URL: https://github.com/apache/maven-mvnd/issues/773#issuecomment-1381520092 Please provide a reproducer, as the short description won't be sufficient to understand what the problem is. -- This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (SUREFIRE-2141) Surefire 3.0.0-M8 tests don't pass on Mac M1 (Surefire1295AttributeJvmCrashesToTestsIT)

2023-01-13 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676535#comment-17676535 ] Tibor Digana commented on SUREFIRE-2141: Regarding the history, one of our con

[GitHub] [maven] psiroky commented on pull request #953: Jenkinsfile: pickup results from ITs and Maven 3.8.x for build

2023-01-13 Thread GitBox
psiroky commented on PR #953: URL: https://github.com/apache/maven/pull/953#issuecomment-1381488197 Looks good to me (my Jenkins knowledge is little rusty these days though). I can't approve the PR formally, so at least commenting here. -- This is an automated message from the Apache Git

[GitHub] [maven] slawekjaranowski commented on pull request #953: Jenkinsfile: pickup results from ITs and Maven 3.8.x for build

2023-01-13 Thread GitBox
slawekjaranowski commented on PR #953: URL: https://github.com/apache/maven/pull/953#issuecomment-1381470900 Failed jenkins build is from branch, when we create PR, jenkins not build branch any more and wrong status stay for ever 😄 -- This is an automated message from the Apache Git Serv

[jira] [Commented] (MDEP-405) purge-local-repository on multi-module project results in failure

2023-01-13 Thread Delany (Jira)
[ https://issues.apache.org/jira/browse/MDEP-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676512#comment-17676512 ] Delany commented on MDEP-405: - This goal seems broken by design - chicken-egg situation > purg

[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #226: [MNG-7661] Replace deprecated 'verifier.addCliOption()'

2023-01-13 Thread GitBox
slawekjaranowski commented on PR #226: URL: https://github.com/apache/maven-integration-testing/pull/226#issuecomment-1381466894 First I want to merge: https://github.com/apache/maven/pull/953 to be sure that tests are ok. -- This is an automated message from the Apache Git Service. To r

[GitHub] [maven-integration-testing] psiroky commented on pull request #226: [MNG-7661] Replace deprecated 'verifier.addCliOption()'

2023-01-13 Thread GitBox
psiroky commented on PR #226: URL: https://github.com/apache/maven-integration-testing/pull/226#issuecomment-1381463498 @cstamas no worries, the conflict was trivial to resolve. Should be ready now. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #231: Fix MavenITmng5669ReadPomsOnce

2023-01-13 Thread GitBox
slawekjaranowski merged PR #231: URL: https://github.com/apache/maven-integration-testing/pull/231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue