Support for Java 9+

2023-04-20 Thread Rodrigo Bourbon
Hi, I'm currently working with Java 11 and my project relies upon the maven-model and maven-model-builder artifacts. The problem is that both have the package

[GitHub] [maven-site] michael-o commented on a diff in pull request #410: document core is EOL before 3.8.8 (e.g we will not provide core release for bugs nor security issues).

2023-04-20 Thread via GitHub
michael-o commented on code in PR #410: URL: https://github.com/apache/maven-site/pull/410#discussion_r1173329710 ## content/markdown/docs/history.md.vm: ## @@ -61,6 +61,13 @@ $b_ ## Maven Releases History +The Apache Maven team maintains the last version of the last two

[GitHub] [maven-compiler-plugin] marquiswang opened a new pull request, #186: [MCOMPILER-333] Clean generatedSourcesDirectory along with outputDirectory

2023-04-20 Thread via GitHub
marquiswang opened a new pull request, #186: URL: https://github.com/apache/maven-compiler-plugin/pull/186 The generatedSourcesDirectory (by default target/generated-sources/annotations) contains source code generated by annotation processors. These generated sources are also outputs of

[GitHub] [maven-site] elharo commented on a diff in pull request #191: docs: system dependencies are not always available

2023-04-20 Thread via GitHub
elharo commented on code in PR #191: URL: https://github.com/apache/maven-site/pull/191#discussion_r1173130660 ## content/apt/guides/introduction/introduction-to-dependency-mechanism.apt: ## @@ -826,12 +826,14 @@ Introduction to the Dependency Mechanism <<>> -

[jira] [Commented] (MCOMPILER-333) Incremental compilation causes "mvn clean compile compile" to fail

2023-04-20 Thread Marquis Wang (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714763#comment-17714763 ] Marquis Wang commented on MCOMPILER-333: I have an example project that shows this:

[GitHub] [maven-site] olamy commented on pull request #410: document core is EOL before 3.8.8 (e.g we will not provide core release for bugs nor security issues).

2023-04-20 Thread via GitHub
olamy commented on PR #410: URL: https://github.com/apache/maven-site/pull/410#issuecomment-1516945897 thanks for review. changes applied -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-shared-utils] slawekjaranowski commented on pull request #113: [MSHARED-1072] fix blocking in StreamFeeder

2023-04-20 Thread via GitHub
slawekjaranowski commented on PR #113: URL: https://github.com/apache/maven-shared-utils/pull/113#issuecomment-1516939873 @michael-o refresh with current master, conflict resolved Tomorrow I would to check again. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [maven-site] michael-o commented on a diff in pull request #191: docs: system dependencies are not always available

2023-04-20 Thread via GitHub
michael-o commented on code in PR #191: URL: https://github.com/apache/maven-site/pull/191#discussion_r1173019092 ## pom.xml: ## @@ -55,7 +55,8 @@ maven-site -x Review Comment: Spotless 1藍 -- This is an automated message from the Apache Git Service. To

[GitHub] [maven-site] elharo commented on a diff in pull request #191: docs: system dependencies are not always available

2023-04-20 Thread via GitHub
elharo commented on code in PR #191: URL: https://github.com/apache/maven-site/pull/191#discussion_r1173015288 ## pom.xml: ## @@ -55,7 +55,8 @@ maven-site -x Review Comment: Yes, but necessary or the build breaks. I am less find of how spotless has been

[GitHub] [maven-shared-utils] michael-o commented on pull request #113: [MSHARED-1072] fix blocking in StreamFeeder

2023-04-20 Thread via GitHub
michael-o commented on PR #113: URL: https://github.com/apache/maven-shared-utils/pull/113#issuecomment-1516826066 @slawekjaranowski Do you want to pick this up? I want to relase Maven Release with this fix. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-remote-resources-plugin] michael-o commented on pull request #26: [MRRESOURCES-126] Get rid of legacy

2023-04-20 Thread via GitHub
michael-o commented on PR #26: URL: https://github.com/apache/maven-remote-resources-plugin/pull/26#issuecomment-1516824599 > As I see discussion here is about: > > * what version will be next > > * what name of goal should be > > > can we take such simple

[GitHub] [maven-site] michael-o commented on a diff in pull request #410: document core is EOL before 3.8.8 (e.g we will not provide core release for bugs nor security issues).

2023-04-20 Thread via GitHub
michael-o commented on code in PR #410: URL: https://github.com/apache/maven-site/pull/410#discussion_r1172990673 ## content/markdown/docs/history.md.vm: ## @@ -61,6 +61,13 @@ $b_ ## Maven Releases History +Apache Maven supports the last version of the last two series of

[GitHub] [maven-site] michael-o commented on a diff in pull request #191: docs: system dependencies are not always available

2023-04-20 Thread via GitHub
michael-o commented on code in PR #191: URL: https://github.com/apache/maven-site/pull/191#discussion_r1172989881 ## content/apt/guides/introduction/introduction-to-dependency-mechanism.apt: ## @@ -826,12 +826,14 @@ Introduction to the Dependency Mechanism <<>> -

[jira] [Created] (MASSEMBLY-984) Refresh download page

2023-04-20 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MASSEMBLY-984: - Summary: Refresh download page Key: MASSEMBLY-984 URL: https://issues.apache.org/jira/browse/MASSEMBLY-984 Project: Maven Assembly Plugin

[GitHub] [maven-site] rfscholte commented on pull request #191: docs: system dependencies are not always available

2023-04-20 Thread via GitHub
rfscholte commented on PR #191: URL: https://github.com/apache/maven-site/pull/191#issuecomment-1516706265 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [maven-compiler-plugin] slawekjaranowski commented on a diff in pull request #180: [MCOMPILER-391] Use dep mgmt when resolving annotation processors and their deps

2023-04-20 Thread via GitHub
slawekjaranowski commented on code in PR #180: URL: https://github.com/apache/maven-compiler-plugin/pull/180#discussion_r1172841557 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1584,42 +1605,91 @@ private List

[GitHub] [maven-compiler-plugin] psiroky commented on pull request #180: [MCOMPILER-391] Use dep mgmt when resolving annotation processors and their deps

2023-04-20 Thread via GitHub
psiroky commented on PR #180: URL: https://github.com/apache/maven-compiler-plugin/pull/180#issuecomment-1516621512 I can update the docs, based on the comments above. Besides that, the PR should be ready from my point of view. Please let me know if there is anything else that would need

[GitHub] [maven-dist-tool] dependabot[bot] closed pull request #30: Bump maven-reporting-exec from 2.0.0-M1 to 2.0.0-M6

2023-04-20 Thread via GitHub
dependabot[bot] closed pull request #30: Bump maven-reporting-exec from 2.0.0-M1 to 2.0.0-M6 URL: https://github.com/apache/maven-dist-tool/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-dist-tool] dependabot[bot] commented on pull request #30: Bump maven-reporting-exec from 2.0.0-M1 to 2.0.0-M6

2023-04-20 Thread via GitHub
dependabot[bot] commented on PR #30: URL: https://github.com/apache/maven-dist-tool/pull/30#issuecomment-1516282008 Superseded by #33. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-dist-tool] dependabot[bot] opened a new pull request, #33: Bump maven-reporting-exec from 2.0.0-M1 to 2.0.0-M7

2023-04-20 Thread via GitHub
dependabot[bot] opened a new pull request, #33: URL: https://github.com/apache/maven-dist-tool/pull/33 Bumps [maven-reporting-exec](https://github.com/apache/maven-reporting-exec) from 2.0.0-M1 to 2.0.0-M7. Commits

[GitHub] [maven-assembly-plugin] slawekjaranowski opened a new pull request, #132: [MASSEMBLY-974] Drop deprecated repository element from documentation

2023-04-20 Thread via GitHub
slawekjaranowski opened a new pull request, #132: URL: https://github.com/apache/maven-assembly-plugin/pull/132 Code was removed in 6c7b43c4e5a96bef884131e87b00942e5cd901dc We should update documentation according to change. --- Following this checklist to help us

[GitHub] [maven-site] cstamas commented on a diff in pull request #410: document core is EOL before 3.8.8 (e.g we will not provide core release for bugs nor security issues).

2023-04-20 Thread via GitHub
cstamas commented on code in PR #410: URL: https://github.com/apache/maven-site/pull/410#discussion_r1172522941 ## content/markdown/docs/history.md.vm: ## @@ -61,6 +61,13 @@ $b_ ## Maven Releases History +Apache Maven supports the last version of the last two series of GA

[GitHub] [maven-site] cstamas commented on pull request #410: document core is EOL before 3.8.8 (e.g we will not provide core release for bugs nor security issues).

2023-04-20 Thread via GitHub
cstamas commented on PR #410: URL: https://github.com/apache/maven-site/pull/410#issuecomment-1516248064 Agreed with @slawekjaranowski : we do not "support", we "maintain". Supporting something sounds to me like some contractual obligation, while we do not offer and "support contract" at

[GitHub] [maven-pmd-plugin] elharo commented on pull request #124: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)

2023-04-20 Thread via GitHub
elharo commented on PR #124: URL: https://github.com/apache/maven-pmd-plugin/pull/124#issuecomment-1516150217 In fact, now that I think about it, we should pause these changes until Moderne does sign the corporate CLA. An Individual CLA is insufficient given the co-authorship line. --

[GitHub] [maven-pmd-plugin] elharo commented on pull request #124: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)

2023-04-20 Thread via GitHub
elharo commented on PR #124: URL: https://github.com/apache/maven-pmd-plugin/pull/124#issuecomment-1516148340 The "co-authored" message has the potential to cause licensing and ownership issues. Alternately, Moderne could assign the corporate CLA:

[GitHub] [maven-pmd-plugin] elharo commented on pull request #120: [MNG-6825] Replace StringUtils with Commons Lang3

2023-04-20 Thread via GitHub
elharo commented on PR #120: URL: https://github.com/apache/maven-pmd-plugin/pull/120#issuecomment-1516145992 sure, if this is still relevant, do it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-gpg-plugin] michael-o commented on a diff in pull request #45: extract FilesCollector

2023-04-20 Thread via GitHub
michael-o commented on code in PR #45: URL: https://github.com/apache/maven-gpg-plugin/pull/45#discussion_r1172426963 ## src/main/java/org/apache/maven/plugins/gpg/FilesCollector.java: ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[jira] [Closed] (MNG-7038) Introduce public properties to point to the root and top directories of (multi-module) project

2023-04-20 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7038. Resolution: Fixed > Introduce public properties to point to the root and top directories of >

[jira] [Commented] (MNG-7038) Introduce public properties to point to the root and top directories of (multi-module) project

2023-04-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714542#comment-17714542 ] ASF GitHub Bot commented on MNG-7038: - gnodet merged PR #1061: URL:

[GitHub] [maven] gnodet merged pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-04-20 Thread via GitHub
gnodet merged PR #1061: URL: https://github.com/apache/maven/pull/1061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-integration-testing] gnodet merged pull request #254: [MNG-7038] Introduce project.rootdir, session.topdir and session.rootdir

2023-04-20 Thread via GitHub
gnodet merged PR #254: URL: https://github.com/apache/maven-integration-testing/pull/254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-compiler-plugin] olamy commented on pull request #185: Bump maven-invoker-plugin from 3.5.0 to 3.5.1

2023-04-20 Thread via GitHub
olamy commented on PR #185: URL: https://github.com/apache/maven-compiler-plugin/pull/185#issuecomment-1516112620 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-compiler-plugin] dependabot[bot] commented on pull request #185: Bump maven-invoker-plugin from 3.5.0 to 3.5.1

2023-04-20 Thread via GitHub
dependabot[bot] commented on PR #185: URL: https://github.com/apache/maven-compiler-plugin/pull/185#issuecomment-151611 Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`.

[GitHub] [maven-compiler-plugin] olamy commented on pull request #185: Bump maven-invoker-plugin from 3.5.0 to 3.5.1

2023-04-20 Thread via GitHub
olamy commented on PR #185: URL: https://github.com/apache/maven-compiler-plugin/pull/185#issuecomment-1516112176 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-pmd-plugin] timtebeek commented on pull request #120: [MNG-6825] Replace StringUtils with Commons Lang3

2023-04-20 Thread via GitHub
timtebeek commented on PR #120: URL: https://github.com/apache/maven-pmd-plugin/pull/120#issuecomment-1516024167 Would you like to see this recreated now that we have https://github.com/apache/maven-pmd-plugin/commit/40feea805e76b77446742c4278fabd7aff51 merged in? It'd swap even fewer

[jira] [Created] (MWRAPPER-108) mvnw script fails silently when download fails

2023-04-20 Thread selckin (Jira)
selckin created MWRAPPER-108: Summary: mvnw script fails silently when download fails Key: MWRAPPER-108 URL: https://issues.apache.org/jira/browse/MWRAPPER-108 Project: Maven Wrapper Issue Type:

[GitHub] [maven-wrapper] selckin opened a new pull request, #98: only-mvnw add error checking when download or unpacking fails

2023-04-20 Thread via GitHub
selckin opened a new pull request, #98: URL: https://github.com/apache/maven-wrapper/pull/98 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER) filed

[jira] [Updated] (MNG-7038) Introduce public properties to point to the root and top directories of (multi-module) project

2023-04-20 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-7038: - Summary: Introduce public properties to point to the root and top directories of (multi-module)

[jira] [Updated] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-04-20 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-7038: - Description: This issue introduces three properties: * {{project.rootDirectory}}: {_}the

[GitHub] [maven-pmd-plugin] timtebeek commented on pull request #124: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)

2023-04-20 Thread via GitHub
timtebeek commented on PR #124: URL: https://github.com/apache/maven-pmd-plugin/pull/124#issuecomment-1515932350 > You can assign these reviews to me. I might not get to all of them this quickly but they're not hard to review. Appreciate it! I'll start with the project that benefit

[GitHub] [maven-build-cache-extension] dependabot[bot] opened a new pull request, #71: Bump logback-classic from 1.3.6 to 1.3.7

2023-04-20 Thread via GitHub
dependabot[bot] opened a new pull request, #71: URL: https://github.com/apache/maven-build-cache-extension/pull/71 Bumps [logback-classic](https://github.com/qos-ch/logback) from 1.3.6 to 1.3.7. Commits

[jira] [Closed] (MRELEASE-1103) Decryption of server password in settings.xml failed (works with 2.5.3)

2023-04-20 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRELEASE-1103. Assignee: Tamas Cservenak Resolution: Fixed Fixed with

[GitHub] [maven-release] asfgit closed pull request #181: [MRELEASE-1103] Wrong file path used for master pw file

2023-04-20 Thread via GitHub
asfgit closed pull request #181: [MRELEASE-1103] Wrong file path used for master pw file URL: https://github.com/apache/maven-release/pull/181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (MRELEASE-1103) Decryption of server password in settings.xml failed (works with 2.5.3)

2023-04-20 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRELEASE-1103: - Summary: Decryption of server password in settings.xml failed (works with 2.5.3)

[GitHub] [maven-release] asfgit closed pull request #182: [MRELEASE-851]: javaHome argument is now honored in InvokerMavenExecutor

2023-04-20 Thread via GitHub
asfgit closed pull request #182: [MRELEASE-851]: javaHome argument is now honored in InvokerMavenExecutor URL: https://github.com/apache/maven-release/pull/182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (MCHECKSTYLE-425) Checkstyle runs fail with "Path contains invalid character" since 3.2.0

2023-04-20 Thread Magnus Reftel (Jira)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714459#comment-17714459 ] Magnus Reftel commented on MCHECKSTYLE-425: --- Thank you for the analysis! I´ve reported it