[jira] [Updated] (MJAVADOC-768) javadoc has a hard time with JPMS and provided or optional module dependencies.

2023-08-17 Thread Henning Schmiedehausen (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Schmiedehausen updated MJAVADOC-768: Description: Check out this project:

[jira] [Created] (MJAVADOC-768) javadoc has a hard time with JPMS and provided or optional module dependencies.

2023-08-17 Thread Henning Schmiedehausen (Jira)
Henning Schmiedehausen created MJAVADOC-768: --- Summary: javadoc has a hard time with JPMS and provided or optional module dependencies. Key: MJAVADOC-768 URL:

[jira] [Commented] (MJAVADOC-767) javadoc creates invalid --patch-module statements

2023-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755797#comment-17755797 ] ASF GitHub Bot commented on MJAVADOC-767: - hgschmie commented on PR #225: URL:

[GitHub] [maven-javadoc-plugin] hgschmie commented on pull request #225: [MJAVADOC-767] javadoc creates invalid --patch-module statements

2023-08-17 Thread via GitHub
hgschmie commented on PR #225: URL: https://github.com/apache/maven-javadoc-plugin/pull/225#issuecomment-1683340371 added integration test. To try out, remove this line:

[jira] [Closed] (MSHARED-1297) Prefer JDK features over plexus-utils, plexus-io

2023-08-17 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1297. Resolution: Fixed > Prefer JDK features over plexus-utils, plexus-io >

[jira] [Commented] (MSHARED-1297) Prefer JDK features over plexus-utils, plexus-io

2023-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755709#comment-17755709 ] ASF GitHub Bot commented on MSHARED-1297: - slawekjaranowski merged PR #42: URL:

[GitHub] [maven-release] michael-o commented on a diff in pull request #198: [MRELEASE-1109] Support CI friendly versions

2023-08-17 Thread via GitHub
michael-o commented on code in PR #198: URL: https://github.com/apache/maven-release/pull/198#discussion_r1297769497 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java: ## @@ -89,6 +93,18 @@ public abstract class

[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2023-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755705#comment-17755705 ] ASF GitHub Bot commented on MRELEASE-1109: -- michael-o commented on code in PR #198: URL:

[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent

2023-08-17 Thread Romain Manni-Bucau (Jira)
[ https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755662#comment-17755662 ] Romain Manni-Bucau commented on MSOURCES-143: - [~ggregory] was not really "do whatever

[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent

2023-08-17 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755661#comment-17755661 ] Gary D. Gregory commented on MSOURCES-143: -- Hi [~sjaranowski]  I am sorry but I still don't

[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent

2023-08-17 Thread Romain Manni-Bucau (Jira)
[ https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755657#comment-17755657 ] Romain Manni-Bucau commented on MSOURCES-143: - [~ggregory] spdx or parent pom or cli

[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2023-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755651#comment-17755651 ] ASF GitHub Bot commented on MRELEASE-1109: -- kwin opened a new pull request, #198: URL:

[jira] [Assigned] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2023-08-17 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned MRELEASE-1109: - Assignee: Konrad Windszus > update-versions removes the CI-friendly

[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent

2023-08-17 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755616#comment-17755616 ] Gary D. Gregory commented on MSOURCES-143: -- I'm not sure what you are asking me or telling me.

[jira] [Updated] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2023-08-17 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated MRELEASE-1109: -- Component/s: prepare > update-versions removes the CI-friendly ${revisions} >

[jira] [Comment Edited] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2023-08-17 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755585#comment-17755585 ] Konrad Windszus edited comment on MRELEASE-1109 at 8/17/23 2:47 PM:

[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2023-08-17 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755585#comment-17755585 ] Konrad Windszus commented on MRELEASE-1109: --- The logic for rewriting the version at

[jira] [Commented] (MSHADE-454) Shade Plugin does not work with JDK 20

2023-08-17 Thread Patrick Barry (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755521#comment-17755521 ] Patrick Barry commented on MSHADE-454: -- Thanks Michael and Torsten! Will v 3.5.1 be available soon

[jira] [Commented] (MRELEASE-1054) [Git submodule] Wrong Change on scm submodule after release:prepare and failed on pushChange

2023-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755517#comment-17755517 ] ASF GitHub Bot commented on MRELEASE-1054: -- elharo commented on code in PR #196: URL:

[GitHub] [maven-release] elharo commented on a diff in pull request #196: [MRELEASE-1054] Support for excluding submodules changes.

2023-08-17 Thread via GitHub
elharo commented on code in PR #196: URL: https://github.com/apache/maven-release/pull/196#discussion_r1297127776 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java: ## @@ -118,6 +125,15 @@ public ReleaseResult execute(

[jira] [Commented] (MSHARED-1297) Prefer JDK features over plexus-utils, plexus-io

2023-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755515#comment-17755515 ] ASF GitHub Bot commented on MSHARED-1297: - elharo commented on code in PR #42: URL:

[jira] [Assigned] (MJAVADOC-763) JavadocReportTest.testExceptions is broken

2023-08-17 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MJAVADOC-763: Assignee: Elliotte Rusty Harold > JavadocReportTest.testExceptions is

[jira] [Commented] (MJAVADOC-763) JavadocReportTest.testExceptions is broken

2023-08-17 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755491#comment-17755491 ] Slawomir Jaranowski commented on MJAVADOC-763: -- [~elharo] - please take care about - fix

[jira] [Updated] (MJAVADOC-763) JavadocReportTest.testExceptions is broken

2023-08-17 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MJAVADOC-763: - Fix Version/s: 3.5.1 > JavadocReportTest.testExceptions is broken >

[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2023-08-17 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755458#comment-17755458 ] Konrad Windszus commented on MRELEASE-1109: --- The same is true for

[jira] [Commented] (MSHARED-1297) Prefer JDK features over plexus-utils, plexus-io

2023-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755436#comment-17755436 ] ASF GitHub Bot commented on MSHARED-1297: - slawekjaranowski commented on code in PR #42: URL:

[jira] [Commented] (MJAVADOC-767) javadoc creates invalid --patch-module statements

2023-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755432#comment-17755432 ] ASF GitHub Bot commented on MJAVADOC-767: - slawekjaranowski commented on PR #225: URL:

[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on pull request #225: [MJAVADOC-767] javadoc creates invalid --patch-module statements

2023-08-17 Thread via GitHub
slawekjaranowski commented on PR #225: URL: https://github.com/apache/maven-javadoc-plugin/pull/225#issuecomment-1681886572 please remember to add jira number in final commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (MJAVADOC-767) javadoc creates invalid --patch-module statements

2023-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755420#comment-17755420 ] ASF GitHub Bot commented on MJAVADOC-767: - slawekjaranowski commented on code in PR #225: URL:

[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on a diff in pull request #225: [MJAVADOC-767] javadoc creates invalid --patch-module statements

2023-08-17 Thread via GitHub
slawekjaranowski commented on code in PR #225: URL: https://github.com/apache/maven-javadoc-plugin/pull/225#discussion_r1296852969 ## src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java: ## @@ -4594,12 +4594,14 @@ private void addJavadocOptions( }

[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on a diff in pull request #225: [MJAVADOC-767] javadoc creates invalid --patch-module statements

2023-08-17 Thread via GitHub
slawekjaranowski commented on code in PR #225: URL: https://github.com/apache/maven-javadoc-plugin/pull/225#discussion_r1296852969 ## src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java: ## @@ -4594,12 +4594,14 @@ private void addJavadocOptions( }

[jira] [Commented] (MJAVADOC-767) javadoc creates invalid --patch-module statements

2023-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755419#comment-17755419 ] ASF GitHub Bot commented on MJAVADOC-767: - slawekjaranowski commented on code in PR #225: URL:

[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent

2023-08-17 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755413#comment-17755413 ] Slawomir Jaranowski commented on MSOURCES-143: -- For JDK 8 you use {{spdx-maven-plugin}} in

[jira] [Commented] (MRESOLVER-391) Scope mediation improvements

2023-08-17 Thread perdjesk (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755407#comment-17755407 ] perdjesk commented on MRESOLVER-391: In case the dependency mediation of the resolver could not

[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent

2023-08-17 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755389#comment-17755389 ] Michael Osipov commented on MSOURCES-143: - [~ggregory], does it work with 3.8.8? > Can't

[jira] [Commented] (MRELEASE-1054) [Git submodule] Wrong Change on scm submodule after release:prepare and failed on pushChange

2023-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755386#comment-17755386 ] ASF GitHub Bot commented on MRELEASE-1054: -- wuwen5 commented on code in PR #196: URL:

[GitHub] [maven-release] wuwen5 commented on a diff in pull request #196: [MRELEASE-1054] Support for excluding submodules changes.

2023-08-17 Thread via GitHub
wuwen5 commented on code in PR #196: URL: https://github.com/apache/maven-release/pull/196#discussion_r1296750876 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java: ## @@ -199,13 +213,18 @@ private void transform(

[GitHub] [maven-release] wuwen5 commented on a diff in pull request #196: [MRELEASE-1054] Support for excluding submodules changes.

2023-08-17 Thread via GitHub
wuwen5 commented on code in PR #196: URL: https://github.com/apache/maven-release/pull/196#discussion_r1296739293 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java: ## @@ -118,6 +125,15 @@ public ReleaseResult execute(

[jira] [Commented] (MRELEASE-1054) [Git submodule] Wrong Change on scm submodule after release:prepare and failed on pushChange

2023-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755382#comment-17755382 ] ASF GitHub Bot commented on MRELEASE-1054: -- wuwen5 commented on code in PR #196: URL: