Re: [PR] [MNG-7982] Make transitive the default depMgr [maven]

2023-12-20 Thread via GitHub
rmannibucau commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1864394480 Hi @cstamas , what is the plan to identify mvn 4 consumed artifacts to switch the impl, using the mvn4 specific pom metadata file? in current state it breaks probably too easily IMHO an

[jira] [Commented] (MRESOLVER-462) Introduce transitive classic depMgr as well

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798973#comment-17798973 ] ASF GitHub Bot commented on MRESOLVER-462: -- cstamas opened a new pull request

[jira] [Commented] (MNG-7982) Make transitive depMgr the default, provide fallback to classic

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798974#comment-17798974 ] ASF GitHub Bot commented on MNG-7982: - rmannibucau commented on PR #1357: URL: https://

Re: [PR] Bump org.codehaus.plexus:plexus-cipher from 2.0 to 2.1.0 [maven-release]

2023-12-20 Thread via GitHub
elharo commented on PR #199: URL: https://github.com/apache/maven-release/pull/199#issuecomment-1864383378 Either tests are flaky or this change breaks the project: [INFO] Error: Failures: Error: PropertiesReleaseDescriptorStoreTest.testWriteEncryptedProperties:298 Values

Re: [PR] Bump org.codehaus.mojo:mrm-maven-plugin from 1.5.0 to 1.6.0 [maven-release]

2023-12-20 Thread via GitHub
elharo merged PR #200: URL: https://github.com/apache/maven-release/pull/200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

Re: [PR] [MRELEASE-1054] Support for excluding submodules changes. [maven-release]

2023-12-20 Thread via GitHub
elharo commented on code in PR #196: URL: https://github.com/apache/maven-release/pull/196#discussion_r1432644313 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java: ## @@ -199,13 +213,18 @@ private void transform(

[jira] [Commented] (MRELEASE-1054) [Git submodule] Wrong Change on scm submodule after release:prepare and failed on pushChange

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798966#comment-17798966 ] ASF GitHub Bot commented on MRELEASE-1054: -- elharo commented on code in PR #1

Re: [PR] Bump org.apache.maven.plugins:maven-invoker-plugin from 3.5.1 to 3.6.0 [maven-release]

2023-12-20 Thread via GitHub
elharo merged PR #204: URL: https://github.com/apache/maven-release/pull/204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

Re: [PR] Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.14.0 [maven-release]

2023-12-20 Thread via GitHub
elharo merged PR #205: URL: https://github.com/apache/maven-release/pull/205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[jira] [Created] (MRESOLVER-462) Introduce transitive classic depMgr as well

2023-12-20 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MRESOLVER-462: - Summary: Introduce transitive classic depMgr as well Key: MRESOLVER-462 URL: https://issues.apache.org/jira/browse/MRESOLVER-462 Project: Maven Resolver

[jira] [Commented] (MNG-7982) Make transitive depMgr the default, provide fallback to classic

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798939#comment-17798939 ] ASF GitHub Bot commented on MNG-7982: - cstamas opened a new pull request, #1357: URL: h

[jira] [Commented] (MRELEASE-1054) [Git submodule] Wrong Change on scm submodule after release:prepare and failed on pushChange

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798937#comment-17798937 ] ASF GitHub Bot commented on MRELEASE-1054: -- wuwen5 commented on PR #196: URL:

Re: [PR] [MRELEASE-1054] Support for excluding submodules changes. [maven-release]

2023-12-20 Thread via GitHub
wuwen5 commented on PR #196: URL: https://github.com/apache/maven-release/pull/196#issuecomment-1864331769 @elharo I have addressed the issues you pointed out, and I kindly request you to review the modified code. If you have any further suggestions or if there are additional changes neede

[jira] [Commented] (MRELEASE-1054) [Git submodule] Wrong Change on scm submodule after release:prepare and failed on pushChange

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798934#comment-17798934 ] ASF GitHub Bot commented on MRELEASE-1054: -- wuwen5 commented on code in PR #1

[jira] [Updated] (MNG-7960) Artifact collection filtering

2023-12-20 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7960: - Fix Version/s: 4.0.0-alpha-12 (was: 4.0.0-alpha-11) > Artifact collection fi

Re: [PR] [MRELEASE-1054] Support for excluding submodules changes. [maven-release]

2023-12-20 Thread via GitHub
wuwen5 commented on code in PR #196: URL: https://github.com/apache/maven-release/pull/196#discussion_r1432603322 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java: ## @@ -39,6 +43,7 @@ import org.apache.maven.shared.rele

[jira] [Commented] (MRELEASE-1054) [Git submodule] Wrong Change on scm submodule after release:prepare and failed on pushChange

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798932#comment-17798932 ] ASF GitHub Bot commented on MRELEASE-1054: -- wuwen5 commented on code in PR #1

Re: [PR] [MRELEASE-1054] Support for excluding submodules changes. [maven-release]

2023-12-20 Thread via GitHub
wuwen5 commented on code in PR #196: URL: https://github.com/apache/maven-release/pull/196#discussion_r1432603322 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java: ## @@ -39,6 +43,7 @@ import org.apache.maven.shared.rele

Re: [PR] Bump plexus-container-default from 2.1.0 to 2.1.1 [maven-doxia]

2023-12-20 Thread via GitHub
XN137 commented on PR #78: URL: https://github.com/apache/maven-doxia/pull/78#issuecomment-1864313875 the actual issue is linked above, i.e. checkstyle depends on an old doxia-core version (cant easily upgrade) which still pulls in `com.google.collections:google-collections` and with newer

[jira] [Commented] (MNG-7960) Artifact collection filtering

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798925#comment-17798925 ] ASF GitHub Bot commented on MNG-7960: - cstamas commented on PR #1353: URL: https://gith

Re: [PR] [MNG-7960] Version filtering [maven]

2023-12-20 Thread via GitHub
cstamas commented on PR #1353: URL: https://github.com/apache/maven/pull/1353#issuecomment-1864308325 This PR depends on new Resolver alpha release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Assigned] (MNG-7982) Make transitive depMgr the default, provide fallback to classic

2023-12-20 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-7982: Assignee: Tamas Cservenak > Make transitive depMgr the default, provide fallback to classic

[jira] [Closed] (MRESOLVER-461) DependencyManager cleanup

2023-12-20 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-461. - Resolution: Fixed > DependencyManager cleanup > - > >

[jira] [Commented] (MRESOLVER-461) DependencyManager cleanup

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798921#comment-17798921 ] ASF GitHub Bot commented on MRESOLVER-461: -- cstamas merged PR #402: URL: http

Re: [PR] [MRESOLVER-461] Cleanup in dep managers [maven-resolver]

2023-12-20 Thread via GitHub
cstamas merged PR #402: URL: https://github.com/apache/maven-resolver/pull/402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

[jira] [Commented] (MRESOLVER-461) DependencyManager cleanup

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798915#comment-17798915 ] ASF GitHub Bot commented on MRESOLVER-461: -- cstamas commented on PR #402: URL

Re: [PR] [MRESOLVER-461] Cleanup in dep managers [maven-resolver]

2023-12-20 Thread via GitHub
cstamas commented on PR #402: URL: https://github.com/apache/maven-resolver/pull/402#issuecomment-1864277556 Removed `ClassicDependencyManagerTest` and added new `DependencyManagerTest` UT tests all 3 of implementations (all aspects, not only Optional as Classic UT did) with comments sprink

[jira] [Commented] (MCOMPILER-567) Fail to compile if the "generated-sources/annotations" does not exist

2023-12-20 Thread Jeremy Norris (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798914#comment-17798914 ] Jeremy Norris commented on MCOMPILER-567: - Could this issue be related to the

[jira] [Commented] (MNG-7985) Provide project access to modified resources / test-resources and to the executionProject

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798913#comment-17798913 ] ASF GitHub Bot commented on MNG-7985: - gnodet opened a new pull request, #1356: URL: ht

[PR] [MNG-7985] Provide project access to modified resources / test-resources and to the executionProject [maven]

2023-12-20 Thread via GitHub
gnodet opened a new pull request, #1356: URL: https://github.com/apache/maven/pull/1356 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (MNG-7985) Provide project access to modified resources / test-resources and to the executionProject

2023-12-20 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-7985: Summary: Provide project access to modified resources / test-resources and to the executionProject Key: MNG-7985 URL: https://issues.apache.org/jira/browse/MNG-7985 P

[jira] [Updated] (MNG-7984) Provide a way to switch some defaults based on the model version used

2023-12-20 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-7984: - Description: For backward compatibility, it's a bit hard to change some defaults for the resolutio

[jira] [Created] (MNG-7984) Provide a way to switch some defaults based on the model version used

2023-12-20 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-7984: Summary: Provide a way to switch some defaults based on the model version used Key: MNG-7984 URL: https://issues.apache.org/jira/browse/MNG-7984 Project: Maven

[jira] [Comment Edited] (MCOMPILER-567) Fail to compile if the "generated-sources/annotations" does not exist

2023-12-20 Thread Stefan Cordes (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798896#comment-17798896 ] Stefan Cordes edited comment on MCOMPILER-567 at 12/20/23 10:01 AM:

[jira] [Commented] (MCOMPILER-567) Fail to compile if the "generated-sources/annotations" does not exist

2023-12-20 Thread Stefan Cordes (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798896#comment-17798896 ] Stefan Cordes commented on MCOMPILER-567: - I faced the similar error   {code:

[jira] [Commented] (MRESOLVER-461) DependencyManager cleanup

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798880#comment-17798880 ] ASF GitHub Bot commented on MRESOLVER-461: -- cstamas commented on PR #402: URL

Re: [PR] [MRESOLVER-461] Cleanup in dep managers [maven-resolver]

2023-12-20 Thread via GitHub
cstamas commented on PR #402: URL: https://github.com/apache/maven-resolver/pull/402#issuecomment-1864124041 OK, the resolver master - maven master - maven IT master ran OK, so this shows that "classic" was undisturbed. Next will do UTs and will merge this as I have your approvals.

[jira] [Commented] (MCOMPILER-567) Fail to compile if the "generated-sources/annotations" does not exist

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798879#comment-17798879 ] ASF GitHub Bot commented on MCOMPILER-567: -- slawekjaranowski commented on cod

Re: [PR] [MCOMPILER-567] - Fail to compile if the generated-sources/annotation… [maven-compiler-plugin]

2023-12-20 Thread via GitHub
slawekjaranowski commented on code in PR #218: URL: https://github.com/apache/maven-compiler-plugin/pull/218#discussion_r1432450761 ## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ## @@ -1172,6 +1172,8 @@ public void execute() throws MojoExecutionEx

[jira] [Commented] (MRESOLVER-461) DependencyManager cleanup

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798871#comment-17798871 ] ASF GitHub Bot commented on MRESOLVER-461: -- cstamas commented on PR #402: URL

Re: [PR] [MRESOLVER-461] Cleanup in dep managers [maven-resolver]

2023-12-20 Thread via GitHub
cstamas commented on PR #402: URL: https://github.com/apache/maven-resolver/pull/402#issuecomment-1864094984 thing is: will do resolver - maven - IT run to test classic, but other two was never tested (so i can be only certain did not break them). Will also add UTs as only classic has rudim

[jira] [Commented] (MRESOLVER-461) DependencyManager cleanup

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798869#comment-17798869 ] ASF GitHub Bot commented on MRESOLVER-461: -- cstamas commented on PR #402: URL

Re: [PR] [MRESOLVER-461] Cleanup in dep managers [maven-resolver]

2023-12-20 Thread via GitHub
cstamas commented on PR #402: URL: https://github.com/apache/maven-resolver/pull/402#issuecomment-1864090175 Yes, a cleanup -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (MRESOLVER-461) DependencyManager cleanup

2023-12-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798855#comment-17798855 ] ASF GitHub Bot commented on MRESOLVER-461: -- michael-o commented on PR #402: U

Re: [PR] [MRESOLVER-461] Cleanup in dep managers [maven-resolver]

2023-12-20 Thread via GitHub
michael-o commented on PR #402: URL: https://github.com/apache/maven-resolver/pull/402#issuecomment-1864028871 There is no logical change, but only pulled up to a super class? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

<    1   2