[PR] Remove experimental bit from buildconsumer [maven]

2024-01-08 Thread via GitHub
gnodet opened a new pull request, #1364: URL: https://github.com/apache/maven/pull/1364 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Remove experimental bit from buildconsumer [maven-integration-testing]

2024-01-08 Thread via GitHub
gnodet opened a new pull request, #331: URL: https://github.com/apache/maven-integration-testing/pull/331 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fixed a typo in ComparableVersionTest.java [maven]

2024-01-08 Thread via GitHub
gnodet merged PR #1363: URL: https://github.com/apache/maven/pull/1363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804586#comment-17804586 ] ASF GitHub Bot commented on MNG-7983: - gnodet merged PR #1358: URL:

[jira] [Closed] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7983. Resolution: Fixed > Update to Slf4j 2.x > --- > > Key: MNG-7983 >

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
gnodet merged PR #1358: URL: https://github.com/apache/maven/pull/1358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Bump org.apache.rat:apache-rat-plugin from 0.15 to 0.16 [maven-apache-parent]

2024-01-08 Thread via GitHub
dependabot[bot] opened a new pull request, #185: URL: https://github.com/apache/maven-apache-parent/pull/185 Bumps org.apache.rat:apache-rat-plugin from 0.15 to 0.16. [![Dependabot compatibility

[jira] [Commented] (MNG-5862) POM XML parser needs XInclude and/or XML Entity support

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804551#comment-17804551 ] ASF GitHub Bot commented on MNG-5862: - pdeneve commented on PR #1205: URL:

Re: [PR] [MNG-5862] Support XML entities and XInclude [maven]

2024-01-08 Thread via GitHub
pdeneve commented on PR #1205: URL: https://github.com/apache/maven/pull/1205#issuecomment-1882239484 @gnodet Thanks for you work. Any plans on resolving the requested change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 [maven-javadoc-plugin]

2024-01-08 Thread via GitHub
elharo commented on PR #260: URL: https://github.com/apache/maven-javadoc-plugin/pull/260#issuecomment-1882224798 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump org.codehaus.plexus:plexus-interactivity-api from 1.1 to 1.2 [maven-javadoc-plugin]

2024-01-08 Thread via GitHub
dependabot[bot] commented on PR #258: URL: https://github.com/apache/maven-javadoc-plugin/pull/258#issuecomment-1882224309 Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate

Re: [PR] Bump org.codehaus.plexus:plexus-interactivity-api from 1.1 to 1.2 [maven-javadoc-plugin]

2024-01-08 Thread via GitHub
elharo commented on PR #258: URL: https://github.com/apache/maven-javadoc-plugin/pull/258#issuecomment-1882224191 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump org.codehaus.plexus:plexus-io from 3.4.1 to 3.4.2 [maven-javadoc-plugin]

2024-01-08 Thread via GitHub
dependabot[bot] commented on PR #262: URL: https://github.com/apache/maven-javadoc-plugin/pull/262#issuecomment-1882223753 Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`.

Re: [PR] Bump org.codehaus.plexus:plexus-io from 3.4.1 to 3.4.2 [maven-javadoc-plugin]

2024-01-08 Thread via GitHub
elharo commented on PR #262: URL: https://github.com/apache/maven-javadoc-plugin/pull/262#issuecomment-1882223656 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.0 to 4.9.1 [maven-javadoc-plugin]

2024-01-08 Thread via GitHub
dependabot[bot] commented on PR #263: URL: https://github.com/apache/maven-javadoc-plugin/pull/263#issuecomment-1882223447 Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`.

Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.0 to 4.9.1 [maven-javadoc-plugin]

2024-01-08 Thread via GitHub
elharo commented on PR #263: URL: https://github.com/apache/maven-javadoc-plugin/pull/263#issuecomment-1882223358 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump org.codehaus.plexus:plexus-resources from 1.1.0 to 1.3.0 [maven-checkstyle-plugin]

2024-01-08 Thread via GitHub
elharo commented on PR #129: URL: https://github.com/apache/maven-checkstyle-plugin/pull/129#issuecomment-188252 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump org.codehaus.mojo:build-helper-maven-plugin from 3.4.0 to 3.5.0 [maven-checkstyle-plugin]

2024-01-08 Thread via GitHub
elharo merged PR #127: URL: https://github.com/apache/maven-checkstyle-plugin/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.14.0 [maven-checkstyle-plugin]

2024-01-08 Thread via GitHub
elharo merged PR #128: URL: https://github.com/apache/maven-checkstyle-plugin/pull/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump org.codehaus.plexus:plexus-component-metadata from 2.1.1 to 2.2.0 [maven-checkstyle-plugin]

2024-01-08 Thread via GitHub
elharo merged PR #131: URL: https://github.com/apache/maven-checkstyle-plugin/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Bump xml-apis:xml-apis from 1.4.01 to 2.0.2 [maven-doxia-sitetools]

2024-01-08 Thread via GitHub
dependabot[bot] opened a new pull request, #130: URL: https://github.com/apache/maven-doxia-sitetools/pull/130 Bumps xml-apis:xml-apis from 1.4.01 to 2.0.2. [![Dependabot compatibility

[PR] Bump org.codehaus.plexus:plexus-component-metadata from 2.1.1 to 2.2.0 [maven-doxia-sitetools]

2024-01-08 Thread via GitHub
dependabot[bot] opened a new pull request, #131: URL: https://github.com/apache/maven-doxia-sitetools/pull/131 Bumps [org.codehaus.plexus:plexus-component-metadata](https://github.com/codehaus-plexus/plexus-containers) from 2.1.1 to 2.2.0. Release notes Sourced from

[PR] Bump aetherVersion from 1.0.0.v20140518 to 1.1.0 [maven-doxia-sitetools]

2024-01-08 Thread via GitHub
dependabot[bot] opened a new pull request, #129: URL: https://github.com/apache/maven-doxia-sitetools/pull/129 Bumps `aetherVersion` from 1.0.0.v20140518 to 1.1.0. Updates `org.eclipse.aether:aether-api` from 1.0.0.v20140518 to 1.1.0 Updates `org.eclipse.aether:aether-impl` from

[PR] Bump mavenVersion from 3.2.5 to 3.3.9 [maven-doxia-sitetools]

2024-01-08 Thread via GitHub
dependabot[bot] opened a new pull request, #128: URL: https://github.com/apache/maven-doxia-sitetools/pull/128 Bumps `mavenVersion` from 3.2.5 to 3.3.9. Updates `org.apache.maven:maven-artifact` from 3.2.5 to 3.3.9 Commits

[jira] [Commented] (MPLUGIN-502) NPE in EnhancedPluginDescriptorBuilder with Maven 4.x

2024-01-08 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804462#comment-17804462 ] Slawomir Jaranowski commented on MPLUGIN-502: - Fix was in MINVOKER-313

[jira] [Created] (MINDEXER-215) Refresh download page

2024-01-08 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MINDEXER-215: Summary: Refresh download page Key: MINDEXER-215 URL: https://issues.apache.org/jira/browse/MINDEXER-215 Project: Maven Indexer Issue Type:

[jira] [Created] (MPLUGIN-503) Preserve some goal prefixes as "reserved"

2024-01-08 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MPLUGIN-503: --- Summary: Preserve some goal prefixes as "reserved" Key: MPLUGIN-503 URL: https://issues.apache.org/jira/browse/MPLUGIN-503 Project: Maven Plugin Tools

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804420#comment-17804420 ] ASF GitHub Bot commented on MNG-7983: - ceki commented on PR #1358: URL:

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
ceki commented on PR #1358: URL: https://github.com/apache/maven/pull/1358#issuecomment-1881626709 @gnodet @michael-o SLF4J version 2.0.11 was released a few moments ago. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] Fixed a typo in ComparableVersionTest.java [maven]

2024-01-08 Thread via GitHub
oblivia-simplex opened a new pull request, #1363: URL: https://github.com/apache/maven/pull/1363 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804377#comment-17804377 ] ASF GitHub Bot commented on MNG-7983: - michael-o commented on PR #1358: URL:

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
michael-o commented on PR #1358: URL: https://github.com/apache/maven/pull/1358#issuecomment-1881478240 Very nice. Let's wait for 2.0.11 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804345#comment-17804345 ] ASF GitHub Bot commented on MNG-7983: - gnodet commented on code in PR #1358: URL:

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444839810 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: @ceki there's a few

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804326#comment-17804326 ] ASF GitHub Bot commented on MNG-7983: - ceki commented on code in PR #1358: URL:

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444745560 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: @michael-o >

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804316#comment-17804316 ] ASF GitHub Bot commented on MNG-7983: - ceki commented on code in PR #1358: URL:

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444724098 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: @gnodet Also changed

Re: [PR] Improve transfer listener speed [maven]

2024-01-08 Thread via GitHub
michael-o commented on PR #1302: URL: https://github.com/apache/maven/pull/1302#issuecomment-1881105335 > I think this is a good change despite no "speedup" sensed: the original class uses `synchronized` on each listener method, meaning at one time only one thread can enter only one

Re: [PR] Improve transfer listener speed [maven]

2024-01-08 Thread via GitHub
cstamas commented on PR #1302: URL: https://github.com/apache/maven/pull/1302#issuecomment-1881092448 I think this is a good change despite no "speedup" sensed: the original class uses `synchronized` on each listener method, meaning at one time only one thread can enter only one method...

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444705681 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: > do you think this

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804310#comment-17804310 ] ASF GitHub Bot commented on MNG-7983: - ceki commented on code in PR #1358: URL:

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804307#comment-17804307 ] ASF GitHub Bot commented on MNG-7983: - ceki commented on code in PR #1358: URL:

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444705681 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: q@gnodet Yes, of

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804305#comment-17804305 ] ASF GitHub Bot commented on MNG-7983: - ceki commented on code in PR #1358: URL:

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444705681 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: @gnodet Yes, of

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
michael-o commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444692629 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: > @michael-o

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804301#comment-17804301 ] ASF GitHub Bot commented on MNG-7983: - michael-o commented on code in PR #1358: URL:

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804303#comment-17804303 ] ASF GitHub Bot commented on MNG-7983: - michael-o commented on code in PR #1358: URL:

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
michael-o commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444691847 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: > Changing the

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804282#comment-17804282 ] ASF GitHub Bot commented on MNG-7983: - gnodet commented on code in PR #1358: URL:

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804281#comment-17804281 ] ASF GitHub Bot commented on MNG-7983: - gnodet commented on code in PR #1358: URL:

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444651954 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Changing the

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804280#comment-17804280 ] ASF GitHub Bot commented on MNG-7983: - gnodet commented on code in PR #1358: URL:

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444651954 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Changing the

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444651954 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Changing the

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804279#comment-17804279 ] ASF GitHub Bot commented on MNG-7983: - ceki commented on code in PR #1358: URL:

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444644182 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: > Not really, at

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804277#comment-17804277 ] ASF GitHub Bot commented on MNG-7983: - ceki commented on code in PR #1358: URL:

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
ceki commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444641468 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: @michael-o

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804273#comment-17804273 ] ASF GitHub Bot commented on MNG-7983: - gnodet commented on code in PR #1358: URL:

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444634578 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: See

Re: [PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 [maven-archiver]

2024-01-08 Thread via GitHub
elharo merged PR #50: URL: https://github.com/apache/maven-archiver/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump org.apache.maven.shared:maven-shared-components from 40 to 41 [maven-archiver]

2024-01-08 Thread via GitHub
elharo merged PR #45: URL: https://github.com/apache/maven-archiver/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.8.0 to 4.9.1 [maven-archiver]

2024-01-08 Thread via GitHub
elharo merged PR #48: URL: https://github.com/apache/maven-archiver/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump org.codehaus.plexus:plexus-interpolation from 1.26 to 1.27 [maven-archiver]

2024-01-08 Thread via GitHub
elharo merged PR #47: URL: https://github.com/apache/maven-archiver/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (MCOMPILER-424) Annotation processor fails with AnnotationTypeMismatchException on Java 11 which targets Java 8

2024-01-08 Thread Marian Macik (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804269#comment-17804269 ] Marian Macik edited comment on MCOMPILER-424 at 1/8/24 1:15 PM: Thank

[jira] [Commented] (MCOMPILER-424) Annotation processor fails with AnnotationTypeMismatchException on Java 11 which targets Java 8

2024-01-08 Thread Marian Macik (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804269#comment-17804269 ] Marian Macik commented on MCOMPILER-424: Thank you [~kriegaex] for having a look at this as

Re: [PR] Bump org.codehaus.plexus:plexus-resources from 1.2.0 to 1.3.0 [maven-pmd-plugin]

2024-01-08 Thread via GitHub
elharo merged PR #140: URL: https://github.com/apache/maven-pmd-plugin/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804263#comment-17804263 ] ASF GitHub Bot commented on MNG-7983: - gnodet commented on code in PR #1358: URL:

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804264#comment-17804264 ] ASF GitHub Bot commented on MNG-7983: - gnodet commented on code in PR #1358: URL:

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444594238 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Not really, at

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
gnodet commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444594238 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Not really, at

Re: [PR] Improve transfer listener speed [maven]

2024-01-08 Thread via GitHub
michael-o commented on PR #1302: URL: https://github.com/apache/maven/pull/1302#issuecomment-1880955503 Can you quatify the speed improvement in percent? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804259#comment-17804259 ] ASF GitHub Bot commented on MNG-7983: - michael-o commented on code in PR #1358: URL:

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
michael-o commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444577122 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Won't this cause

[jira] [Commented] (MNG-7983) Update to Slf4j 2.x

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804257#comment-17804257 ] ASF GitHub Bot commented on MNG-7983: - michael-o commented on code in PR #1358: URL:

Re: [PR] [MNG-7983] Switch to slf4j-api 2 [maven]

2024-01-08 Thread via GitHub
michael-o commented on code in PR #1358: URL: https://github.com/apache/maven/pull/1358#discussion_r1444577122 ## pom.xml: ## @@ -180,7 +180,8 @@ under the License. 2.0.0-alpha-5 2.0 0.9.0.M2 -1.7.36 +2.0.9 +1.7.36 Review Comment: Won't this cause

[jira] [Updated] (MNG-7982) Switch to enable transitivity in depMgr used by Maven

2024-01-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7982: - Fix Version/s: 4.0.0-alpha-11 (was: 4.0.0-alpha-12) > Switch to enable

[jira] [Updated] (MNG-7960) Artifact collection filtering

2024-01-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7960: - Fix Version/s: 4.0.0-alpha-11 (was: 4.0.0-alpha-12) > Artifact collection

[jira] [Commented] (MNG-7982) Switch to enable transitivity in depMgr used by Maven

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804247#comment-17804247 ] ASF GitHub Bot commented on MNG-7982: - cstamas commented on PR #1357: URL:

Re: [PR] [MNG-7982] Switch to enable transitivity in depMgr used by Maven [maven]

2024-01-08 Thread via GitHub
cstamas commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1880869332 > However, I have no idea what the impact is if one builds a project with the _transitive_ dependency manager, but uses it with the _classic_ one in Maven 3. Could that break the consumer

[jira] [Closed] (MNG-7173) MavenResolverModule is broken/incomplete

2024-01-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-7173. Resolution: Won't Fix > MavenResolverModule is broken/incomplete >

[jira] [Commented] (MNG-7173) MavenResolverModule is broken/incomplete

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804245#comment-17804245 ] ASF GitHub Bot commented on MNG-7173: - cstamas closed pull request #479: [MNG-7173] The

[jira] [Commented] (MNG-7173) MavenResolverModule is broken/incomplete

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804246#comment-17804246 ] ASF GitHub Bot commented on MNG-7173: - cstamas commented on PR #479: URL:

Re: [PR] [MNG-7173] The maven-resolver-provider:MavenResolverModule is broken [maven]

2024-01-08 Thread via GitHub
cstamas commented on PR #479: URL: https://github.com/apache/maven/pull/479#issuecomment-1880864067 This PR is defunct, Guice modules were removed in https://github.com/apache/maven/pull/1282 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [MNG-7173] The maven-resolver-provider:MavenResolverModule is broken [maven]

2024-01-08 Thread via GitHub
cstamas closed pull request #479: [MNG-7173] The maven-resolver-provider:MavenResolverModule is broken URL: https://github.com/apache/maven/pull/479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [EXPERIMENT] Expose depMgr to use with Maven [maven]

2024-01-08 Thread via GitHub
cstamas commented on PR #1000: URL: https://github.com/apache/maven/pull/1000#issuecomment-1880858859 Superseded by https://github.com/apache/maven/pull/1357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [EXPERIMENT] Expose depMgr to use with Maven [maven]

2024-01-08 Thread via GitHub
cstamas closed pull request #1000: [EXPERIMENT] Expose depMgr to use with Maven URL: https://github.com/apache/maven/pull/1000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [EXPERIMENT] Jetty transport [maven]

2024-01-08 Thread via GitHub
cstamas commented on PR #886: URL: https://github.com/apache/maven/pull/886#issuecomment-1880854298 This PR experiment is done, resolver has now JDK (added to Maven) and Jetty transport. Simplest way to use Jetty is to just define it as extension in `.mvn/extensions.xml` and it will

Re: [PR] [EXPERIMENT] Jetty transport [maven]

2024-01-08 Thread via GitHub
cstamas closed pull request #886: [EXPERIMENT] Jetty transport URL: https://github.com/apache/maven/pull/886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (MPLUGIN-502) NPE in EnhancedPluginDescriptorBuilder with Maven 4.x

2024-01-08 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804233#comment-17804233 ] Michael Osipov commented on MPLUGIN-502: Interesting, which of those commits do fix this issue?

[jira] [Closed] (MNG-7977) Do not resolve projects outside the reactor (revert MNG-1088)

2024-01-08 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7977. Resolution: Fixed > Do not resolve projects outside the reactor (revert MNG-1088) >

[jira] [Commented] (MNG-7977) Do not resolve projects outside the reactor (revert MNG-1088)

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804227#comment-17804227 ] ASF GitHub Bot commented on MNG-7977: - gnodet merged PR #1330: URL:

Re: [PR] [MNG-7977] Fix reactor reader to not resolve any artifacts from projects being built outside the reactor [maven]

2024-01-08 Thread via GitHub
gnodet merged PR #1330: URL: https://github.com/apache/maven/pull/1330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Disable MNG-1088 test for MNG-7977 [maven-integration-testing]

2024-01-08 Thread via GitHub
gnodet merged PR #329: URL: https://github.com/apache/maven-integration-testing/pull/329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (MNG-7995) Switch to JLine to provide line editing

2024-01-08 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7995. Resolution: Fixed > Switch to JLine to provide line editing >

[jira] [Commented] (MNG-7995) Switch to JLine to provide line editing

2024-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804226#comment-17804226 ] ASF GitHub Bot commented on MNG-7995: - gnodet merged PR #1279: URL:

Re: [PR] [MNG-7995] Switch to JLine to provide line editing [maven]

2024-01-08 Thread via GitHub
gnodet merged PR #1279: URL: https://github.com/apache/maven/pull/1279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (MNG-7995) Switch to JLine to provide line editing

2024-01-08 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-7995: Summary: Switch to JLine to provide line editing Key: MNG-7995 URL: https://issues.apache.org/jira/browse/MNG-7995 Project: Maven Issue Type: New Feature

  1   2   >