Re: [PR] Adjustments in new API related to PathType [maven]

2024-05-04 Thread via GitHub
rmannibucau commented on code in PR #1501: URL: https://github.com/apache/maven/pull/1501#discussion_r1590207944 ## api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java: ## @@ -18,6 +18,10 @@ */ package org.apache.maven.api; +import

[jira] [Updated] (MNG-8116) Plugin configuration can randomly fail in case of method overloading as it doesn't take into account implementation attribute

2024-05-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-8116: Summary: Plugin configuration can randomly fail in case of method overloading as it doesn't take

[jira] [Commented] (MINVOKER-335) Symlinks from source project are copied as file

2024-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843516#comment-17843516 ] ASF GitHub Bot commented on MINVOKER-335: - michael-o commented on PR #231: URL:

Re: [PR] [MINVOKER-335] Preserve symlinks for copied files [maven-invoker-plugin]

2024-05-04 Thread via GitHub
michael-o commented on PR #231: URL: https://github.com/apache/maven-invoker-plugin/pull/231#issuecomment-2094497350 This IT is incomplete because the GHA Windows runners are configured not like a regular machine. It fails for me: ``` Running pre-build script:

[PR] Adjustments in new API related to PathType [maven]

2024-05-04 Thread via GitHub
desruisseaux opened a new pull request, #1501: URL: https://github.com/apache/maven/pull/1501 This pull request makes the following changes in API related to `PathType`. Those changes are for supporting the development of the Maven compiler plugin: * Add new artifact types for

[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default

2024-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843508#comment-17843508 ] ASF GitHub Bot commented on MPMD-379: - michael-o commented on PR #144: URL:

Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]

2024-05-04 Thread via GitHub
michael-o commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094396908 Reminds of https://github.com/apache/maven-fluido-skin/pull/39#issuecomment-1166243030 -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default

2024-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843506#comment-17843506 ] ASF GitHub Bot commented on MPMD-379: - michael-o commented on PR #144: URL:

Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]

2024-05-04 Thread via GitHub
michael-o commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094373023 There it is: https://github.com/apache/maven-pmd-plugin/actions/runs/8953082426/job/24591196710#step:6:1942 -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default

2024-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843505#comment-17843505 ] ASF GitHub Bot commented on MPMD-379: - michael-o commented on PR #144: URL:

Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]

2024-05-04 Thread via GitHub
michael-o commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094372771 @mkolesnikov Please rework this with a followup PR. for now, the flow is broken. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default

2024-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843504#comment-17843504 ] ASF GitHub Bot commented on MPMD-379: - michael-o commented on code in PR #144: URL:

Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]

2024-05-04 Thread via GitHub
michael-o commented on code in PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#discussion_r1590128034 ## src/main/java/org/apache/maven/plugins/pmd/exec/CpdExecutor.java: ## @@ -155,46 +149,50 @@ private CpdResult run() throws MavenReportException {

[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default

2024-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843503#comment-17843503 ] ASF GitHub Bot commented on MPMD-379: - michael-o commented on PR #144: URL:

Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]

2024-05-04 Thread via GitHub
michael-o commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094371392 This change introduced now a failing test which did no bubble up in CI, but should have: ``` [INFO] Running org.apache.maven.plugins.pmd.CpdReportTest

Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]

2024-05-04 Thread via GitHub
michael-o commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094369580 > @michael-o please abstain from statements like these. Any contribution is welcome, and mistakes do happen (yes, squashing the PR would be good, but this is not the end of the

[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default

2024-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843502#comment-17843502 ] ASF GitHub Bot commented on MPMD-379: - michael-o commented on PR #144: URL:

[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default

2024-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843501#comment-17843501 ] ASF GitHub Bot commented on MPMD-379: - cstamas commented on PR #144: URL:

Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]

2024-05-04 Thread via GitHub
cstamas commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094367940 @michael-o please abstain from statements like these. Any contribution is welcome, and mistakes do happen (yes, squashing the PR would be good, but this is not the end of the

[jira] [Commented] (MPMD-379) Upgrade to use PMD 7.0.0 by default

2024-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843500#comment-17843500 ] ASF GitHub Bot commented on MPMD-379: - michael-o commented on PR #144: URL:

Re: [PR] [MPMD-379] Upgrade to use PMD 7.0.0 by default [maven-pmd-plugin]

2024-05-04 Thread via GitHub
michael-o commented on PR #144: URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094353945 @adangel That merge was a pile of junk. You imported all intermediate work into master making it impossible to trace down the actual change. Don't do that again please, always

[jira] [Closed] (MSITE-1006) MSITE-723 causes duplicate document rendering and log output

2024-05-04 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSITE-1006. - Resolution: Fixed Fixed with

[jira] [Commented] (MSITE-1006) MSITE-723 causes duplicate document rendering and log output

2024-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSITE-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843472#comment-17843472 ] ASF GitHub Bot commented on MSITE-1006: --- asfgit merged PR #183: URL:

[jira] [Commented] (MSITE-1006) MSITE-723 causes duplicate document rendering and log output

2024-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSITE-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843471#comment-17843471 ] ASF GitHub Bot commented on MSITE-1006: --- asfgit closed pull request #183: [MSITE-1006] MSITE-723

Re: [PR] [MSITE-1006] MSITE-723 causes duplicate document rendering and log ou… [maven-site-plugin]

2024-05-04 Thread via GitHub
asfgit merged PR #183: URL: https://github.com/apache/maven-site-plugin/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [MSITE-1006] MSITE-723 causes duplicate document rendering and log ou… [maven-site-plugin]

2024-05-04 Thread via GitHub
asfgit closed pull request #183: [MSITE-1006] MSITE-723 causes duplicate document rendering and log ou… URL: https://github.com/apache/maven-site-plugin/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (MINVOKER-366) Require Maven 3.6.3

2024-05-04 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MINVOKER-366: Summary: Require Maven 3.6.3 Key: MINVOKER-366 URL: https://issues.apache.org/jira/browse/MINVOKER-366 Project: Maven Invoker Plugin Issue

[jira] [Commented] (MINVOKER-365) Allow to pre-build script to set user properties

2024-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843444#comment-17843444 ] ASF GitHub Bot commented on MINVOKER-365: - slawekjaranowski opened a new pull request, #236:

[jira] [Commented] (MSHARED-1390) Deprecate InvocationRequest#setGoals

2024-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843436#comment-17843436 ] ASF GitHub Bot commented on MSHARED-1390: - slawekjaranowski opened a new pull request, #76:

[jira] [Created] (MSHARED-1390) Deprecate InvocationRequest#setGoals

2024-05-04 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MSHARED-1390: Summary: Deprecate InvocationRequest#setGoals Key: MSHARED-1390 URL: https://issues.apache.org/jira/browse/MSHARED-1390 Project: Maven Shared

[jira] [Closed] (MSHARED-1389) Refresh download page

2024-05-04 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1389. Resolution: Fixed > Refresh download page > - > >

Re: [PR] [MSHARED-1389] Refresh download page [maven-invoker]

2024-05-04 Thread via GitHub
slawekjaranowski merged PR #75: URL: https://github.com/apache/maven-invoker/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'

2024-05-04 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1382. Fix Version/s: maven-invoker-next-release Assignee: Slawomir Jaranowski

[jira] [Closed] (MINVOKER-364) Rename invoker.systemPropertiesFile to invoker.userPropertiesFile

2024-05-04 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MINVOKER-364. Resolution: Fixed > Rename invoker.systemPropertiesFile to

[jira] [Commented] (MINVOKER-364) Rename invoker.systemPropertiesFile to invoker.userPropertiesFile

2024-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843424#comment-17843424 ] ASF GitHub Bot commented on MINVOKER-364: - slawekjaranowski merged PR #235: URL:

Re: [PR] [MINVOKER-364] Rename invoker.systemPropertiesFile to invoker.userPropertiesFile [maven-invoker-plugin]

2024-05-04 Thread via GitHub
slawekjaranowski merged PR #235: URL: https://github.com/apache/maven-invoker-plugin/pull/235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MNG-8084) Make the v4 api usable outside the Maven runtime

2024-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843396#comment-17843396 ] ASF GitHub Bot commented on MNG-8084: - hboutemy opened a new pull request, #1500: URL: