[GitHub] [maven] JurrianFahner commented on pull request #982: [MNG-7541] Implement powershell mvn command

2023-09-21 Thread via GitHub
JurrianFahner commented on PR #982: URL: https://github.com/apache/maven/pull/982#issuecomment-1730072787 > > > As a matter of fact, this implemenation should copy the approach from mvn.cmd from master, not from maven-3.9.x. It does not matter to add something new and then skim a bit later.

[GitHub] [maven] JurrianFahner commented on pull request #982: [MNG-7541] Implement powershell mvn command

2023-09-20 Thread via GitHub
JurrianFahner commented on PR #982: URL: https://github.com/apache/maven/pull/982#issuecomment-1728462781 > As a matter of fact, this implemenation should copy the approach from mvn.cmd from master, not from maven-3.9.x. It does not matter to add something new and then skim a bit later. The

[GitHub] [maven] JurrianFahner commented on pull request #982: [MNG-7541] Implement powershell mvn command

2023-09-11 Thread via GitHub
JurrianFahner commented on PR #982: URL: https://github.com/apache/maven/pull/982#issuecomment-1714361609 @michael-o I understand your reserves, certainly if your see your PS knowledge as humble (I don't see myself as an expert either). At the same time @slachiewicz has given an approval

[GitHub] [maven] JurrianFahner commented on pull request #982: [MNG-7541] Implement powershell mvn command

2023-08-01 Thread via GitHub
JurrianFahner commented on PR #982: URL: https://github.com/apache/maven/pull/982#issuecomment-1660960598 > > > Not now, ATM. I need to consult also a colleague who's proficient in PowerShell. > > > > > > Is there some progress? > > I hope to pick this up when my round with

[GitHub] [maven] JurrianFahner commented on pull request #982: [MNG-7541] Implement powershell mvn command

2023-06-06 Thread via GitHub
JurrianFahner commented on PR #982: URL: https://github.com/apache/maven/pull/982#issuecomment-1579424801 > Not now, ATM. I need to consult also a colleague who's proficient in PowerShell. Is there some progress? -- This is an automated message from the Apache Git Service. To respo

[GitHub] [maven] JurrianFahner commented on pull request #982: [MNG-7541] Implement powershell mvn command

2023-04-15 Thread via GitHub
JurrianFahner commented on PR #982: URL: https://github.com/apache/maven/pull/982#issuecomment-1509736721 @michael-o Can I do something to make this pull request merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [maven] JurrianFahner commented on pull request #982: [MNG-7541] Implement powershell mvn command

2023-03-17 Thread via GitHub
JurrianFahner commented on PR #982: URL: https://github.com/apache/maven/pull/982#issuecomment-1474351004 @michael-o @slachiewicz What do we need to do to merge this merge request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [maven] JurrianFahner commented on pull request #982: [MNG-7541] Implement powershell mvn command

2023-02-07 Thread via GitHub
JurrianFahner commented on PR #982: URL: https://github.com/apache/maven/pull/982#issuecomment-1421478703 @michael-o Should we remove `.cmd` in https://github.com/apache/maven/pull/877? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [maven] JurrianFahner commented on pull request #982: [MNG-7541] Implement powershell mvn command

2023-02-06 Thread via GitHub
JurrianFahner commented on PR #982: URL: https://github.com/apache/maven/pull/982#issuecomment-1419694222 @slachiewicz see here the pull request concerning the 3.9.x branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [maven] JurrianFahner commented on pull request #982: [MNG-7541] Implement powershell mvn command

2023-02-06 Thread via GitHub
JurrianFahner commented on PR #982: URL: https://github.com/apache/maven/pull/982#issuecomment-1419692902 After pulling the latest version of the core-its, it was running fine. So the core-its ran successfully. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven] JurrianFahner commented on pull request #982: [MNG-7541] Implement powershell mvn command

2023-02-05 Thread via GitHub
JurrianFahner commented on PR #982: URL: https://github.com/apache/maven/pull/982#issuecomment-1418284036 Core IT tests fails currently on `MavenITmng6609ProfileActivationForPackagingTest.testitMojoExecution:42->AbstractMavenIntegrationTestCase.assertEquals:668->AbstractMavenIntegrationTe