[GitHub] [maven] Tibor17 commented on issue #262: [MNG-6695] Improve speed in collection merging

Tibor17 commented on issue #262: [MNG-6695] Improve speed in collection merging URL: https://github.com/apache/maven/pull/262#issuecomment-524252280 In one hand this may speed up performace but on the second hand it will consume more memory because these three variables represent a cache:

[GitHub] [maven] Tibor17 commented on issue #262: [MNG-6695] Improve speed in collection merging

Tibor17 commented on issue #262: [MNG-6695] Improve speed in collection merging URL: https://github.com/apache/maven/pull/262#issuecomment-524247725 Can we use this fix in the release 3.6.2? This is an automated message from

[GitHub] [maven] Tibor17 commented on issue #262: [MNG-6695] Improve speed in collection merging

Tibor17 commented on issue #262: [MNG-6695] Improve speed in collection merging URL: https://github.com/apache/maven/pull/262#issuecomment-523044018 We have to squash the commits and trigger the build last time before pushing to master.

[GitHub] [maven] Tibor17 commented on issue #262: [MNG-6695] Improve speed in collection merging

Tibor17 commented on issue #262: [MNG-6695] Improve speed in collection merging URL: https://github.com/apache/maven/pull/262#issuecomment-522974362 @michael-o In the afternoon I will show you what I mean in another commit. Maybe I will have the answer from the author.

[GitHub] [maven] Tibor17 commented on issue #262: [MNG-6695] Improve speed in collection merging

Tibor17 commented on issue #262: [MNG-6695] Improve speed in collection merging URL: https://github.com/apache/maven/pull/262#issuecomment-515027946 @gnodet One pending answer for me! Is there any pragmatic reason (inheritance

[GitHub] [maven] Tibor17 commented on issue #262: [MNG-6695] Improve speed in collection merging

Tibor17 commented on issue #262: [MNG-6695] Improve speed in collection merging URL: https://github.com/apache/maven/pull/262#issuecomment-514825123 Go ahead but chane the `protected` inner classes to `private` (if possible). We have to hide our code as much as possible, otherwise we may

[GitHub] [maven] Tibor17 commented on issue #262: [MNG-6695] Improve speed in collection merging

Tibor17 commented on issue #262: [MNG-6695] Improve speed in collection merging URL: https://github.com/apache/maven/pull/262#issuecomment-514824083 This is whole problem with Maven code. Everything can be modified, no guarantees in memory and then concurrency troubles, collections which