cstamas commented on code in PR #893: URL: https://github.com/apache/maven/pull/893#discussion_r1038801109
########## maven-model-builder/src/main/java/org/apache/maven/model/superpom/DefaultSuperPomProvider.java: ########## @@ -52,8 +53,8 @@ public DefaultSuperPomProvider(ModelProcessor modelProcessor) { @Override public Model getSuperModel(String version) { - if (superModel == null) { - String resource = "/org/apache/maven/model/pom-" + version + ".xml"; + return SUPER_MODELS.computeIfAbsent(version, v -> { Review Comment: Does this mean that for example maven 4.0.1 could return super POM of Maven 3.8.6 (ie. newer could have all super POMs of older Mavens?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org