[GitHub] [maven] elharo commented on a diff in pull request #1015: Prefer Java standard library to Plexus util

2023-03-11 Thread via GitHub
elharo commented on code in PR #1015: URL: https://github.com/apache/maven/pull/1015#discussion_r1133081884 ## maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java: ## @@ -60,7 +59,7 @@ public void validate(Settings settings, S

[GitHub] [maven] elharo commented on a diff in pull request #1015: Prefer Java standard library to Plexus util

2023-03-01 Thread via GitHub
elharo commented on code in PR #1015: URL: https://github.com/apache/maven/pull/1015#discussion_r1121552266 ## maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java: ## @@ -60,7 +59,7 @@ public void validate(Settings settings, S

[GitHub] [maven] elharo commented on a diff in pull request #1015: Prefer Java standard library to Plexus util

2023-02-26 Thread via GitHub
elharo commented on code in PR #1015: URL: https://github.com/apache/maven/pull/1015#discussion_r1118159158 ## maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java: ## @@ -364,4 +364,12 @@ public void testMng7644() { checkVers