[GitHub] [maven] elharo commented on pull request #1185: [MNG-7830] Switch from plexus-xml to stax / woodstox

2023-06-28 Thread via GitHub
elharo commented on PR #1185: URL: https://github.com/apache/maven/pull/1185#issuecomment-1611802061 Might or might not be related: [INFO] Error: Errors: Error:DefaultMavenProjectBuilderTest.rereadPom_mng7063:334 � FileSystem

[GitHub] [maven] elharo commented on pull request #1185: [MNG-7830] Switch from plexus-xml to stax / woodstox

2023-06-28 Thread via GitHub
elharo commented on PR #1185: URL: https://github.com/apache/maven/pull/1185#issuecomment-1611800708 I am sure there are ways to fix that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven] elharo commented on pull request #1185: [MNG-7830] Switch from plexus-xml to stax / woodstox

2023-06-28 Thread via GitHub
elharo commented on PR #1185: URL: https://github.com/apache/maven/pull/1185#issuecomment-1611590027 Depending on spaces in the prolog is a bug. Tests should be comparing XML to XML, not XML to strings. The latter is extremely brittle and can cause tests to break even in minor upgrades of