[GitHub] [maven] elharo commented on pull request #347: [MNG-6802] Fix bug in FileProfileActivator

2021-05-14 Thread GitBox
elharo commented on pull request #347: URL: https://github.com/apache/maven/pull/347#issuecomment-841509780 jenkins failed again. Trying one more time: https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6802/6/ -- This is an automated message from the Apache Gi

[GitHub] [maven] elharo commented on pull request #347: [MNG-6802] Fix bug in FileProfileActivator

2021-05-13 Thread GitBox
elharo commented on pull request #347: URL: https://github.com/apache/maven/pull/347#issuecomment-840820479 There are a lot of test failures I don't immediately understand. I don't usually work on the core, so you might need to find someone else to help analyze these. -- This is an aut

[GitHub] [maven] elharo commented on pull request #347: [MNG-6802] Fix bug in FileProfileActivator

2021-05-05 Thread GitBox
elharo commented on pull request #347: URL: https://github.com/apache/maven/pull/347#issuecomment-832651826 rerunning jenkins: https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6802/3/ -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [maven] elharo commented on pull request #347: [MNG-6802] Fix bug in FileProfileActivator

2021-04-18 Thread GitBox
elharo commented on pull request #347: URL: https://github.com/apache/maven/pull/347#issuecomment-821977862 I restarted the integration test jobs. However those are weird failure messages I don't understand so let's be careful about checking this in. They don't look like a typical temporar

[GitHub] [maven] elharo commented on pull request #347: [MNG-6802] Fix bug in FileProfileActivator

2020-05-26 Thread GitBox
elharo commented on pull request #347: URL: https://github.com/apache/maven/pull/347#issuecomment-634218893 see my comment at the end of that issue: plexus-utils and maven-shared-utils are not as well maintained or reliable as commons-lang. I'd pick commons-lang over either of those, given