[GitHub] [maven] gnodet commented on a diff in pull request #812: [MNG-6437] Better support for path and uri in property interpolation

2023-09-22 Thread via GitHub
gnodet commented on code in PR #812: URL: https://github.com/apache/maven/pull/812#discussion_r1334753117 ## maven-core/src/main/java/org/apache/maven/plugin/ReflectionValueExtractor.java: ## @@ -261,22 +265,14 @@ private static Object getPropertyValue(Object value, String prop

[GitHub] [maven] gnodet commented on a diff in pull request #812: [MNG-6437] Better support for path and uri in property interpolation

2022-10-09 Thread GitBox
gnodet commented on code in PR #812: URL: https://github.com/apache/maven/pull/812#discussion_r990825335 ## maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluatorV4.java: ## @@ -343,13 +352,13 @@ else if ( expression.startsWith( "settings" ) )

[GitHub] [maven] gnodet commented on a diff in pull request #812: [MNG-6437] Better support for path and uri in property interpolation

2022-10-09 Thread GitBox
gnodet commented on code in PR #812: URL: https://github.com/apache/maven/pull/812#discussion_r990825137 ## maven-core/src/main/java/org/apache/maven/plugin/ReflectionValueExtractor.java: ## @@ -0,0 +1,366 @@ +package org.apache.maven.plugin; + +/* + * Licensed to the Apache Sof

[GitHub] [maven] gnodet commented on a diff in pull request #812: [MNG-6437] Better support for path and uri in property interpolation

2022-10-09 Thread GitBox
gnodet commented on code in PR #812: URL: https://github.com/apache/maven/pull/812#discussion_r990825070 ## maven-core/src/test/java/org/apache/maven/plugin/PluginParameterExpressionEvaluatorV4Test.java: ## @@ -0,0 +1,104 @@ +package org.apache.maven.plugin; + +/* + * Licensed t

[GitHub] [maven] gnodet commented on a diff in pull request #812: [MNG-6437] Better support for path and uri in property interpolation

2022-10-09 Thread GitBox
gnodet commented on code in PR #812: URL: https://github.com/apache/maven/pull/812#discussion_r990824233 ## maven-core/src/test/java/org/apache/maven/plugin/PluginParameterExpressionEvaluatorV4Test.java: ## @@ -0,0 +1,104 @@ +package org.apache.maven.plugin; + +/* + * Licensed t