[GitHub] [maven] gnodet commented on pull request #391: Mng 6957: Support Build Consumer while defining modules in reverse order

2020-11-29 Thread GitBox
gnodet commented on pull request #391: URL: https://github.com/apache/maven/pull/391#issuecomment-735603574 @rfscholte I've pushed a better commit for the `ReactorModelCache` at https://github.com/gnodet/maven/commit/e60fce46da6c783724f9b552b7e491a8efba4037 There's stil the cast in

[GitHub] [maven] gnodet commented on pull request #391: Mng 6957: Support Build Consumer while defining modules in reverse order

2020-11-29 Thread GitBox
gnodet commented on pull request #391: URL: https://github.com/apache/maven/pull/391#issuecomment-735455117 @rfscholte overall, because of the number of commits, it's really difficult to comment on the diffs, maybe at this point, a squashed commit would be easier to review, since there

[GitHub] [maven] gnodet commented on pull request #391: Mng 6957: Support Build Consumer while defining modules in reverse order

2020-11-28 Thread GitBox
gnodet commented on pull request #391: URL: https://github.com/apache/maven/pull/391#issuecomment-735286930 > I think the problem raised in [331e402](https://github.com/apache/maven/commit/331e402b1a7f6e158444984d1272aeff18f54549) and

[GitHub] [maven] gnodet commented on pull request #391: Mng 6957: Support Build Consumer while defining modules in reverse order

2020-11-28 Thread GitBox
gnodet commented on pull request #391: URL: https://github.com/apache/maven/pull/391#issuecomment-735264221 I think the problem raised in https://github.com/apache/maven/pull/402/commits/331e402b1a7f6e158444984d1272aeff18f54549 and