gnodet commented on pull request #690:
URL: https://github.com/apache/maven/pull/690#issuecomment-1066841960
I've tried a few things with your example and that led me to understand
something I had missed. If you define the following in the root pom:
```
gnodet commented on pull request #690:
URL: https://github.com/apache/maven/pull/690#issuecomment-1065909731
> I'm not sure if I can give more input on this, but only quote this
>
> > it really depends on the use case
>
> `WorkspaceReader` and `AbstractMavenLifecycleParticipant
gnodet commented on pull request #690:
URL: https://github.com/apache/maven/pull/690#issuecomment-1065402650
> > Isn't that exactly the opposite of what is done for lifecycle
participants and workspace readers at boot time ? Those are loaded from all
registered extensions for all projects
gnodet commented on pull request #690:
URL: https://github.com/apache/maven/pull/690#issuecomment-1065227468
>
> > I would assume some kind of implicit inheritance wrt to extensions.
Another way would be to create a realm that would have visibility on all
extensions of the
gnodet commented on pull request #690:
URL: https://github.com/apache/maven/pull/690#issuecomment-1065159566
> > Thoughts ?
>
> Looks like a good idea.
>
> > the top level project's realm is used by default during the duration of
the build
>
> I'm not sure why this shou
gnodet commented on pull request #690:
URL: https://github.com/apache/maven/pull/690#issuecomment-1065129222
@laeubi I've pushed another commit to discuss / experiment with.
There are only two remaining calls to `BuildCommon.attachToThread` which are
now clearly scoped in a block tha
gnodet commented on pull request #690:
URL: https://github.com/apache/maven/pull/690#issuecomment-1065043792
For the record, the lookup of the `MojosExecutionStrategy` which was
introduced by
https://github.com/apache/maven/commit/1954d51ff2841045b4af8a515ad0719805269d8d
is definitely wro
gnodet commented on pull request #690:
URL: https://github.com/apache/maven/pull/690#issuecomment-1064950742
> Just for references as I recently added support for project-scoped
WorkspaceReaders, if you like to support such components one needs to add
explicit support for them similar to:
gnodet commented on pull request #690:
URL: https://github.com/apache/maven/pull/690#issuecomment-1064530792
> Just another observation, it seems `MojosExecutionStrategy` was jsut
intorduced in maven `3.9.x` so how could it be a regression from `3.8.x`?
Because it has been developed
gnodet commented on pull request #690:
URL: https://github.com/apache/maven/pull/690#issuecomment-1064264508
I've added a commit to revert
https://github.com/apache/maven/commit/e327be3d85918a23a5ba48d752143a6dbf8b83f7
because it's useless.
This restores the behavior from 3.8.4 whe
gnodet commented on pull request #690:
URL: https://github.com/apache/maven/pull/690#issuecomment-1064222692
> > It _was_ leaking : the current PR still reverts at the end of the build.
>
> I don't think this is enough... as mentioned in the change, there is even
this classloader use
11 matches
Mail list logo
