[GitHub] [maven] hboutemy commented on pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type

2021-12-30 Thread GitBox
hboutemy commented on pull request #641: URL: https://github.com/apache/maven/pull/641#issuecomment-1003050980 @michael-o no problem to do the work in 2 steps, sure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [maven] hboutemy commented on pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type

2021-12-30 Thread GitBox
hboutemy commented on pull request #641: URL: https://github.com/apache/maven/pull/641#issuecomment-1002967160 no, I'm not trying to automagically retain the original type: I'm just trying to use the (hand-written) factory to remove code duplication digging a little bit more, it requ

[GitHub] [maven] hboutemy commented on pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type

2021-12-30 Thread GitBox
hboutemy commented on pull request #641: URL: https://github.com/apache/maven/pull/641#issuecomment-1002963399 @michael-o instead of copy/pasting the 3 methods, I think we could change "private Artifact newInstance" (from AbstractArtifact) to protected, then simply override this method -