subject:"\[GitHub\] \[maven\] michael\-o commented on a diff in pull request #812\: \[MNG\-6437\] Better support for path and uri in property interpolation"

[GitHub] [maven] michael-o commented on a diff in pull request #812: [MNG-6437] Better support for path and uri in property interpolation

2023-09-22 Thread via GitHub

michael-o commented on code in PR #812: URL: https://github.com/apache/maven/pull/812#discussion_r1334763479 ## maven-core/src/main/java/org/apache/maven/plugin/ReflectionValueExtractor.java: ## @@ -261,22 +265,14 @@ private static Object getPropertyValue(Object value, String p

[GitHub] [maven] michael-o commented on a diff in pull request #812: [MNG-6437] Better support for path and uri in property interpolation

2023-09-22 Thread via GitHub

michael-o commented on code in PR #812: URL: https://github.com/apache/maven/pull/812#discussion_r1334483743 ## maven-core/src/main/java/org/apache/maven/plugin/ReflectionValueExtractor.java: ## @@ -261,22 +265,14 @@ private static Object getPropertyValue(Object value, String p

[GitHub] [maven] michael-o commented on a diff in pull request #812: [MNG-6437] Better support for path and uri in property interpolation

2022-10-09 Thread GitBox

michael-o commented on code in PR #812: URL: https://github.com/apache/maven/pull/812#discussion_r990817790 ## maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluatorV4.java: ## @@ -343,13 +352,13 @@ else if ( expression.startsWith( "settings" ) )