[GitHub] [maven] michael-o commented on pull request #388: Refactor ProjectsCollector.collectProjects

2020-10-25 Thread GitBox
michael-o commented on pull request #388: URL: https://github.com/apache/maven/pull/388#issuecomment-716113439 @mthmulders I join @rfscholte opinion. The current naming isn't optimal. This is an automated message from the Apa

[GitHub] [maven] michael-o commented on pull request #388: Refactor ProjectsCollector.collectProjects

2020-10-23 Thread GitBox
michael-o commented on pull request #388: URL: https://github.com/apache/maven/pull/388#issuecomment-715345021 There are two issues here: 1. You are changin a public interface. I don't know whether this is acceptable 2. As far as I know collect methods they are supposed to receive whe

[GitHub] [maven] michael-o commented on pull request #388: Refactor ProjectsCollector.collectProjects

2020-10-23 Thread GitBox
michael-o commented on pull request #388: URL: https://github.com/apache/maven/pull/388#issuecomment-715327843 Can you tell what the purpose is behind this change? This is an automated message from the Apache Git Service. To