[GitHub] [maven] michael-o commented on pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type

michael-o commented on pull request #641: URL: https://github.com/apache/maven/pull/641#issuecomment-1003048363 https://issues.apache.org/jira/browse/MRESOLVER-233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [maven] michael-o commented on pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type

michael-o commented on pull request #641: URL: https://github.com/apache/maven/pull/641#issuecomment-1003047327 @hboutemy Any objections to merge this one and resolve in general with new issues? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [maven] michael-o commented on pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type

michael-o commented on pull request #641: URL: https://github.com/apache/maven/pull/641#issuecomment-1002970252 > no, I'm not trying to automagically retain the original type: I'm just trying to use the (hand-written) factory to remove code duplication Agree, suboptimal. > dig

[GitHub] [maven] michael-o commented on pull request #641: [MNG-7374] Mutating RelocatedArtifact does not retain type

michael-o commented on pull request #641: URL: https://github.com/apache/maven/pull/641#issuecomment-1002965979 > @michael-o instead of copy/pasting the 3 methods, I think we could change "private Artifact newInstance" (from AbstractArtifact) to protected, then simply override this method