[GitHub] [maven] michael-o commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)

2022-02-27 Thread GitBox
michael-o commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1053634921 @cstamas @gnodet @hboutemy Any objections in general? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [maven] michael-o commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)

2022-02-27 Thread GitBox
michael-o commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1053610312 Do you see this for 3.8.x as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven] michael-o commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)

2022-02-27 Thread GitBox
michael-o commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1053578715 Alright. Will check later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [maven] michael-o commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)

2022-02-27 Thread GitBox
michael-o commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1053532716 Is this one still relevant regarding the changes done on MPLUGIN? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [maven] michael-o commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)

2022-02-16 Thread GitBox
michael-o commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1041411056 No, not yet. Ping me in a week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [maven] michael-o commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)

2022-01-05 Thread GitBox
michael-o commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1005505425 > > Introduce a maven-repository-metadata-builder module > > Done in [d39be11](https://github.com/apache/maven/commit/d39be11613d20228a4e826302ef57adf19ba1194). This modul

[GitHub] [maven] michael-o commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)

2022-01-04 Thread GitBox
michael-o commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1005105026 > Correct, we pointlessly waste cycles for their generation. This applies to a lot of stuff we do. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [maven] michael-o commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)

2022-01-03 Thread GitBox
michael-o commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1004330642 I support @cstamas position. > > So, IMO maven-repository-metadata getting added components is wrong IMHO. > > Any suggestion where to add the default validation modu

[GitHub] [maven] michael-o commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)

2022-01-03 Thread GitBox
michael-o commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1004273279 > Metadata is only partially handled inside Maven (core), mostly it is now handled transparently in [Maven Resolver](https://github.com/apache/maven-resolver/blob/master/maven-re

[GitHub] [maven] michael-o commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)

2022-01-02 Thread GitBox
michael-o commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1003778248 @kwin Insane! Please open a new JIRA issue for this. I am thinking whether we can introduce this in 3.8.x or must wait at least until 3.9.x. We have a lot of talks about validato

[GitHub] [maven] michael-o commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)

2022-01-01 Thread GitBox
michael-o commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1003603066 I don't have access to the NEXUS issue :-( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven] michael-o commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)

2022-01-01 Thread GitBox
michael-o commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1003602899 > Both issues are correct but are rather follow-ups to [MNG-7375](https://issues.apache.org/jira/browse/MNG-7375). My question is about how to deal with a missing prefix within `

[GitHub] [maven] michael-o commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)

2022-01-01 Thread GitBox
michael-o commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1003586710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [maven] michael-o commented on pull request #645: [MNG-7375] prevent potential NPE in Metadata.merge(...)

2021-12-27 Thread GitBox
michael-o commented on pull request #645: URL: https://github.com/apache/maven/pull/645#issuecomment-1001510028 This PR hides the fact that the input data is invalid. Obviously, we need a `MetadataValidator`. -- This is an automated message from the Apache Git Service. To respond to the