[GitHub] [maven] rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process

2020-03-03 Thread GitBox
rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#issuecomment-594209038 Maven Shade Plugin was already marked for verifying handling the new poms, but existing projects should still work. When runni

[GitHub] [maven] rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process

2020-03-03 Thread GitBox
rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#issuecomment-594200332 How about Maven 3.6.3? Otherwise we need to git bisect it. On 3-3-2020 23:13:21, Enrico Olivelli wrote: It looks like I hav

[GitHub] [maven] rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process

2019-10-15 Thread GitBox
rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#issuecomment-542386341 I've moved the second read of the `pom.xml` with the additional BuildPomXMLFilters directly after the initial read of the pom, but be

[GitHub] [maven] rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#issuecomment-537226579 Here's how I see it: Maven 3.7.x+ : experiment with adjusting files using Model 4.0.0 Maven 4.0.0 : apply adjusting files using

[GitHub] [maven] rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process

2019-10-01 Thread GitBox
rfscholte commented on issue #286: [MNG-6656] Introduce base for build/consumer process URL: https://github.com/apache/maven/pull/286#issuecomment-537198294 > On the feature I have mainly one point: are the transformed pom and real project pom attached? Think it makes sense to attach both