[GitHub] [maven] rfscholte commented on pull request #391: Mng 6957: Support Build Consumer while defining modules in reverse order

2020-12-04 Thread GitBox
rfscholte commented on pull request #391: URL: https://github.com/apache/maven/pull/391#issuecomment-739040029 @gnodet I've added commit, see https://github.com/apache/maven/pull/391/commits/50e8beb59eee74bcce8281ebc4ae40a90883539e

[GitHub] [maven] rfscholte commented on pull request #391: Mng 6957: Support Build Consumer while defining modules in reverse order

2020-11-29 Thread GitBox
rfscholte commented on pull request #391: URL: https://github.com/apache/maven/pull/391#issuecomment-735466896 @gnodet thanks for reviewing. It doesn't make sense to review it per commit, I would suggest to comment on the total changes. In the end these commit will be squashed into on,

[GitHub] [maven] rfscholte commented on pull request #391: Mng 6957: Support Build Consumer while defining modules in reverse order

2020-11-29 Thread GitBox
rfscholte commented on pull request #391: URL: https://github.com/apache/maven/pull/391#issuecomment-735385774 All is required to fix the issue, there's no clear way to split it. This is an automated message from the Apache