[GitHub] [maven] rfscholte commented on pull request #402: DefaultProjectBuilder enhancements

2021-02-14 Thread GitBox
rfscholte commented on pull request #402: URL: https://github.com/apache/maven/pull/402#issuecomment-778797951 Merged with https://github.com/apache/maven/commit/619973b91cff5af7b5695bda11761a982a159349 which fixes MNG-7063. Thanks for this PR!

[GitHub] [maven] rfscholte commented on pull request #402: DefaultProjectBuilder enhancements

2021-02-12 Thread GitBox
rfscholte commented on pull request #402: URL: https://github.com/apache/maven/pull/402#issuecomment-778258696 ok, let me check that one first This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven] rfscholte commented on pull request #402: DefaultProjectBuilder enhancements

2021-02-12 Thread GitBox
rfscholte commented on pull request #402: URL: https://github.com/apache/maven/pull/402#issuecomment-778249119 I just had another look at this. It looks to me that this commit has become too big. We should split it into 2 pieces: * rewriting JUnit tests using maven-test-support. *

[GitHub] [maven] rfscholte commented on pull request #402: DefaultProjectBuilder enhancements

2021-01-15 Thread GitBox
rfscholte commented on pull request #402: URL: https://github.com/apache/maven/pull/402#issuecomment-761011299 I've written a unittest for MNG-7063. With this PR it succeeds again. This looks very promising. This is an

[GitHub] [maven] rfscholte commented on pull request #402: DefaultProjectBuilder enhancements

2021-01-09 Thread GitBox
rfscholte commented on pull request #402: URL: https://github.com/apache/maven/pull/402#issuecomment-756893732 Probably related is MNG-7063: if trying to read the same file multiple times (in this case {{dependency-reduced-pom.xml}}, it'll be picked up from cache. In this case the model

[GitHub] [maven] rfscholte commented on pull request #402: DefaultProjectBuilder enhancements

2021-01-08 Thread GitBox
rfscholte commented on pull request #402: URL: https://github.com/apache/maven/pull/402#issuecomment-756893732 Probably related is MNG-7063: if trying to read the same file multiple times (in this case {{dependency-reduced-pom.xml}}, it'll be picked up from cache. In this case the model