[GitHub] [maven] rfscholte commented on pull request #552: [MNG-7260] [MNG-7266] Remove maven-compat module

2021-09-29 Thread GitBox
rfscholte commented on pull request #552: URL: https://github.com/apache/maven/pull/552#issuecomment-930134227 IIRC @jvanzyl moved it, so maybe he remembers it. (this is also the reason why adding @deprecated is so so so important) -- This is an automated message from the Apache Git Serv

[GitHub] [maven] rfscholte commented on pull request #552: [MNG-7260] [MNG-7266] Remove maven-compat module

2021-09-29 Thread GitBox
rfscholte commented on pull request #552: URL: https://github.com/apache/maven/pull/552#issuecomment-930134227 IIRC @jvanzyl moved it, so maybe he remembers it. (this is also the reason why adding @deprecated is so so so important) -- This is an automated message from the Apache Git Serv

[GitHub] [maven] rfscholte commented on pull request #552: [MNG-7260] [MNG-7266] Remove maven-compat module

2021-09-27 Thread GitBox
rfscholte commented on pull request #552: URL: https://github.com/apache/maven/pull/552#issuecomment-927623306 I wonder if the deleted files should be removed or moved to a new `maven-compat3` module. I wouldn't be suprised if maven-plugins out these depend on one of these classes. -- T

[GitHub] [maven] rfscholte commented on pull request #552: [MNG-7260] [MNG-7266] Remove maven-compat module

2021-09-25 Thread GitBox
rfscholte commented on pull request #552: URL: https://github.com/apache/maven/pull/552#issuecomment-927130973 @MartinKanters and @mthmulders made a start with the 3.x implementation for these plugins. You could also say: Maven ITs shouldn't test the logic of plugins. For most we have a

[GitHub] [maven] rfscholte commented on pull request #552: [MNG-7260] [MNG-7266] Remove maven-compat module

2021-09-24 Thread GitBox
rfscholte commented on pull request #552: URL: https://github.com/apache/maven/pull/552#issuecomment-926521250 https://issues.apache.org/jira/browse/MNG-5995 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a