[GitHub] [maven-deploy-plugin] michael-o commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2023-01-22 Thread via GitHub
michael-o commented on PR #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-1399569124 Please delete this branch when this is done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [maven-deploy-plugin] michael-o commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2023-01-22 Thread via GitHub
michael-o commented on PR #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-1399559800 > I would to refresh this PR ... > > Simply m-deploy-p is not responsible for checksum generation, so should not be tested here ... This is also my stance. Please

[GitHub] [maven-deploy-plugin] michael-o commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2020-12-25 Thread GitBox
michael-o commented on pull request #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751289417 > > > But based on the Maven version we know the default generated checksum right? Theoretically, yes. You could add this to the configuration somehow.

[GitHub] [maven-deploy-plugin] michael-o commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2020-12-25 Thread GitBox
michael-o commented on pull request #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751289154 See my comment: https://issues.apache.org/jira/browse/MDEPLOY-231?focusedCommentId=17253097&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#com

[GitHub] [maven-deploy-plugin] michael-o commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2020-12-25 Thread GitBox
michael-o commented on pull request #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751288717 The problem with this is that it is not portable. It does not know which checksums are generated. It is assumed, but nothing else. --

[GitHub] [maven-deploy-plugin] michael-o commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2020-12-25 Thread GitBox
michael-o commented on pull request #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751253385 Your understanding is that the commit title should read: "Revert IT of MDEPLOY-231"? This is an auto

[GitHub] [maven-deploy-plugin] michael-o commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2020-12-25 Thread GitBox
michael-o commented on pull request #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751247730 I am confused by your statement. I do not restore the IT, I am removing it. Please explain how you understand the issue is still valid. -