[GitHub] [maven-deploy-plugin] rfscholte commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2020-12-25 Thread GitBox
rfscholte commented on pull request #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751289327 But based on the Maven version we know the default generated checksum right? This is an automated mes

[GitHub] [maven-deploy-plugin] rfscholte commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2020-12-25 Thread GitBox
rfscholte commented on pull request #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751288561 I was a bit confused, but it is not a complete revert, just partial. However, I think it is valid to keep this IT. It in an _integration test_ that ensures the chec

[GitHub] [maven-deploy-plugin] rfscholte commented on pull request #16: Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

2020-12-25 Thread GitBox
rfscholte commented on pull request #16: URL: https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751231372 I think the description is wrong, because MDEPLOY-231 is still valid to me. It looks like you're only restoring an IT, which is not the same. ---