cstamas commented on PR #11:
URL:
https://github.com/apache/maven-file-management/pull/11#issuecomment-1169218949
General: this is a utility class, is NOT a component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
cstamas commented on PR #11:
URL:
https://github.com/apache/maven-file-management/pull/11#issuecomment-1169217540
verbose is orthogonal to log level. That's all IMHO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
cstamas commented on PR #11:
URL:
https://github.com/apache/maven-file-management/pull/11#issuecomment-1169217153
re verbose: disagree. This is "verbose", will tell more, that's all. Log
level is INFO
--
This is an automated message from the Apache Git Service.
To respond to the
cstamas commented on PR #11:
URL:
https://github.com/apache/maven-file-management/pull/11#issuecomment-1169190109
Tidied up completely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cstamas commented on PR #11:
URL:
https://github.com/apache/maven-file-management/pull/11#issuecomment-1168588059
> Why do you I have the feeling that I have seen this with Plexus Utils too?!
This is "already seen" to me as well, no idea where but really looks
familiar...
--
This
cstamas commented on PR #11:
URL:
https://github.com/apache/maven-file-management/pull/11#issuecomment-1167323621
https://github.com/search?l=Java=org.apache.maven.shared.model.fileset.util.FileSetManager=Code
--
This is an automated message from the Apache Git Service.
To respond to
cstamas commented on PR #11:
URL:
https://github.com/apache/maven-file-management/pull/11#issuecomment-1167322093
maven-jar-plugin for sure, unsure for others, but gh search reveals a LOT of
uses across many (non our) plugins
--
This is an automated message from the Apache Git
cstamas commented on PR #11:
URL:
https://github.com/apache/maven-file-management/pull/11#issuecomment-1167304592
Hm, maybe we need NoopMessageSink to retain existing behaviour with defautl
ctor... as now it will use sl4j logger and this is behaviour change from before
when def ctor used.
cstamas commented on PR #11:
URL:
https://github.com/apache/maven-file-management/pull/11#issuecomment-1167272364
Of course, but did not want to mix the two (there are a LOT of other changes
already requiring it)
--
This is an automated message from the Apache Git Service.
To respond to
