[GitHub] [maven-file-management] elharo commented on pull request #18: [MSHARED-1203] Move tests to nio

2023-06-08 Thread via GitHub
elharo commented on PR #18: URL: https://github.com/apache/maven-file-management/pull/18#issuecomment-1582773637 @slachiewicz It is now finally passing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-file-management] elharo commented on pull request #18: [MSHARED-1203] Move tests to nio

2023-06-08 Thread via GitHub
elharo commented on PR #18: URL: https://github.com/apache/maven-file-management/pull/18#issuecomment-1582696018 same problem ``` Error: org.apache.maven.shared.model.fileset.util.FileSetUtilsTest.testIncludesDontFollowSymlinks Time elapsed: 0.062 s <<< ERROR! java.nio.fil

[GitHub] [maven-file-management] elharo commented on pull request #18: [MSHARED-1203] Move tests to nio

2023-06-06 Thread via GitHub
elharo commented on PR #18: URL: https://github.com/apache/maven-file-management/pull/18#issuecomment-1579525169 So here's a hypothesis: the way this test creates test directories is borked. Instead it should use a JUnit TemporaryFolder Rule and let that handle the cleanup: https://

[GitHub] [maven-file-management] elharo commented on pull request #18: [MSHARED-1203] Move tests to nio

2023-06-06 Thread via GitHub
elharo commented on PR #18: URL: https://github.com/apache/maven-file-management/pull/18#issuecomment-1579506425 ``` [INFO] Error: Errors: Error:FileSetUtilsTest.tearDown:55 � DirectoryNotEmpty D:\a\maven-file-management\maven-file-management\target\test-directories\testDele