[GitHub] [maven-fluido-skin] olamy commented on a diff in pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro

2022-04-20 Thread GitBox
olamy commented on code in PR #22: URL: https://github.com/apache/maven-fluido-skin/pull/22#discussion_r854029481 ## pom.xml: ## @@ -260,6 +261,7 @@ under the License. site + true Review Comment: yes because it he

[GitHub] [maven-fluido-skin] olamy commented on a diff in pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro

2022-04-20 Thread GitBox
olamy commented on code in PR #22: URL: https://github.com/apache/maven-fluido-skin/pull/22#discussion_r854027983 ## src/site/apt/ITs.apt: ## @@ -32,6 +32,8 @@ Maven Fuido Skin ITs * {{{./mskins-14/index.html}Search}} + * {{{./mskins-177-apache-analytics/index.html}Apach

[GitHub] [maven-fluido-skin] olamy commented on a diff in pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro

2022-04-20 Thread GitBox
olamy commented on code in PR #22: URL: https://github.com/apache/maven-fluido-skin/pull/22#discussion_r853973657 ## pom.xml: ## @@ -260,6 +261,7 @@ under the License. site + true Review Comment: because when runn

[GitHub] [maven-fluido-skin] olamy commented on a diff in pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro

2022-04-19 Thread GitBox
olamy commented on code in PR #22: URL: https://github.com/apache/maven-fluido-skin/pull/22#discussion_r853468880 ## pom.xml: ## @@ -38,8 +38,8 @@ under the License. 2011 - scm:git:https://gitbox.apache.org/repos/asf/maven-fluido-skin.git - scm:git:https://gitbo