[GitHub] [maven-jar-plugin] rhowe commented on a diff in pull request #47: Code simplifications in AbstractMojo

2022-08-13 Thread GitBox
rhowe commented on code in PR #47: URL: https://github.com/apache/maven-jar-plugin/pull/47#discussion_r945105160 ## src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java: ## @@ -196,16 +196,17 @@ protected File getJarFile( File basedir, String resultFinalName, String

[GitHub] [maven-jar-plugin] rhowe commented on a diff in pull request #47: Code simplifications

2022-08-10 Thread GitBox
rhowe commented on code in PR #47: URL: https://github.com/apache/maven-jar-plugin/pull/47#discussion_r943145103 ## src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java: ## @@ -196,16 +196,17 @@ protected File getJarFile( File basedir, String resultFinalName, String

[GitHub] [maven-jar-plugin] rhowe commented on a diff in pull request #47: Code simplifications

2022-08-10 Thread GitBox
rhowe commented on code in PR #47: URL: https://github.com/apache/maven-jar-plugin/pull/47#discussion_r942610239 ## src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java: ## @@ -196,16 +196,17 @@ protected File getJarFile( File basedir, String resultFinalName, String