[GitHub] [maven-parent] olamy commented on pull request #82: [MPOM-349] Apply spotless to check/reformat code + poms

2022-10-23 Thread GitBox
olamy commented on PR #82: URL: https://github.com/apache/maven-parent/pull/82#issuecomment-1288066873 > > LGTM but if we move to spotless. I would remove `checkstyle:check` as well as we do not need really to check sources style twice during the build > > And it's a bit confusing as

[GitHub] [maven-parent] olamy commented on pull request #82: [MPOM-349] Apply spotless to check/reformat code + poms

2022-10-22 Thread GitBox
olamy commented on PR #82: URL: https://github.com/apache/maven-parent/pull/82#issuecomment-1288023514 LGTM but if we move to spotless. I would remove `checkstyle:check` as well as we do not need really to check sources style twice during the build And it's a bit confusing as when tes