[GitHub] [maven-pmd-plugin] timtebeek commented on pull request #124: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)

2023-05-08 Thread via GitHub
timtebeek commented on PR #124: URL: https://github.com/apache/maven-pmd-plugin/pull/124#issuecomment-1539062036 > In fact, now that I think about it, we should pause these changes until Moderne does sign the corporate CLA. An Individual CLA is insufficient given the co-authorship line.

[GitHub] [maven-pmd-plugin] timtebeek commented on pull request #124: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)

2023-04-20 Thread via GitHub
timtebeek commented on PR #124: URL: https://github.com/apache/maven-pmd-plugin/pull/124#issuecomment-1515932350 > You can assign these reviews to me. I might not get to all of them this quickly but they're not hard to review. Appreciate it! I'll start with the project that benefit

[GitHub] [maven-pmd-plugin] timtebeek commented on pull request #124: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)

2023-04-19 Thread via GitHub
timtebeek commented on PR #124: URL: https://github.com/apache/maven-pmd-plugin/pull/124#issuecomment-1514784283 Thanks for the quick review. It's now very easy to create more of these pull requests, but I obviously want to limit spam and only make these if welcome. Any guidance there on