[GitHub] [maven-resolver] cstamas commented on pull request #161: [MRESOLVER-248] Make BF and DF collectors coexists

2022-04-07 Thread GitBox
cstamas commented on PR #161: URL: https://github.com/apache/maven-resolver/pull/161#issuecomment-1092462803 Right, doco changes are missing (2 new config keys), will add them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [maven-resolver] cstamas commented on pull request #161: [MRESOLVER-248] Make BF and DF collectors coexists

2022-04-07 Thread GitBox
cstamas commented on PR #161: URL: https://github.com/apache/maven-resolver/pull/161#issuecomment-1091126958 @caiwei-ebay all looking good here? Any proposal to change/add? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [maven-resolver] cstamas commented on pull request #161: [MRESOLVER-248] Make BF and DF collectors coexists

2022-04-07 Thread GitBox
cstamas commented on PR #161: URL: https://github.com/apache/maven-resolver/pull/161#issuecomment-1091126697 @michael-o any blocker here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-resolver] cstamas commented on pull request #161: [MRESOLVER-248] Make BF and DF collectors coexists

2022-04-05 Thread GitBox
cstamas commented on PR #161: URL: https://github.com/apache/maven-resolver/pull/161#issuecomment-1088318575 General remark: the convention to name package as "internal" or "impl" should automatically imply this is INTERNAL thing (AFAIK, some OSGi tooling and Takari life-cycle even enforce

[GitHub] [maven-resolver] cstamas commented on pull request #161: [MRESOLVER-248] Make BF and DF collectors coexists

2022-04-04 Thread GitBox
cstamas commented on PR #161: URL: https://github.com/apache/maven-resolver/pull/161#issuecomment-1087902959 I think I collapsed/deduped mostly what was obvious... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [maven-resolver] cstamas commented on pull request #161: [MRESOLVER-248] Make BF and DF collectors coexists

2022-04-04 Thread GitBox
cstamas commented on PR #161: URL: https://github.com/apache/maven-resolver/pull/161#issuecomment-1087715982 @caiwei-ebay ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific