cstamas edited a comment on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-818693664
> I understand this now, but am not happy with for the following reasons: We
have a hard requirement on reentrancy, it is up to the lock to implement that
properly. If
cstamas edited a comment on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-818667466
> There is one more thing I do not understand and think that this undermines
reentrancy: While I understand that you maintain a concurrent map in
`NamedLockFactorySupp
cstamas edited a comment on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-811824284
> A left a few comments, please go through.
>
> * I have a few more homework to do because I do not fully understand all
involved layers with `AdaptedReadWriteLo
cstamas edited a comment on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-811791981
General remark: my personal preference for local variables is to declare
them as they are, so `Type variable = new Type()`, in cases when the variable
is strictly loca
cstamas edited a comment on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-811791981
General remark: my personal preference for local variables is to declare
them as they are, so `T variable = new T()`, in cases when the variable is
strictly local scop
cstamas edited a comment on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-811791981
General remark: my personal preference for local variables is to declare
them as `T variable = new T()`, in cases when the variable is strictly local
scoped. I really
cstamas edited a comment on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-751683148
Howdy @rmannibucau
For now I consider both HZ and Redisson as "lab" implementation still, due
these:
* for HZ to work we either must use deprecated HZ 3.x call
cstamas edited a comment on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-751683148
Howdy @rmannibucau
For now I consider both HZ and Redisson as "lab" implementation still, due
these:
* for HZ to work we either must use deprecated HZ 3.x call
cstamas edited a comment on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-731602192
3 nodes are required for CP only w/ Hazelcast 3.x cluster (RAFT consensus
backed structures), and yes, is overkill (but someone may choose to run a
"dedicated cluster"
