[GitHub] [maven-shade-plugin] Tibor17 commented on pull request #95: [MSHADE-391] Do not write modified class files for no-op relocations

2021-07-18 Thread GitBox
Tibor17 commented on pull request #95: URL: https://github.com/apache/maven-shade-plugin/pull/95#issuecomment-882133546 @eolivelli @rmannibucau It looks like you have approved all commits. Are there any objections to push this? -- This is an automated message from the Apache Gi

[GitHub] [maven-shade-plugin] Tibor17 commented on pull request #95: [MSHADE-391] Do not write modified class files for no-op relocations

2021-07-19 Thread GitBox
Tibor17 commented on pull request #95: URL: https://github.com/apache/maven-shade-plugin/pull/95#issuecomment-882877678 @kriegaex Pls squash these commits to one. We will include this PR in a release. Thx -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [maven-shade-plugin] Tibor17 commented on pull request #95: [MSHADE-391] Do not write modified class files for no-op relocations

2021-07-20 Thread GitBox
Tibor17 commented on pull request #95: URL: https://github.com/apache/maven-shade-plugin/pull/95#issuecomment-883216671 @kriegaex The reason why it should be squashed is one Jira issue MSHADE-391. The commits are worth for thinking process in the PR but it is useless for the history in

[GitHub] [maven-shade-plugin] Tibor17 commented on pull request #95: [MSHADE-391] Do not write modified class files for no-op relocations

2021-07-20 Thread GitBox
Tibor17 commented on pull request #95: URL: https://github.com/apache/maven-shade-plugin/pull/95#issuecomment-882877678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [maven-shade-plugin] Tibor17 commented on pull request #95: [MSHADE-391] Do not write modified class files for no-op relocations

2021-07-20 Thread GitBox
Tibor17 commented on pull request #95: URL: https://github.com/apache/maven-shade-plugin/pull/95#issuecomment-882877678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [maven-shade-plugin] Tibor17 commented on pull request #95: [MSHADE-391] Do not write modified class files for no-op relocations

2021-07-21 Thread GitBox
Tibor17 commented on pull request #95: URL: https://github.com/apache/maven-shade-plugin/pull/95#issuecomment-884493721 @kriegaex Thx for contributing! See the master... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and